Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

Hello, Stig Brautaset writes: > stardiviner writes: > > [...] > >> @@ -1486,7 +1521,7 @@ the current topic." >> (funcall test)) >> (hide-subtree)) >> (push (point) drill-sections))) >> - "" 'tree)) >> + nil 'tree)) >> (reverse

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

stardiviner writes: [...] > @@ -1486,7 +1521,7 @@ the current topic." > (funcall test)) > (hide-subtree)) > (push (point) drill-sections))) > - "" 'tree)) > + nil 'tree)) > (reverse drill-sections))) Could we have this part

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

Nicolas Goaziou writes: > Hello, > > stardiviner writes: > >> Oh, sorry, seems yes. > > OK. A couple of comments if you don't mind. >> +(defcustom org-drill-pronounce-command "" >> + "Org-drill pronounce command." >> + :type 'string >> + :safe #'stringp >> + :group 'org-drill) > > This is

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

Hello, stardiviner writes: > Oh, sorry, seems yes. OK. A couple of comments if you don't mind. > +(defcustom org-drill-pronounce-command "" > + "Org-drill pronounce command." > + :type 'string > + :safe #'stringp > + :group 'org-drill) This is clearly not a safe command. You can remove

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

Nicolas Goaziou writes: > Hello, > > stardiviner writes: > >> Nicolas Goaziou writes: >> >>> Hello, >>> >>> stardiviner writes: >>> A gentle ping.. >>> >>> I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing >>> Paul Sexton. In the long run, I think this package could

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

Hello, stardiviner writes: > Nicolas Goaziou writes: > >> Hello, >> >> stardiviner writes: >> >>> A gentle ping.. >> >> I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing >> Paul Sexton. In the long run, I think this package could be packaged >> through ELPA instead. > > It

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

Nicolas Goaziou writes: > Hello, > > stardiviner writes: > >> A gentle ping.. > > I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing > Paul Sexton. In the long run, I think this package could be packaged > through ELPA instead. It is indeed not actively maintained. But

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

Hello, stardiviner writes: > A gentle ping.. I'm not sure "org-drill.el" is still actively maintained. I'm Cc'ing Paul Sexton. In the long run, I think this package could be packaged through ELPA instead. >> * etc/ORG-NEWS: mentioned this new feature. Changes to "contrib/" directory are

Re: [O] [PATCH] Add feature to org-drill to auto pronounce word

A gentle ping.. stardiviner writes: > I spend a little time to check out org-drill source code, to find out > where I can insert hook to run function when presenting word. > > Then I finally found the place in ~org-drill-entry~. Here is my patch. > > From

[O] [PATCH] Add feature to org-drill to auto pronounce word

I spend a little time to check out org-drill source code, to find out where I can insert hook to run function when presenting word. Then I finally found the place in ~org-drill-entry~. Here is my patch. >From 81765e9395f5c0bec21d44aeaf16919d35a39eee Mon Sep 17 00:00:00 2001 From: stardiviner