Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-09-28 Thread Rasmus
Aaron Ecay writes: >>> Merging the functions might only be worth doing if there were any more >>> places where \captionof needed to be used. >> >> That's the intent, yes. It would be a waste not to use a package now >> residing in the default list. Among the transcoders where >> `org-latex--wrap

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-09-28 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > Done on master. Thanks. > OK. I’ll think about this. One question is what type of caption this > should be. (i.e. \captionof{what?}{the caption}). Using the catch-all > figure caption type seems most sensible to me, but feedback from other > latex users is welco

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-09-27 Thread Aaron Ecay
Hi Nicolas, 2014ko irailak 23an, Nicolas Goaziou-ek idatzi zuen: > > Hello, > > Aaron Ecay writes: > >> Thanks for all your feedback. The patch is now applied on master. > > Thank you. > >> I’m confused about how ‘org-latex--wrap-label’ works. It tries to >> put \label commands outside of

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-09-23 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > Thanks for all your feedback. The patch is now applied on master. Thank you. > I’m confused about how ‘org-latex--wrap-label’ works. It tries to > put \label commands outside of floats. That will yield links that > jump to the preceding section, not the specific

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-09-22 Thread Aaron Ecay
Hi Nicolas, 2014ko irailak 19an, Nicolas Goaziou-ek idatzi zuen: [...] > > In any case, I think you can apply the patch once the docstrings > questions above have been sorted out. Thanks for all your feedback. The patch is now applied on master. > This can do for now. Ultimately, however, I

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-09-19 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > See the attached patch. Thanks for the patch. > I updated ORG-NEWS, but the manual (info "(org) LaTeX specific > attributes") is already sufficiently general IMO. OK. > +- capt-of: for captions on `:float nil' source blocks I think this is too limiting as we migh

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-09-19 Thread Aaron Ecay
Hi Nicolas, 2014ko abuztuak 28an, Nicolas Goaziou-ek idatzi zuen: > > Hello, > > Aaron Ecay writes: > >> The other application I can think of is to allow captioned images and >> tables not to float. The LaTeX world is full of tutorials on how to >> un-float floating images and tables, but IME

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-28 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > The other application I can think of is to allow captioned images and > tables not to float. The LaTeX world is full of tutorials on how to > un-float floating images and tables, but IME the org community doesn’t > ask for this. (perhaps they implement their own sol

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-27 Thread Aaron Ecay
Hi Nicolas, 2014ko abuztuak 24an, Nicolas Goaziou-ek idatzi zuen: > > Hello, > > Aaron Ecay writes: > >> Why is the compatibility=false option needed? I can’t figure this >> out. > > This is in my local copy of the minted manual, in "7 Known issues". It > may be outdated, though. Hmm. I ha

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-24 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > Why is the compatibility=false option needed? I can’t figure this > out. This is in my local copy of the minted manual, in "7 Known issues". It may be outdated, though. > “Pretty” source code export in all cases requires adding certain packages > to the default, as

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-23 Thread Nicolas Richard
Aaron Ecay writes: >> With your patch, when encountering the combination above, the export >> back-end will introduce a "captionof" command, which requires loading >> "caption" package with a specific option (i.e., compatibility=false). > > Why is the compatibility=false option needed? I can’t f

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-23 Thread Aaron Ecay
Hi Nicolas, 2014ko abuztuak 23an, Nicolas Goaziou-ek idatzi zuen: > > Aaron Ecay writes: > >> It’s not adding any new functionality to the exporter, > > Well, it is, since "captionof" command doesn't exist in Org default > packages. I guess this was unclear. What I meant was that the patch i

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-23 Thread Nicolas Goaziou
Aaron Ecay writes: > It’s not adding any new functionality to the exporter, Well, it is, since "captionof" command doesn't exist in Org default packages. > but rather covering one particular combination of already-existing > options (caption provided, :float nil, org-latex-listings = minted) >

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-23 Thread Aaron Ecay
Hi Nicolas, 2014ko abuztuak 23an, Nicolas Goaziou-ek idatzi zuen: > > Hello, > > Aaron Ecay writes: > >> * lisp/ox-latex.el (org-latex-src-block): Support :float no with >> caption for minted. >> (org-latex-listings): Edit docstring to describe this usecase. > > There is already :float nil, w

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-23 Thread Nicolas Goaziou
Hello, Aaron Ecay writes: > * lisp/ox-latex.el (org-latex-src-block): Support :float no with > caption for minted. > (org-latex-listings): Edit docstring to describe this usecase. There is already :float nil, which is documented in the manual. > + (cond ((and (string= "no" float) c

[O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings

2014-08-23 Thread Aaron Ecay
* lisp/ox-latex.el (org-latex-src-block): Support :float no with caption for minted. (org-latex-listings): Edit docstring to describe this usecase. This takes advantage of the caption package’s \captionof command, which allows to insert a caption (with autogenerated number and \ref-able label) wit