Eric S Fraga writes:
> On Saturday, 1 May 2021 at 08:56, Bastien wrote:
>> I have fixed this with commit ee507de47, can you confirm?
>
> Seems to work just fine now. Thank you.
Thanks for confirming!
--
Bastien
Hi Bastien,
On Saturday, 1 May 2021 at 08:56, Bastien wrote:
> I have fixed this with commit ee507de47, can you confirm?
Seems to work just fine now. Thank you.
--
: Eric S Fraga via Emacs 28.0.50, Org release_9.4.5-405-g0a689b
Hi Eric,
Eric S Fraga writes:
> On Thursday, 29 Apr 2021 at 02:04, Timothy wrote:
>> Have you had a chance to test this out?
>
> Further on this, I don't have time to debug right now but the patch
> seems to have broken org table recalculation, specifically C-u C-c C-c
> on a table.
I have
Eric S Fraga writes:
> I get this when I try:
Thanks - I see what's wrong, I'll fix it.
--
Bastien
On Friday, 30 Apr 2021 at 20:16, Timothy wrote:
> Thank you for taking the time to check this in what sounds like a busy
> day, and the backtrace. It's much appreciated :)
Thank you. All days are busy (for all/most of us, I'm sure) but org is
a major part of my day's work so always happy to try
Eric S Fraga writes:
> I have updated org. Problem persists.
>
> Attached is a full backtrace after hitting C-u C-c C-c on a table. The
> document itself has 2 headings and a small table.
>
> I unfortunately cannot spend more time on this at the moment as I have a
> presentation to make this
I have updated org. Problem persists.
Attached is a full backtrace after hitting C-u C-c C-c on a table. The
document itself has 2 headings and a small table.
I unfortunately cannot spend more time on this at the moment as I have a
presentation to make this afternoon and it's not quite
On Friday, 30 Apr 2021 at 16:52, Timothy wrote:
> I checked the docs for `org-table-recalculate' and based on manually
> calling it compared the behaviour to C-u C-c C-c on a table and noticed
> no difference, but I'm not familiar with the intended functionality so
> an example from Eric (or
Bastien writes:
> Eric S Fraga writes:
>
>> Further on this, I don't have time to debug right now but the patch
>> seems to have broken org table recalculation, specifically C-u C-c C-c
>> on a table.
>
> Thanks for reporting - Tim can you double-check this?
I checked the docs for
Eric S Fraga writes:
> On Thursday, 29 Apr 2021 at 02:04, Timothy wrote:
>> Have you had a chance to test this out?
>
> Further on this, I don't have time to debug right now but the patch
> seems to have broken org table recalculation, specifically C-u C-c C-c
> on a table.
Thanks for reporting
On Thursday, 29 Apr 2021 at 02:04, Timothy wrote:
> Have you had a chance to test this out?
Further on this, I don't have time to debug right now but the patch
seems to have broken org table recalculation, specifically C-u C-c C-c
on a table.
Have to run to a meeting but will try to check this
Hi Timothy,
Timothy writes:
> Now that Eric and I have both tested this, and Nicolas' comments have
> been taken into account, it would be great if a core maintainer could
> consider applying this patch :)
Done with commit aea31b065 in master, thanks to everyone in this thread.
I allowed
Now that Eric and I have both tested this, and Nicolas' comments have
been taken into account, it would be great if a core maintainer could
consider applying this patch :)
--
Timothy
p.s. I'm specifically making a new reply to the version of the patch
that should be looked at, in the hope that
Hi Timothy,
On Thursday, 29 Apr 2021 at 02:04, Timothy wrote:
> Have you had a chance to test this out?
Yes, sorry for the delay; work pressures... C-c C-c seems to work fine
on #+plot lines and the point does not move.
thank you,
eric
--
: Eric S Fraga via Emacs 28.0.50, Org
Hi Eric,
Have you had a chance to test this out?
--
Timothy
Hi Eric,
Eric S Fraga writes:
> On Monday, 26 Apr 2021 at 17:11, Timothy wrote:
>> Since you don't seem to have pushed yet, here's an updated patche that
>> takes into account Nicolas' comments.
>
> Oh, and to clarify: I don't have push access; I can only do testing but
> not installation!
If
On Monday, 26 Apr 2021 at 17:11, Timothy wrote:
> Since you don't seem to have pushed yet, here's an updated patche that
> takes into account Nicolas' comments.
Oh, and to clarify: I don't have push access; I can only do testing but
not installation!
--
: Eric S Fraga via Emacs 28.0.50, Org
On Monday, 26 Apr 2021 at 17:11, Timothy wrote:
> Since you don't seem to have pushed yet, here's an updated patche that
> takes into account Nicolas' comments.
Thank you. I've incorporated that patch and will test out tomorrow.
--
: Eric S Fraga via Emacs 28.0.50, Org
On Monday, 26 Apr 2021 at 16:24, Timothy wrote:
> A while ago Eric raised two nice suggestions. (2) has just been
> implemented as Bastien reminded me that I can now just push straight to
> Org for org-plot.el without going through a patch-review process.
>
> This patch resolves (1).
Timothy,
... I didn't regenerate the patch after amending the commit.
:big sigh: Take 4
>From 4e5fcb4726711ff356656cb6fccf6e341656443d Mon Sep 17 00:00:00 2001
From: TEC
Date: Tue, 27 Apr 2021 00:05:37 +0800
Subject: [PATCH] org: Enable plotting with C-c C-c
* lisp/org.el (org-ctrl-c-ctrl-c): When at
Timothy writes:
> Since you don't seem to have pushed yet, here's an updated patch that
> takes into account Nicolas' comments.
... and that patch didn't take into account the need to escape "+" in
the regex.
Take 3.
>From 4e5fcb4726711ff356656cb6fccf6e341656443d Mon Sep 17 00:00:00 2001
Since you don't seem to have pushed yet, here's an updated patche that
takes into account Nicolas' comments.
>From 04270b64315fed399748509f1c09428557b7742d Mon Sep 17 00:00:00 2001
From: TEC
Date: Tue, 27 Apr 2021 00:05:37 +0800
Subject: [PATCH] org: Enable plotting with C-c C-c
* lisp/org.el
Hello,
Timothy writes:
> + (cond
> + ((string-match-p "#\\+plot" (thing-at-point 'line t))
The whole `org-ctrl-c-ctrl-c' function relies on the parser. It would be
nice to use it for this case too.
Here a more accurate check would be:
A while ago Eric raised two nice suggestions. (2) has just been
implemented as Bastien reminded me that I can now just push straight to
Org for org-plot.el without going through a patch-review process.
This patch resolves (1).
Eric S Fraga writes:
> 1. it would be consistent and useful if
24 matches
Mail list logo
