Re: [PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

Nick Savage writes: > Please see the attached updated patch with the changes requested. Thanks. Pushed (37749c165). > + (declare (obsolete "use `org-babel-sql-expand-vars' instead." "Org 9.4")) ... changing "Org 9.4" to "Org 9.5".

Re: [PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

as suggested by the FIXME in ob-sqlite.el. Thank you. Looks good, though I think it'd be nice to keep org-babel-sqlite-expand-vars around for a bit, marked as obsolete. Subject: [PATCH] Reduce code duplication in ob-sqlite.el and ob-sql.el * lisp/ob-sqlite.el (org-babel-sqlite-expand-vars): removed

Re: [PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

ice to keep org-babel-sqlite-expand-vars around for a bit, marked as obsolete. > Subject: [PATCH] Reduce code duplication in ob-sqlite.el and ob-sql.el > > * lisp/ob-sqlite.el (org-babel-sqlite-expand-vars): removed function > to replace with ob-sql.el version > * lisp/ob-sql

[PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

rom: Nicholas Savage Date: Wed, 3 Mar 2021 07:47:15 -0500 Subject: [PATCH] Reduce code duplication in ob-sqlite.el and ob-sql.el * lisp/ob-sqlite.el (org-babel-sqlite-expand-vars): removed function to replace with ob-sql.el version * lisp/ob-sql.el (org-babel-sql-expand-vars): updated to supp