Max Nikulin writes:
> another option is to use --always
>
> git describe --match release\* --abbrev=6 --always HEAD
> 52f29d
This is indeed more reliable.
Applied, onto main. With your version instead of git log.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=6d37d2a8e
> and
No Wayman writes:
> Why not use ORGVERSION here? Is the metadata in org.el's version
> header not updated when a commit is tagged as a release?
ORGVERSION can be ahead of the last released version.
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at
Ihor Radchenko writes:
No Wayman writes:
Feel free to take this the patch as a base to do whatever you
please with it.
Then, I am thinking about a simple approach that will not
involve
internet connection. See the attached.
I think that's the best solution. I landed on something
On 20/01/2023 19:44, Ihor Radchenko wrote:
diff --git a/mk/targets.mk b/mk/targets.mk
index 4435daa..164b092 100644
--- a/mk/targets.mk
+++ b/mk/targets.mk
@@ -14,7 +14,7 @@ ifneq ($(wildcard .git),)
# Use the org.el header.
ORGVERSION := $(patsubst %-dev,%,$(shell $(BATCH) --eval
No Wayman writes:
> Feel free to take this the patch as a base to do whatever you
> please with it.
Then, I am thinking about a simple approach that will not involve
internet connection. See the attached.
Note that you, in fact, can fetch the latest tags from remote into
shallow clone. See
Ihor Radchenko writes:
No Wayman writes:
No Wayman writes:
The attached patch should take care of that.
Thanks!
I played a bit more with the patch and noticed that remote tag
lookup is
not performed prior to _any_ make command.
For example, there is a noticeable delay on my
No Wayman writes:
> No Wayman writes:
>
>> The attached patch should take care of that.
Thanks!
I played a bit more with the patch and noticed that remote tag lookup is
not performed prior to _any_ make command.
For example, there is a noticeable delay on my network when running
something as
No Wayman writes:
The attached patch should take care of that.
Sorry. Had trailing whitespace in that version.
Attached here without trailing whitespace.
>From 85990610ca7572f5a6ff7604d957efdf00747094 Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer
Date: Mon, 16 Jan 2023 14:00:41 -0500
Ihor Radchenko writes:
No Wayman writes:
Ihor Radchenko writes:
What we should not have is "make autoloads" failing without
internet.
The attached patch should take care of that.
If the ls-remote errors, GITVERSION will be set to N/A as when
it
is generally unavailable.
I just
No Wayman writes:
> Ihor Radchenko writes:
>
>> What we should not have is "make autoloads" failing without
>> internet.
>
> The attached patch should take care of that.
> If the ls-remote errors, GITVERSION will be set to N/A as when it
> is generally unavailable.
I just tried your patch
Ihor Radchenko writes:
What we should not have is "make autoloads" failing without
internet.
The attached patch should take care of that.
If the ls-remote errors, GITVERSION will be set to N/A as when it
is generally unavailable.
>From 4ce8b2dfc2cf2ca1507aa14be15f5212eb1de229 Mon Sep 17
No Wayman writes:
> In order to properly generate org-version.el, the current build in
> mk/targets.mk requires a query of the repo's tags. Shallow clones
> do not have tags and so org-version will be generated as "N/A". In
> the attached patch, support for generating org-version.el from
>
No Wayman writes:
Sorry, wrong commit value in the previous patch.
Fixed the patch attached here.
>From a4cd70e17455894aec5d15d97eb41b56769e5cde Mon Sep 17 00:00:00 2001
From: Nicholas Vollmer
Date: Sun, 15 Jan 2023 15:44:45 -0500
Subject: [PATCH] * mk/targets.mk (GITVERSION): support
In order to properly generate org-version.el, the current build in
mk/targets.mk requires a query of the repo's tags. Shallow clones
do not have tags and so org-version will be generated as "N/A". In
the attached patch, support for generating org-version.el from
shallow clones is added. It
14 matches
Mail list logo
