Ihor Radchenko writes:
> Also, several small comments about the commit message.
For the record, an amended version of this patch have been applied.
See https://orgmode.org/list/87leona2r1.fsf@localhost
--
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at
Daniel Ziltener writes:
>> Could you please create a separate patch file and attach it in the
>> reply?
> Sure, here's the patch attached, as generated by "git format-patch
> origin/main".
Thanks!
I tried to apply your patch and run tests. The new test for
"strip-tangle" is failing on my
Hi Ihor,
> #+name: setup
> #+begin_src bash
>
> cd /path/to/tests
> #+end_src
>
> #+begin_src bash :noweb strip-tangle
>
> make test1
> #+end_src
>
> #+begin_src bash :noweb strip-tangle
>
> make test2
> #+end_src
>
> Then, one can interactively run individual tests from Org and then
> tangle
Timothy writes:
> Hi Daniel,
>
>> Add a “strip-tangle” noweb option to strip the noweb tags when tangling, but
>> keep and expand them otherwise.
>
> I must admit I can’t see the point of this — would you mind providing an
> example of when this would be useful?
#+name: setup
#+begin_src bash
Am 30.10.22 um 05:12 schrieb Ihor Radchenko:
Daniel Ziltener writes:
From: Daniel Ziltener
* lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags
from block if :noweb has been set to strip-tangle.
* lisp/ob-core.el (org-babel-common-header-args-w-values): add
"strip-tangle"
Hi Daniel,
> Add a “strip-tangle” noweb option to strip the noweb tags when tangling, but
> keep and expand them otherwise.
I must admit I can’t see the point of this — would you mind providing an
example of when this would be useful?
All the best,
Timothy
--
Timothy (‘tecosaur’/‘TEC’), Org
Daniel Ziltener writes:
> From: Daniel Ziltener
>
> * lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags
> from block if :noweb has been set to strip-tangle.
> * lisp/ob-core.el (org-babel-common-header-args-w-values): add
> "strip-tangle" as new allowed value.
> *
From: Daniel Ziltener
* lisp/ob-tangle.el (org-babel-tangle-single-block): strip noweb tags
from block if :noweb has been set to strip-tangle.
* lisp/ob-core.el (org-babel-common-header-args-w-values): add
"strip-tangle" as new allowed value.
* testing/lisp/test-ob-tangle.el
Daniel Ziltener writes:
>> Could you please follow
>> https://orgmode.org/worg/org-contribute.html#commit-messages for the
>> commit log entries?
> I tried to follow that. To follow it "more" I guess I have to make one
> commit per file I changed? There isn't an example for multiple files, so
Am 28.10.22 um 04:19 schrieb Ihor Radchenko:
dzilte...@lyrion.ch writes:
From: Daniel Ziltener
* ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a
"strip-tangle" noweb option to strip the noweb tags when tangling, but
keep and expand them otherwise.
Thanks for the patch!
dzilte...@lyrion.ch writes:
> From: Daniel Ziltener
>
> * ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a
> "strip-tangle" noweb option to strip the noweb tags when tangling, but
> keep and expand them otherwise.
Thanks for the patch!
If I understand correctly, you are
From: Daniel Ziltener
* ob-tangle.el, ob-core.el, test-ob-tangle.el, org-manual.org: Add a
"strip-tangle" noweb option to strip the noweb tags when tangling, but
keep and expand them otherwise.
---
doc/org-manual.org | 6 ++
lisp/ob-core.el| 6 +++---
12 matches
Mail list logo
