Re: [PATCH 0/4] Structure editing when region is active

2023-04-02 Thread Ihor Radchenko
Philipp Kiefer writes: > There is a bug here, where moving a region of several headings down, > then up will snag another heading onto the bottom of the region. See the > screencast for illustration. To reproduce, in the sample file use Alt-h > twich to select the headings 'Select 1' and

Re: [PATCH 0/4] Structure editing when region is active

2023-02-15 Thread Ihor Radchenko
Rudolf Adamkovič writes: > P.S. It took me a while to get all this because I do not use (nor have, for > that > matter) arrow keys, and those nonsensical function names mean absolutely > nothing > to me. If you have ideas about good alternative names for these functions, please share them.

Re: [PATCH 0/4] Structure editing when region is active

2023-02-15 Thread Rudolf Adamkovič
Ihor Radchenko writes: > They indeed do not. Only on selected list items. Patches welcome! Oh, wait I see. Non-recursive manipulation (l/r) works with marked regions but recursive manipulation (L/R) does not work yet. Then, it all behaves correctly and "patches welcome" makes sense (to make

Re: [PATCH 0/4] Structure editing when region is active

2023-02-07 Thread Ihor Radchenko
Rudolf Adamkovič writes: > However, I find it a bit surprising (confusing, really) that > > 'C-c C-x R' and 'C-c C-x L' [ for context, these are `org-shiftmetaright' and `org-shiftmetaleft' > do not promote/demote the selected subtrees, despite being documented as > > "Demote subtree or

Re: [PATCH 0/4] Structure editing when region is active

2023-02-06 Thread Rudolf Adamkovič
Ihor Radchenko writes: > Applied, onto main, dropping the patch to preserve region upon setting > heading state. I also merged the NEWS patch into the corresponding > feature patches. > > https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=b665f8de3 >

Re: [PATCH 0/4] Structure editing when region is active

2023-02-05 Thread Ihor Radchenko
Samuel Wales writes: > thanks for the patches. out of curiosity, does e.g. m-up m-up up deactivate? No. The patches make M-/// not deactivate. Nothing else is affected. If there are use-cases when these commands should deactivate, please share them. -- Ihor Radchenko // yantar92, Org mode

Re: [PATCH 0/4] Structure editing when region is active

2023-02-04 Thread Samuel Wales
thanks for the patches. out of curiosity, does e.g. m-up m-up up deactivate?

Re: [PATCH 0/4] Structure editing when region is active

2023-02-04 Thread Ihor Radchenko
Ihor Radchenko writes: > I'd like to propose a patchset that addresses some issues raised in > https://teddit.zaggy.nl/r/orgmode/comments/10b6ue6/orgmode_is_so_bad_at_rearranging_items_in_an/ > > 1. When acting on region, promotion, demotion, and other structure >editing commands immediately

Re: [PATCH 0/4] Structure editing when region is active

2023-01-18 Thread Ihor Radchenko
Samuel Wales writes: > maybe my comment is too unrelated to the patch, but it just seemed > worth raising in the context. to me it feels wrong to have a > non-linline-task child entry whose heading is star-indented more > levels than needed to denote a child entry. > > in my own case, it

Re: [PATCH 0/4] Structure editing when region is active

2023-01-17 Thread Samuel Wales
On 1/17/23, Ihor Radchenko wrote: >> * one >> ** two >> >> which seemed slightly relevant to the patch. > > Sorry, but could you further elaborate? What kind of integrity and what > kind of structure editing do you have in mind here? maybe my comment is too unrelated to the patch, but it

Re: [PATCH 0/4] Structure editing when region is active

2023-01-17 Thread Ihor Radchenko
Samuel Wales writes: > oh i was just saying what does modern org e.g. main have for ensuring > star structure integrity, if anything. i have a git commit that has > something similar to: > > * one > ** two > > which seemed slightly relevant to the patch. Sorry, but could you further

Re: [PATCH 0/4] Structure editing when region is active

2023-01-16 Thread Samuel Wales
oh i was just saying what does modern org e.g. main have for ensuring star structure integrity, if anything. i have a git commit that has something similar to: * one ** two which seemed slightly relevant to the patch. do i misunderstand? i set region, then set todo kw, which loops me

Re: [PATCH 0/4] Structure editing when region is active

2023-01-16 Thread Ihor Radchenko
Samuel Wales writes: > not really related, but wrt structure editing, is there anything that > preserves integrity of levels? [my old maint version allows double > demotion [perhaps this is related to inline tasks], and i wonder about > org-yank, and org-lint does not complain.] Sorry, but I

Re: [PATCH 0/4] Structure editing when region is active

2023-01-15 Thread Samuel Wales
not really related, but wrt structure editing, is there anything that preserves integrity of levels? [my old maint version allows double demotion [perhaps this is related to inline tasks], and i wonder about org-yank, and org-lint does not complain.] i have encountered cases in org where i find

[PATCH 0/4] Structure editing when region is active

2023-01-15 Thread Ihor Radchenko
Hi, I'd like to propose a patchset that addresses some issues raised in https://teddit.zaggy.nl/r/orgmode/comments/10b6ue6/orgmode_is_so_bad_at_rearranging_items_in_an/ 1. When acting on region, promotion, demotion, and other structure editing commands immediately deactivate selection. It is