Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-09-29 Thread Bastien
Hi Tim, Tim Cross writes: > Thanks Bastien. I think it is good to have a clear statement on this, > even if not everyone agrees, as it makes things explicit. I > suspect this will need to be reviewed after each release of a new Emacs > version though as the effort to maintain backwards

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-09-28 Thread Tim Cross
Bastien writes: > Hi Tim, > > Tim Cross writes: > >> I do think it is probably time to drop support for Emacs 24 in the next >> major release. However, we cannot drop it 'mid release'. > > I've added a section called "Compatibility with Emacs versions" on > this page:

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-09-27 Thread Bastien
Hi Tim, Tim Cross writes: > I do think it is probably time to drop support for Emacs 24 in the next > major release. However, we cannot drop it 'mid release'. I've added a section called "Compatibility with Emacs versions" on this page: https://orgmode.org/worg/org-maintenance.html We now

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Bastien
Kyle Meyer writes: > Kyle Meyer writes: > >> Ah, sorry for not writing that more clearly. By the above, I wasn't >> saying that the ones I commented on were the _only_ ones I see with >> Emacs 24.5 on maint. > > I've dealt with a few more. Thank you both very much! -- Bastien

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Kyle Meyer
Kyle Meyer writes: > Ah, sorry for not writing that more clearly. By the above, I wasn't > saying that the ones I commented on were the _only_ ones I see with > Emacs 24.5 on maint. I've dealt with a few more. * ob-C.el:477:1:Error: Unknown upattern `(quote integerp)' Introduced by

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Kyle Meyer
Ihor Radchenko writes: > Kyle Meyer writes: > >> Here are a few notes on ones present in maint that I've glanced at. > > I confirm that there are no warning using Emacs 25.3.1 on maint. > > For Emacs 24.5.1, I see that following in addition to what you > mentioned: Ah, sorry for not writing

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Bastien
Applied as commit 5f619205e with a change log in the commit message. Thanks! Ihor Radchenko writes: >>> In end of data: >>> ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to >>> be > > This does not appear on maint. Only on master. The patch for master attached. --

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Ihor Radchenko
Bastien writes: > could you provide a patch for these two warnings for the maint branch? >> In end of data: >> ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to >> be This does not appear on maint. Only on master. The patch for master attached. >> In

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-05-01 Thread Ihor Radchenko
Kyle Meyer writes: > Here are a few notes on ones present in maint that I've glanced at. I confirm that there are no warning using Emacs 25.3.1 on maint. For Emacs 24.5.1, I see that following in addition to what you mentioned: Compiling /home/yantar92/Git/org-mode/lisp/ob-python.el...

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-30 Thread Kyle Meyer
Ihor Radchenko writes: > I was recently testing Org mode using old Emacs versions. Running make > on master fails with the following errors and warnings: Here are a few notes on ones present in maint that I've glanced at. > Compiling /home/yantar92/Git/org-mode/lisp/ol-eww.el... > > In

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-30 Thread Bastien
Hi Ihor, Ihor Radchenko writes: > Compiling /home/yantar92/Git/org-mode/lisp/ob-gnuplot.el... > > In end of data: > ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to be > defined. > > Compiling /home/yantar92/Git/org-mode/lisp/org.el... > > In

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-30 Thread Bastien
Hi Tim and everyone, Tim Cross writes: > I do think it is probably time to drop support for Emacs 24 in the next > major release. However, we cannot drop it 'mid release'. yes, I'm in favor of dropping support for Emacs < 25.1 for Org 9.5. Unless Nicolas, Kyle and Jack think otherwise, I'll

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-29 Thread Tim Cross
Timothy writes: > Colin Baxter writes: > >> Debian 9.13 may be old but updates are still made available. While >> Debian supports the os-version and therefore by implication emacs-24, I >> feel org-mode shouldn't deliberately break that support. > > I have to admit, I'm not sure why Org

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-29 Thread Colin Baxter
> Timothy writes: > Colin Baxter writes: >> Debian 9.13 may be old but updates are still made >> available. While Debian supports the os-version and therefore by >> implication emacs-24, I feel org-mode shouldn't deliberately >> break that support. > I have to

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-29 Thread Timothy
Colin Baxter writes: > Debian 9.13 may be old but updates are still made available. While > Debian supports the os-version and therefore by implication emacs-24, I > feel org-mode shouldn't deliberately break that support. I have to admit, I'm not sure why Org support should stretch so far

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-29 Thread Colin Baxter
> Robert Horn writes: > Colin Baxter writes: >>> Robert Horn writes: >> >> > Timothy writes: >> >> >> Ihor Radchenko writes: >> >> >> >> Maybe this is a good time to start a discussion about moving >> >> Org's minimum supported Emacs to 25...?

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-29 Thread Robert Horn
Colin Baxter writes: >> Robert Horn writes: > > > Timothy writes: > > >> Ihor Radchenko writes: > >> > >> Maybe this is a good time to start a discussion about moving > >> Org's minimum supported Emacs to 25...? > > > I checked Red Hat, Centos, Debian, SuSE, and

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-29 Thread Colin Baxter
> Robert Horn writes: > Timothy writes: >> Ihor Radchenko writes: >> >> Maybe this is a good time to start a discussion about moving >> Org's minimum supported Emacs to 25...? > I checked Red Hat, Centos, Debian, SuSE, and Ubuntu. They are all > 25.1 or later

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Robert Horn
Timothy writes: > Ihor Radchenko writes: > > Maybe this is a good time to start a discussion about moving Org's > minimum supported Emacs to 25...? I checked Red Hat, Centos, Debian, SuSE, and Ubuntu. They are all 25.1 or later in their current distributions. So that will probably not cause

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Timothy
Ihor Radchenko writes: > In any case, not all the warnings go away even using Emacs 25.3: Just going to chime in here with the relevant info: > ob-gnuplot.el:299:1:Warning: the function ‘file-local-name’ is not known to be > defined. :added:26.1 It looks like the definition could

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Ihor Radchenko
Timothy writes: > Maybe this is a good time to start a discussion about moving Org's > minimum supported Emacs to 25...? I have no objections here, since I am on Emacs master anyway. In any case, not all the warnings go away even using Emacs 25.3: Compiling

Re: Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Timothy
Ihor Radchenko writes: Maybe this is a good time to start a discussion about moving Org's minimum supported Emacs to 25...? -- Timothy

Bug: Org mode fails to compile using Emacs 24.5-r10 [9.4.5 (9.4.5-g3ea248 @ /home/yantar92/.emacs.d/straight/build/org/)]

2021-04-28 Thread Ihor Radchenko
I was recently testing Org mode using old Emacs versions. Running make on master fails with the following errors and warnings: Compiling /home/yantar92/Git/org-mode/lisp/ob-C.el... Eager macro-expansion failure: (error "Vector QPatterns not implemented yet") Compiling