Re: PATCH: include controlling language= in my previous patch

2022-12-18 Thread Ihor Radchenko
Ihor Radchenko writes: > Pedro Andres Aranda Gutierrez writes: > >> Next try... I'm learning a lot :-) > > Then, next set of comments. As discussed privately, I have addressed the comments myself. Now applied onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=0c467b6b8

Re: PATCH: include controlling language= in my previous patch

2022-12-18 Thread Bastien Guerry
Sorry for the delay. Ihor Radchenko writes: >> FYI, I have already cleared the FSF paperwork for an emacs patch. > > Bastien, could you kindly confirm? Yes, I do confirm Pedro's FSF paperwork is in order. Thanks! -- Bastien

Re: PATCH: include controlling language= in my previous patch

2022-12-14 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > Next try... I'm learning a lot :-) Then, next set of comments. (Note that I can hand-fix the patches at this point for you. Let me know if you want to keep going) > From dabdc3026e32ec674e22698de6257d724f60c4af Mon Sep 17 00:00:00 2001 > From: "Pedro A.

Re: PATCH: include controlling language= in my previous patch

2022-12-13 Thread Pedro Andres Aranda Gutierrez
Next try... I'm learning a lot :-) BR,/PA On Tue, 13 Dec 2022 at 12:51, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > > > thanks for the patience. I hope to have implemented all suggestions by > now. > > No. You missed several. > > 1. :version is not necessary. See 15.1

Re: PATCH: include controlling language= in my previous patch

2022-12-13 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > thanks for the patience. I hope to have implemented all suggestions by now. No. You missed several. 1. :version is not necessary. See 15.1 Common Item Keywords section of Elisp manual: 2. Please also provide changelog entries. See

Re: PATCH: include controlling language= in my previous patch

2022-12-13 Thread Pedro Andres Aranda Gutierrez
Hi, thanks for the patience. I hope to have implemented all suggestions by now. BR,/PA On Tue, 13 Dec 2022 at 10:24, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > > > I've (finally) followed the procedure and broken up the patch in two. One > > for the labels= ,caption=

Re: PATCH: include controlling language= in my previous patch

2022-12-13 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > I've (finally) followed the procedure and broken up the patch in two. One > for the labels= ,caption= and one for the language= control. Thanks! You also need to provide etc/ORG-NEWS entry since we are adding a new feature here. > FYI, I have already

Re: PATCH: include controlling language= in my previous patch

2022-12-12 Thread Pedro Andres Aranda Gutierrez
Hi, I've (finally) followed the procedure and broken up the patch in two. One for the labels= ,caption= and one for the language= control. FYI, I have already cleared the FSF paperwork for an emacs patch. Best, /PA On Mon, 12 Dec 2022 at 11:11, Ihor Radchenko wrote: > Pedro Andres Aranda

Re: PATCH: include controlling language= in my previous patch

2022-12-12 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > thanks for the patience. I have a comment on the message you refer to... If > comes from 2014. > > So I have resorted to my fresh Emacs29, opened it with emacs -Q for a clean > environment. > ... > In my most humble opinion, I looks like the global

Re: PATCH: include controlling language= in my previous patch

2022-12-11 Thread Pedro Andres Aranda Gutierrez
Hi Ihor, thanks for the patience. I have a comment on the message you refer to... If comes from 2014. So I have resorted to my fresh Emacs29, opened it with emacs -Q for a clean environment. With the MWE ``` #+CAPTION: caption of block 1 #+BEGIN_SRC asm vmpovapd %%zmm0, %zmm1 #+END_SRC

Re: PATCH: include controlling language= in my previous patch

2022-12-11 Thread Ihor Radchenko
Note: This email thread is a followup for https://orgmode.org/list/cao48bk_6bqkgp1mgnzaaryku2+st6r1d4bziq5nzmwnewqf...@mail.gmail.com Pedro Andres Aranda Gutierrez writes: > I have a second version of my previous patch, inlcuing and extra variable > to control whether you want to include the