Re: restore window configuration after org-edit-src-exit

[Jack Kamm]

Hi,

> I think any value that modifies the current layout ought to restore it:
> - `split-window-below'
> - `split-window-right'
> - `reorganize-frame'
>
> OTOH, values that use the current layout should not restore it
> afterwards:
> - `current-window'
> - `other-window'
> - `other-frame'
>
> This should be mentioned in the docstring.
>
> WDYT?

I agree, this sounds like the correct behavior to me.

Re: [PATCH] Add customization to fontify TODO headlines

[Nicolas Goaziou]

Hello,

Terje Larsen  writes:

> This adds a feature similar to the org-fontify-done-headline, but
> instead for the TODO headlines.
>
> This is enabled with the boolean customization org-fontify-todo-headline
> and can be themed via the face org-headline-todo.
>
> I was missing this when I wanted to distinguish more clearly between the
> TODO headlines and the other headlines (more so than the highlighted
> TODO keyword(s)).

Applied. Thank you.

I added a TINYCHANGE cookie at the end of the commit message since
I don't know if signed FSF papers already. If you did, please let me
know.

Regards,

-- 
Nicolas Goaziou

Re: restore window configuration after org-edit-src-exit

[Nicolas Goaziou]

Hello,

Jack Kamm  writes:

> Rather than adding a new option, how about we make the behavior
> dependent on the value of org-src-window-setup?
>
> Basically, when org-src-window-setup is current-window, it never makes
> sense to restore the original layout. But when org-src-window-setup is
> reorganize-frame (the default), it always makes sense to restore the
> original layout.
>
> I'm not sure what the "correct" behavior would be for the other options
> however.

I think any value that modifies the current layout ought to restore it:
- `split-window-below'
- `split-window-right'
- `reorganize-frame'

OTOH, values that use the current layout should not restore it
afterwards:
- `current-window'
- `other-window'
- `other-frame'

This should be mentioned in the docstring.

WDYT?

Regards,

-- 
Nicolas Goaziou

Re: Fix time regexp in org-get-entries-from-diary

[Nicolas Goaziou]

Hello,

Thomas Fitzsimmons  writes:

> I filed a bug report in Emacs debbugs, but probably should have sent it
> here instead:
>
>http://debbugs.gnu.org/cgi/bugreport.cgi?bug=38599
>
> The attached patch appears to fix the bug.  Does it look OK?

Applied. Thank you.

I added your name to the list of contributors who haven't signed FSF
papers. Please let me know if you did so I can update your status.

Regards,

-- 
Nicolas Goaziou

Small change to link syntax in maint

[Nicolas Goaziou]

Hello,

Matt Price reported an issue[1] with new link syntax in Org 9.3. As
a consequence, I had to modify it slightly.

Backslash-escaping was required for some closing bracket characters.
Now, /every square bracket/ within the URI part of a bracket link must
be escaped.

I updated the manual and the ORG-NEWS file accordingly. Please let me
know if there's something suspicious.

Sorry for the inconvenience.

Regards,

Footnotes: 
[1]  

-- 
Nicolas Goaziou

Re: managing aggressive link activation within lines?

[Nicolas Goaziou]

Nicolas Goaziou  writes:

> IMO, it would be more productive to think about what can be done in your
> situation instead. For example, one solution could be to require "[[" to
> be escaped in a link (current syntax already requires closing brackets
> to be escaped in some situations). I'm not yet sure how to deal with it,
> tho.

I updated the link syntax in maint, so it now requires to escape every
square bracket in the URI part of a link. This should fix this issue.
Please test it and let me know if there's anything suspicious.

Thank you.

Re: [PATCH] ox-odt.el: (org-odt-template): Get write permissions on styles.xml

[Nicolas Goaziou]

Hello,

another...@gmail.com (Nicolò Balzarotti) writes:

> I attached a patch that is required to get ox-odt to work on
> guix/nix/other distributions where package files are placed in a
> read-only directory.  After the file styles.xml is copied to /tmp, now
> we set read-write permissions to it before trying to write it.  Before
> this patch, we got the error:
>
>   'OpenDocument export failed: Buffer is read-only: #'.
>
> It's my first patch and is just 1 line long, so following instructions
> on https://orgmode.org/worg/org-contribute.html#commit-messages I added
> the TINYCHANGE cookie.  Tests (make test) are passing.

Applied. Thank you!

Regards,

-- 
Nicolas Goaziou

Re: the latest commit broke the inline image preview

[Nicolas Goaziou]

Hello,

stardiviner  writes:

> After EMC testing, the latest commit " 04d2828ad org: Fix verbatim block
> fontification to end blocks on headlines " break the inline image
> preview

Thank you for the report. However, I think more information may be
useful, since « break the inline image preview » is rather vague. 

In any case, I'm Cc'ing Tom Gillespie as he may know what is happening.

> If possible, I think Org Mode should add test for inline image.

Patches welcome :)

Regards,

-- 
Nicolas Goaziou