Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-04-29 Thread Jim Porter
On 4/29/2024 11:14 AM, Ihor Radchenko wrote: Thanks! I have a small comment on the docstring of `forward-thing-provider-alist' - it refers to `thing-at-point-provider-alist', but the provides here are called with an argument N, unlike the providers in `thing-at-point-provider-alist'. Fixed.

Re: link can not be created in a line with another link.

2024-04-29 Thread Alexandros Prekates
On Mon, 29 Apr 2024 13:19:15 + Ihor Radchenko wrote: > For you workflow, it may be more convenient to set > `org-link-descriptive' to nil. Then, Org mode will not hide the path > part of the links and you can edit the plain text as you wish without > being distracted by Org mode trying to

Re: [PATCH] Run latex more than once for LaTeX src block evaluation

2024-04-29 Thread Ihor Radchenko
Michael writes: >> ... >> So, it makes sense for `org-babel-execute:latex' to override >> `org-preview-latex-default-process' temporarily, to something >> actually >> generating .png file. > > Sorry-- got sidetracked by something else. I see what you > mean. OK, so the proposal is: change the

Re: [ANN] lisp/ob-tangle-sync.el

2024-04-29 Thread Mehmet Tekman
Hello! João Pedro writes: > I'd like to ask if I could contribute to this. I have followed the > discussion to a point, but would be more than happy to try and > contribute to this so it gets merged for the next Org major version, That's the plan, and I'll happily take any help I can get. >

Re: [BUG] ob-shell: internal representation of cmdline arguments the same

2024-04-29 Thread Ihor Radchenko
Matt writes: > #+begin_src bash :cmdline 1 2 3 > ... > #+begin_src bash :cmdline "1 2 3" > ... > It was stated that, > > #+begin_quote > AFAICT, it's due to how headers are parsed by > 'org-babel-parse-header-arguments' using 'org-babel-read'. The cell "\"1 2 > 3\"" (corresponding to :cmdline

Re: [DISCUSSION] The meaning of :cmdline header argument across babel backends

2024-04-29 Thread Ihor Radchenko
Max Nikulin writes: > It is documented as > " :cmdline ... [arg_n] > > Use the :cmdline header arg to pass arguments to a shell command." > > However current implementation allows code injection through args, > including a trivial one > > #+header-arg: :results verbatim > #+begin_src sh

Re: link can not be created in a line with another link.

2024-04-29 Thread Alexandros Prekates
On Sun, 28 Apr 2024 12:40:44 + Ihor Radchenko wrote: > Alexandros Prekates writes: > > > In the example below i underline to show that a link has been > > created. > > > > Given that lines : > > > > [[sysadmInstallSoftware a [[deb][deb package]] > > [[sysadmInstallSoftware adeb

Re: [PATCH] updating org-plot.org on worg, was Re: Can we add PLOT to org-element-multiple-keywords?

2024-04-29 Thread Ihor Radchenko
Leo Butler writes: > From 4e262898feb349dad2f5b5afe8960c8e09723862 Mon Sep 17 00:00:00 2001 > From: Leo Butler > Date: Wed, 24 Apr 2024 12:57:58 -0500 > Subject: [PATCH] org-tutorials/org-plot.org: update documentation and examples Thanks! Applied, with minor amendments (I fixed Org repository

Re: [PATCH] org-ctags.el: Protect shell specials in directory name

2024-04-29 Thread Max Nikulin
On 29/04/2024 00:02, Ihor Radchenko wrote: Max Nikulin writes: Tests must be fully automated. We use make test in CI and things like project-compile are non-interactive. I do not mind. Requiring unexpected user interactions is a feature of org-ctags. So, may you update the patch to make

Re: [BUG] ob-shell: results missing leading quotes

2024-04-29 Thread Ihor Radchenko
Matt writes: > #+begin_src bash > echo \"\"1\"\" > #+end_src > > #+RESULTS: > : 1"" Fixed, partially, on main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=89c68683f The problem was auto-detection of table data - the algorithm used CSV parser as a fallback and ""1"" is a

Re: [PATCH] org-ctags.el: Protect shell specials in directory name

2024-04-29 Thread Ihor Radchenko
Max Nikulin writes: >> So, may you update the patch to make tests automated? > > Notice that new tests for org-ctags do not require user interactions. Try > > make test BTEST_RE=test-org-ctags/ Sure, but that does not change the fact that make test is broken after applying your patch. Of

Re: link can not be created in a line with another link.

2024-04-29 Thread Ihor Radchenko
Alexandros Prekates writes: > The same behavior happens with emacs -Q. > > Having <> and <> anchors somewhere in an org file > in a line a have an internal link : > > bla [[foo]] > > If i add : > [[boo]] bla [[foo]] > org will create the two links. > > But if i add: > [[boo][ bla [[foo]] >

Re: [BUG] oddity tangling src_blk with :var [9.7-pre (release_9.6.26-1368-g1ae978 @ /home/minshall/.emacs.d/straight/build/org/)]

2024-04-29 Thread Ihor Radchenko
Greg Minshall writes: >> This is because Org mode currently cannot distinguish between babel >> backends that simply do not support variable assignments and babel >> backends that are not loaded. > > currently, is it possible to see well enough what is going on to > generate an error and abort

Re: [PATCH] org-make-tags-matcher: Compile returned function

2024-04-29 Thread Ihor Radchenko
Morgan Smith writes: > This should result in a nice performance boost when the function is > called repeatedly (as is often done). > > * lisp/org.el (org-make-tags-matcher): Evaluate returned function to > compile it into a closure. > ... > I don't have any rigorous benchmarks but this does make

[PATCH] org-ctags.el: Do not activate on load

2024-04-29 Thread Max Nikulin
On 29/04/2024 20:12, Ihor Radchenko wrote: Max Nikulin writes: Notice that new tests for org-ctags do not require user interactions. [...] Of course, the cause is the known side effect of loading org-ctags. Maybe we can disable the tests until that bug is fixed. Or, ideally, load org-ctags

Re: [ANN] lisp/ob-tangle-sync.el

2024-04-29 Thread João Pedro
Em segunda, 29/04/2024 às 09:43 (+02), Mehmet Tekman escreveu: > The development is happening chaotically on my own repo > (gitlab.com/mtekman/org-mode) across several incomplete branches. > > I've actually been working on it on and off for the last two weeks, but > I've been facing some

Re: [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get'

2024-04-29 Thread Ihor Radchenko
Morgan Smith writes: > * lisp/org.el (org-cached-entry-get): Rewrite in terms > `org-entry-get'. Obsolete in favor of `org-entry-get'. > (org-make-tags-matcher): Replace uses of `org-cached-entry-get' with > `org-entry-get'. > --- > Hello! > > All tests pass. > > All of the logic here already

Re: Possible to set block switches "globally"?

2024-04-29 Thread Ihor Radchenko
João Pedro writes: > Is there a way to set =src= and =example= switches (as documented in > "(org) Literal Examples"[0]) file- or heading-wide? There is currently no way to do it. > Ideally, I would be able to set those as a file properties like that, or > per heading under the =:PROPERTIES:=

RE: help: org-mode menu presence mysteriously disappearing and reappearing when I navigate the document

2024-04-29 Thread Ihor Radchenko
"Cook, Malcolm" writes: > Indeed, I am delighted when polymode works in this fashion, as designed. > However, I am finding that the menu is changing when I navigate between org > headers, such as below when I hit a single down arrow to advance from "** > DONE publish help.md markdown as

Re: [PATCH] ob-lua: Support all types and multiple values in results

2024-04-29 Thread Rudolf Adamkovič
Ihor Radchenko writes: >> We need *better tests*, otherwise all this is kind of useless. >> >> I will hack on this some more... > > Will you be willing to provide some? Definitely! I am on it. Rudy -- "Genius is 1% inspiration and 99% perspiration." --- Thomas Alva Edison, 1932 Rudolf

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

2024-04-29 Thread Ihor Radchenko
Björn Bidar writes: > On another related note are `org-add-note` also follow the same pattern as > e.g. `org-src`? Maybe it should have something like `org-note-window-setup` > similar to `org-src-window-setup`? Now, it should respect display-buffer-alist. -- Ihor Radchenko // yantar92, Org

Re: Adding custom providers for thingatpt.el (was: [PATCH] Add support for 'thing-at-point' to get URL at point)

2024-04-29 Thread Ihor Radchenko
Jim Porter writes: > Ihor, Eli: What do you think of the attached patch? I added variables to > let modes define custom providers for 'bounds-of-thing-at-point' and > 'forward-thing'. (Notably, I avoided adding vars for the > 'beginning-of-thing' and 'end-of-thing' functions, since those just

Re: [PATCH] lisp/org.el: Obsolete `org-cached-entry-get' in favor of `org-entry-get'

2024-04-29 Thread Morgan Smith
Ihor Radchenko writes: > > > This function should yield speedups when matching special properties > like "CLOCKSUM", "CLOCKSUM_T", "TIMESTAMP", or "TIMESTAMP_IA". > > For example, when the requested match tests these properties multiple > times. > > We need a real-life justification, not a

Re: [BUG] Org-Agenda leaves frame around [9.7-pre (release_9.6.8-785-g72bbf8.dirty @ /home/bidar/.local/private/etc/emacs/lib/org/lisp/)]

2024-04-29 Thread Björn Bidar
Ihor Radchenko writes: > Björn Bidar writes: > E.g.: 1. I capture a link using org-protocol 2. Switch to the org-buffer 3. C-c C-l 4. RET <- frame closes however links isn't inserted into the target org-buffer >>> >>> May you provide more details about how to

Re: [PATCH] ob-lua: Support all types and multiple values in results

2024-04-29 Thread Rudolf Adamkovič
Rudolf Adamkovič writes: > Definitely! I am on it. All right, how about the attached patch? Rudy >From 40270bc62f951cfd20916c17e2dfc52863d6b8e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?= Date: Mon, 29 Apr 2024 21:42:04 +0200 Subject: [PATCH] ob-lua: Quote list-like