consciously use that code path and I'm not sure what it
supposed to do).
Cheers,
Jan
Jan Malakhovski (4):
org-clock: make org-clock-time% respect org-effort-durations
org: move org-duration-string-to-minutes to a better place
rename org-duration-string-to-minutes to org-clocksum-string
---
contrib/lisp/org-depend.el | 2 +-
contrib/lisp/ox-taskjuggler.el | 2 +-
lisp/org-agenda.el | 2 +-
lisp/org-clock.el | 14 +++---
lisp/org-colview.el| 2 +-
lisp/org.el| 14 +-
6 files changed, 20
---
contrib/lisp/org-notmuch.el | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/contrib/lisp/org-notmuch.el b/contrib/lisp/org-notmuch.el
index 712ec5a..265742e 100644
--- a/contrib/lisp/org-notmuch.el
+++ b/contrib/lisp/org-notmuch.el
@@ -71,15 +71,16 @@ Should accept
---
contrib/lisp/org-mew.el | 11 +--
contrib/lisp/org-vm.el | 11 +--
contrib/lisp/org-wl.el | 10 +-
doc/org.texi| 4 ++--
lisp/org-gnus.el| 15 +--
lisp/org-mhe.el | 10 +-
lisp/org-rmail.el | 11 +--
Cheers,
Jan
Jan Malakhovski (2):
factor out date-timestamp* calculations to org-store-link-props
org-notmuch: add date support to org-notmuch-store-link
contrib/lisp/org-mew.el | 11 +--
contrib/lisp/org-notmuch.el | 7 ---
contrib/lisp/org-vm.el | 11
---
lisp/org-colview.el | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index 1113adc..4f09766 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -1113,6 +1113,9 @@ display, or in the #+COLUMNS line of the current buffer."
((memq
---
lisp/org.el | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 088913c..453ed37 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18329,6 +18329,26 @@ If no number is found, the return value is 0."
This also fixes a bug with time percents looking pretty much random and adding
to a number that is less than 100% when a clock report has long intervals
(e.g. days).
---
lisp/org-clock.el | 29 +++--
1 file changed, 11 insertions(+), 18 deletions(-)
diff --git
Matt Lundin <m...@imapmail.org> writes:
> Jan Malakhovski <o...@oxij.org> writes:
>
>> I'm pretty sure that there are other org-mode users that are weeping
>> silently since that change. Suppose you have more than a screen of clock
>> lines in LOGBOOK under
Hi.
Emacs : GNU Emacs 24.5.2 (x86_64-unknown-linux-gnu, GTK+ Version
2.24.28) of 2015-10-05 on localhost
Current package: Org-mode version 8.3.2 (release_8.3.2-209-gba4d33 @
/home/oxij/repo/org-mode/lisp/) (actually, both master and maint)
Previous package: Org-mode version 8.2.10
Nicolas Goaziou writes:
>> * Pressing on an entry in org-agenda-list moves the cursor to the
>> corresponding node.
>>
>> Previously it moved the cursor to the corresponding CLOCK: line and I
>> used that a lot.
>
> According to `org-agenda-goto''s docstring, this
Nicolas Goaziou writes:
> Could you provide an ECM with appropriate CLOCK lines?
Attached.
* Other files:
** init.el:
#+BEGIN_SRC emacs-lisp
(add-to-list 'load-path "~/repo/org-mode/lisp")
(add-to-list 'load-path "~/repo/org-mode/contrib/lisp")
(require 'org)
(setq
Jan Malakhovski <o...@oxij.org> writes:
> Nicolas Goaziou <m...@nicolasgoaziou.fr> writes:
>
>> Could you provide an ECM with appropriate CLOCK lines?
>
> Attached.
Okay, so I bisected and found that the offender is
9f5e698679aecbed872a2030e4157e5e2b1d87e0. Since
Aaron Ecay writes:
> This could be converted to dolist while you’re here (I realize you
> didn’t touch this line).
Ok.
>> - (if (string-match "\\([0-9]+\\):\\([0-9]+\\)" s)
>> - (throw 'exit
>> - (/ (* 100.0 (+ (string-to-number (match-string
Aaron Ecay writes:
> You can use ‘define-obsolete-function-alias’.
Ok.
Aaron Ecay writes:
> Checking the source, date-to-time can raise an error (invalid date).
> format-time-string is a C function, so it’s less easy for me to
> understand. But it looks like if it raises any errors, these are bugs
> that we want to know about and not suppress.
* contrib/lisp/org-notmuch.el (org-notmuch-store-link): Add date support.
* doc/org.texi: Fix `org-capture-templates' documentation.
---
contrib/lisp/org-notmuch.el | 7 ---
doc/org.texi| 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git
* lisp/ob-calc.el (org-babel-calc-eval):
(org-babel-calc-set-env):
(org-babel-calc-reset-env):
(org-babel-calc-store-env):
(org-babel-calc-eval-string):
(org-babel-calc-eval-line): New funcion.
(org-babel-execute:calc): Rewrite to use new functions.
This also makes ob-calc useful for computing
* lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after
expression
evaluation.
---
lisp/ob-calc.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/ob-calc.el b/lisp/ob-calc.el
index e8b43e7..2656f27 100644
--- a/lisp/ob-calc.el
+++ b/lisp/ob-calc.el
TINYCHANGE
---
lisp/org-clock.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 09f8391..ad423f1 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -2774,7 +2774,7 @@ following structure:
(LEVEL HEADLINE TIMESTAMP TIME)
* lisp/org-agenda.el:
* lisp/org-clock.el:
* lisp/org-colview.el:
* lisp/org.el:
* contrib/lisp/org-depend.el:
* contrib/lisp/ox-taskjuggler.el: Rename (org-duration-string-to-minutes)
to (org-clocksum-string-to-minutes).
---
contrib/lisp/org-depend.el | 2 +-
TINYCHANGE
---
lisp/org-colview.el | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lisp/org-colview.el b/lisp/org-colview.el
index b698801..d27abc3 100644
--- a/lisp/org-colview.el
+++ b/lisp/org-colview.el
@@ -1113,6 +1113,9 @@ display, or in the #+COLUMNS line of the current buffer."
* lisp/org-clock.el (org-clock-time%): Respect org-effort-durations.
This also fixes a bug with time percents looking pretty much random and adding
to a number that is less than 100% when a clock report has long intervals
(e.g. days).
---
lisp/org-clock.el | 29 +++--
1
.
The first two are TINYCHANGE.
Cheers,
Jan
Jan Malakhovski (9):
org-clock: fix a typo
org-colview: add a FIXME
org-clock: fix `org-clock-time%'
org: move `org-duration-string-to-minutes' to a better place
rename `org-duration-string-to-minutes' to
`org-clocksum-string-to-minutes
---
lisp/org.el | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 6218a3a..a0fe644 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18328,6 +18328,26 @@ If no number is found, the return value is 0."
* lisp/org.el (org-store-link-props): Rewrite function to get date-timestamp*
calculations.
* lisp/org-gnus.el:
* lisp/org-mhe.el:
* lisp/org-rmail.el:
* contrib/lisp/org-mew.el:
* contrib/lisp/org-vm.el:
* contrib/lisp/org-wl.el: Remove date-timestamp* copy-paste.
* doc/org.texi: Fix
Aaron Ecay writes:
> Are you missing a close paren at the end of the above line?
It evaluates and works ok, so I think it's ok.
> Also, shouldn’t calc-eval take a string as an argument, not a lisp
> form? (I’m asking based on the docstring, I don’t know the calc API at
>
Aaron Ecay writes:
> Can you introduce a let binding so that (date-to-time x) is only called
> once?
Ok.
> Also, what is ignore-errors protecting? The call to date-to-time, or
> format-time-string? I think the scope of ignore-errors should be as
> narrow as it can be.
I
Hi.
Aaron Ecay writes:
> Thanks for the patches! They look good to me. I sent a few minor
> comments about code style. I didn’t review the 8th patch (ob-calc: add
> more API, documentation and examples so that it can be used in tables)
> because I didn’t feel familiar
Aaron Ecay writes:
> Ok. Then:
> 1. The indentation is wrong, because (calc-pop 1) is the second argument
>to calc-eval.
> 2. The prog1 form is not needed, because it only wraps a single form
>(the calc-eval call).
>
> This looks wrong to me, so please double-check.
* contrib/lisp/org-notmuch.el (org-notmuch-store-link): Add date support.
* doc/org.texi: Fix `org-capture-templates' documentation.
---
contrib/lisp/org-notmuch.el | 7 ---
doc/org.texi| 2 +-
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git
* lisp/org.el (org-store-link-props): Rewrite function to get date-timestamp*
calculations.
* lisp/org-gnus.el:
* lisp/org-mhe.el:
* lisp/org-rmail.el:
* contrib/lisp/org-mew.el:
* contrib/lisp/org-vm.el:
* contrib/lisp/org-wl.el: Remove date-timestamp* copy-paste.
* doc/org.texi: Fix
This is a date-timestamp* piece of "[PATCH v2 0/9] mail, clock and
calc changes" updated with Aaron Ecay's suggestions.
Jan Malakhovski (2):
factor out date-timestamp* calculations to org-store-link-props
org-notmuch: add date support to org-notmuch-store-link
contrib/lisp/
Hello.
This is a fixes-only piece of "[PATCH v2 0/9] mail, clock and calc
changes" updated with Aaron Ecay's suggestions.
Other pieces will follow shortly.
I'm pretty sure FSF processed my copyright assignment.
Cheers,
Jan
Jan Malakhovski (3):
org-clock: fix a typo
ob-calc: d
* contrib/lisp/org-contacts.el (org-contacts-matcher): Fix expression to work
for BIRTHDAY-only contacts.
---
contrib/lisp/org-contacts.el | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/contrib/lisp/org-contacts.el b/contrib/lisp/org-contacts.el
index
TINYCHANGE
---
lisp/org-clock.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index eb7d9c3..823a386 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -2762,7 +2762,7 @@ following structure:
\(LEVEL HEADLINE TIMESTAMP TIME)
* lisp/ob-calc.el (org-babel-calc-eval-string): Clean up the stack after
expression
evaluation.
---
lisp/ob-calc.el | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lisp/ob-calc.el b/lisp/ob-calc.el
index a8c50da..99d0a09 100644
--- a/lisp/ob-calc.el
+++ b/lisp/ob-calc.el
* lisp/org.el (org-time-clocksum-use-effort-durations): Make obsolete.
(org-effort-durations-default):
(org-effort-durations-8h):
(org-effort-durations-6h): New constants.
(org-effort-durations): Redefine and document.
(org-minutes-to-clocksum-string): Simplify.
* lisp/org-agenda.el:
* lisp/org-clock.el (org-clock-time%): Rewrite using
(org-clocksum-string-to-minutes), document pitfalls.
(org-clock-time%-with-effort): New function.
(org-clocktable-write-default): Fix effort-duration parameter.
* doc/org.texi (The clock table): Update documentation.
---
doc/org.texi | 6
* lisp/org-agenda.el:
* lisp/org-clock.el:
* lisp/org-colview.el:
* lisp/org.el:
* contrib/lisp/org-depend.el:
* contrib/lisp/ox-taskjuggler.el: Rename (org-duration-string-to-minutes)
to (org-clocksum-string-to-minutes).
---
contrib/lisp/org-depend.el | 2 +-
th ob-calc piece
of "[PATCH v2 0/9] mail, clock and calc changes", I'll send it when
its better.
Cheers,
Jan
Jan Malakhovski (4):
org: move `org-duration-string-to-minutes' to a better place
rename `org-duration-string-to-minutes' to
`org-clocksum-string-to-minutes' e
---
lisp/org.el | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index 74d1c4c..f6c513e 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -18303,6 +18303,26 @@ If no number is found, the return value is 0."
42 matches
Mail list logo