Hi Ihor
On August 23, 2023 12:44:32 PM GMT+01:00, Ihor Radchenko
wrote:
>Ihor Radchenko writes:
>
>> What about generalizing the idea and providing a way to set Emacs
>> buffer-local variables in the tangled files?
>>
>> Can be something like:
>>
>> #+begin_src elisp :file-locals
Ihor Radchenko writes:
> Evgenii Klimov writes:
>
>> I see in the comment there the reason for that, but still would prefer
>> to use unique IDs in tangled files: the probability to overwrite wrong
>> source block under nonunique header overweights a side-effect of
&
Hi, I noticed that links created during tangling back to the original
Org file doesn't respect custom =org-id-link-to-org-use-id= option in
~org-babel-tangle--unbracketed-link~.
I see in the comment there the reason for that, but still would prefer
to use unique IDs in tangled files: the
ollect-blocks
>
> When reading this code, I have no idea what it is trying to test.
> Probably something to do with function names not being descriptive.
> At least, a comment would help.
>
> And the magic numbers "4" and "5" have no obvious meaning.
Hope
t; to reach out to another file in order to understand what the test is
> about.
Now it's less verbose, handles both cases
(with and without TARGET-FILE) and prints detailed ert explanation.
> Evgenii Klimov writes:
[...]
>> It wasn't clear for me: will ":tangle yes" or
be rewritten as they look too complex
and mostly duplicate each other. I'd appreciate your suggestions
on how to enhance them.
Ihor Radchenko writes:
> Evgenii Klimov writes:
>
>> In this version I just updated the docstrings for the relevant
>> functions, because prior to that it
Ihor Radchenko writes:
> Bastien Guerry writes:
>
Copyright assignment is complete.
>>>
>>> Bastien, may you confirm?
>>
>> Yes I do! Thanks for the heads up.
>
> Thanks!
> Recorded.
> https://git.sr.ht/~bzg/worg/commit/daaa35a9
Thanks, what about the patch itself?
Ihor Radchenko writes:
> Evgenii Klimov writes:
>
>> Test ~ob-tangle/detangle-false-positive~ asks for confirmation to kill
>> the buffer, connected to testing/examples/babel.org file, that is
>> modified during the couse of the test.
>>
>> Way to repro
Hi
Vlastimil Vondra writes:
> Perfect, org-reveal is working as well, haven't known about that! But it
> would be good that org-reveal is called automatically before org-cycle,
> because when
> going through the task list, I'm just expanding by tab. It is not really
> convenient to use tab
Ihor Radchenko writes:
> Evgenii Klimov writes:
>
>> Test ~ob-tangle/detangle-false-positive~ asks for confirmation to kill
>> the buffer, connected to testing/examples/babel.org file, that is
>> modified during the couse of the test.
>>
>> Way to repro
isp . t) (shell . t) (org . t" \
--eval '(ert "ob-tangle/detangle-false-positive")'
#+END_SRC
>From 5905e37a581d4cf2a4a517593c91730d836b6471 Mon Sep 17 00:00:00 2001
From: Evgenii Klimov
Date: Sun, 16 Jul 2023 13:14:38 +0100
Subject: [PATCH] testing/lisp/test-ob-tan
>From ed39640d75df231c8826191f2576fcfd6a5aa723 Mon Sep 17 00:00:00 2001
From: Evgenii Klimov
Date: Sat, 15 Jul 2023 00:34:58 +0100
Subject: [PATCH] org-contrib/babel/languages/index.org: Fix broken link
---
org-contrib/babel/languages/index.org | 2 +-
1 file changed, 1 insertion(+), 1 delet
No Wayman writes:
[...]
> I, and others, have been surprised to find that the tangled file does
> not have lexical binding enabled when :lexical blocks are tangled.
Am I correct that language-specific header arguments are not yet covered
in the manual? I can't find any reference of "lexical"
which default value to choose? Currently if you tangle it would be
dynamic, but lexical binding is the future.
After all I'll add tests and update Changelog/Docs if needed.
>From 3ad56137cb709182dc1bc242cd80a1474078cb95 Mon Sep 17 00:00:00 2001
From: Evgenii Klimov
Date: Thu, 13 Jul 2023
p 17 00:00:00 2001
From: Evgenii Klimov
Date: Wed, 12 Jul 2023 19:24:48 +0100
Subject: [PATCH v2] ob-tangle.el: Avoid relative file names when grouping
blocks to tangle
* lisp/ob-tangle.el (org-babel-effective-tangled-filename): Avoid
using relative file names that could cause one block to overwrite t
And here's the patch to fix it.
>From 2695d48f265a4100a9fc25c4dd278ab2b4b89ba5 Mon Sep 17 00:00:00 2001
From: Evgenii Klimov
Date: Wed, 12 Jul 2023 19:24:48 +0100
Subject: [PATCH] ob-tangle.el: Avoid relative file names when grouping blocks
to tangle
* lisp/ob-tangle.el (org-babel-effect
Hi, I noticed that during grouping of blocks to tangle some of them can
overwrite each other if they have the same target file, but in different
format (relative vs absolute).
Consider this example (part of example.org file in the attachment):
* 1st explicit :tangle yes
#+begin_src
Ihor Radchenko writes:
> It looks like 5 working days have passed since your email to FSF. If so,
> please follow up once and wait another 5 working days.
I've got papers from FSF, signed it and sent it back. It was 6 working
days ago. 5 days that you mention is for the first response from
\[\^-\] \{\} +
But there are =org-log-states-order-reversed=, but it doesn't seem to
be relevant.
PS: I didn't add TINYCHANGE since I have reached the contribution
limit but FSF didn't respond yet.
>From a3e50c5799acb216ccb2c1ae6883d73ac36e4291 Mon Sep 17 00:00:00 2001
From: Evgenii Klimov
Date: Mon, 10 Jul 2023 23:00
Ihor Radchenko writes:
[...]
>
> Thanks!
> Applied, onto main.
Thanks, it's a great pleasure!
> Note that you have reached the contribution limit allowed without FSF
> copyright assignment. If you want to contribute further, please consider
> signing copyright paperwork. See
>
Ihor Radchenko writes:
> Evgenii Klimov writes:
[...]
> Few comments.
>
> First, please add Changelog entry for etc/ORG-NEWS.
Done.
>> +(defvar org-metaleft-final-hook nil
>> + "Hook for functions attaching themselves to `M-left'.
>> +See `org-ctrl-
Ihor Radchenko writes:
> Evgenii Klimov writes:
>
[...]
>> -(when (funcall (if (equal complete-file '(64)) 'not 'identity)
>> - (not org-link-keep-stored-after-insertion))
>> - (setq org-stored-links (delq (ass
Ihor Radchenko writes:
[...]
>> +individual commands for more information.
>> +
>> +This function runs the hook `org-shiftmetaleft-hook' as a first
>> +step, `org-shiftmetaleft-final-hook' as the penultimate step, and
>> +returns at first non-nil value."
>
> Upon looking closer, I realized
Ihor Radchenko writes:
> Max Nikulin writes:
[...]
>> I had it in mind when I was writing my message. I had even tried to find
>> another command that allows to remove stored links.
>
> If necessary, removing stored links without inserting can be made as an
> effect of negative prefix
Ihor Radchenko writes:
> Evgenii Klimov writes:
>> ...
>
> This makes sense, but the patch may break removing stored link in
> certain scenarios.
Thanks for response, I'll look into this issue and try to avoid this
breakage.
* lisp/org.el (org-metaleft-final-hook, org-metaright-final-hook,
org-metaup-final-hook, org-metadown-final-hook): Define final hooks
for S-cursor commands.
(org-metaleft, org-metaright, org-metaup, org-metadown): Add final
hooks to M-commands and document them in the docstring.
* lisp/org.el
On July 1, 2023 11:40:07 AM GMT+01:00, Ihor Radchenko
wrote:
>Thanks for the patch!
>May you please squash it into one
>
Don't you mind if I also add the final hook to `org-meta-return'? I
didn't do it right away because it requires a little bit of refactoring:
everything after the initial
* lisp/ol.el (org-insert-link): Keep the link in `org-stored-links' if
the command was interrupted by the user during the reading of a
description from the minibuffer.
---
Currently the link is lost if the user chooses the link but cancells
the comand while writing the description.
lisp/ol.el |
* lisp/org.el (org-shiftup, org-shiftdown, org-shiftright,
org-shiftleft): Document hooks for S-cursor commands in the docstring.
---
lisp/org.el | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/lisp/org.el b/lisp/org.el
index b396456a2..bf61062b1
`org-shiftup' and other S-cursor commands not only provide initial
hooks but also final hooks, while M-cursor and S-M-cursor commands
lack them. These patches add final hooks to all of these commands and
document both hooks in the docstring if they are not already present.
* lisp/org.el (org-shiftmetaleft-final-hook,
org-shiftmetaright-final-hook, org-shiftmetaup-final-hook,
org-shiftmetadown-final-hook): Define final hooks for the S-M-cursor
commands.
(org-shiftmetaleft, org-shiftmetaright, org-shiftmetaup,
org-shiftmetadown): Add final hooks to the S-M-cursor
* lisp/org.el (org-metaleft-final-hook, org-metaright-final-hook,
org-metaup-final-hook, org-metadown-final-hook): Define final hooks
for S-cursor commands.
(org-metaleft, org-metaright, org-metaup, org-metadown): Add final
hooks to M-commands and document them in the docstring.
---
lisp/org.el |
32 matches
Mail list logo
