Re: Hiding results using :post

2021-06-07 Thread Nick Savage
My initial thoughts are that this is very possible. This might be an area where we could add a new defcustom on always hiding the results to allow the user to choose it. Without looking at the code, I think it would be pretty straight forward to make an excursion to the results line, toggle

Re: import xls(x) into org on MacOS

2021-06-01 Thread Nick Savage
If you're looking to go the python route of importing an xls file, you could try the xlrd package. It's actually just for xls. I'm not sure if it converts to csv, but once you have the spreadsheet open in python that should be a pretty trivial exercise. Cheers, Nick On 5/31/21 7:18 AM, Uwe

Re: URLs with brackets not recognised

2021-05-12 Thread Nick Savage
I can confirm this as a bug. On 5/12/21 3:32 AM, Colin Baxter wrote: Hello, If a URL link in an org file contains a bracket then the link is not fully recognised and may be misdirected. For example, 1. emacs -Q 2. C-x C-f test.org 3. Insert the URL

Re: [bug] C-u org-update-statitics-cookies errors out with "Non-existent agenda file" if current file isn't saved

2021-05-11 Thread Nick Savage
Thanks for the bug report, I can confirm this is happening. I encountered a similar bug where org-agenda-prepare-buffers was causing the same issue when the file hadn't been saved to disk, and I agree that the solution looks good. I've formatted this into a patch and attached it. Might be

Re: bug#47088: org-w3m: handle w3m-image link information

2021-05-06 Thread Nick Savage
I haven't opened up the code yet to take a look, but I likely will take a crack at some of these items in the future as low-hanging fruit refactoring project. On 5/6/21 6:05 PM, Boruch Baum wrote: (org-w3m-get-image-end): New function, for w3m-img links. 3] As mentioned in the patch,

Re: babel output seems to drop anything before % (in session)

2021-05-06 Thread Nick Savage
So I have a patch written that doesn't completely fix the problem, but maybe makes enough progress that someone else can figure it out. The issue is that comint-prompt-regexp is reading the "% " as a prompt, and taking everyone off before it. I've added another parameter to

[PATCH] Fix truncated output in ob-sqlite.el (Was: Bug: sqlite output truncated?)

2021-05-04 Thread Nick Savage
I've attached a patch to address this. The issue is that ob-sqlite.el uses org-babel-string-read, which purposefully removes double-quotes. I think this is unintended behaviour, and it only seems to be used with ob-sqlite.el. I added a minor function to bypass the part of

Re: Bug: sqlite output truncated?

2021-05-03 Thread Nick Savage
I can replicate this, it looks like a bug to me. Looks to me that there's something wrong with the way it is handling single quoted strings, since the output is only what is within the double quoted strings. I will take a stab at fixing this. On 5/3/21 6:22 PM, learn orchids wrote: I am

[PATCH] Replace call in org-columns of org-map-entries with org-scan-tags

2021-05-03 Thread Nick Savage
Hello all, I was trying to track down the source of a bug encountered when I was submitting my last patch about org-columns. I'm going to walk you through my thought process and summarize at the end. As part of my experimenting, I did the following: 1. emacs -Q 2. open a new buffer at

[PATCH]: org-columns does not respect global-visual-line-mode for long text within headlines

2021-05-02 Thread Nick Savage
I've done some more research on https://orgmode.org/list/875z02si3g@nicolasgoaziou.fr/, and I believe the issue is that `org-columns' is setting `truncate-lines' as t, while `global-visual-line-mode' is expecting it to be set to nil. The interaction between the two causes the wrapping to

Bug: org-columns does not respect global-visual-line-mode for long text within headlines

2021-04-30 Thread Nick Savage
Hello everyone, I'm filing a bug in relation to org-columns and its interactions with global-visual-line-mode, which I do not think is expected behaviour. 1. Start `emacs -Q' 2. Create /tmp/test.org (or something like this) 3. Enable M-x global-visual-line-mode 4. Insert the following (or

[PATCH] ob-eval.el: Refactoring `org-babel-eval' to improve readability

2021-04-29 Thread Nick Savage
Hello everyone, I have attached a patch to refactor `org-babel-eval' and `org-babel--shell-command-on-region' to improve readability and to make local variables more consistent between functions. This also removes two parameters from `org-babel--shell-command-on-region', START and END. The

Re: Concerns about community contributor support

2021-04-25 Thread Nick Savage
As a new contributor, I wanted to add my two cents. I've submitted a minor amount of patches (somewhere between 1 and 3, I can't remember exactly), and I feel that the other problems you raise, primarily the first one, are obstacles towards that though. Patches like that are obviously minor,

Re: Backwards compatability

2021-04-25 Thread Nick Savage
On org-drill, I think someone has already taken it up here a while ago: https://gitlab.com/phillord/org-drill On 4/25/21 12:39 AM, Bastien wrote: Hi Bithov, we *do* care a lot about backward compatibility*. We cannot make a strong commitment for contributed libraries and external ones,

[PATCH] Improve code readability in org-set-font-lock-defaults

2021-03-14 Thread Nick Savage
I'm not sure what the appetite is for small changes like this, but I have attached a small patch to improve readability in org-set-font-lock-defaults. I was trying to understand how org-emphasize worked and came across some code that I thought could be simplified. If small refactoring patches

Re: Bug: Entries with 0 minutes logged triggers clocking overlap [9.5 (nil @ /home/eddie/.emacs.d/.local/straight/build-26.3/org-mode/)]

2021-03-07 Thread Nick Savage
Hi Eddie, Are you culling the 0 minute entries because they are not useful for you and throw errors, or do you wish they could be included as part of your workflow but they don't work properly? Thanks, Nick On 3/5/21 8:48 PM, Eddie Drury wrote: Hi, Not uncommonly I will clock into a task

Re: [PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

2021-03-04 Thread Nick Savage
Please see the attached updated patch with the changes requested. Nick On 3/4/21 12:25 AM, Kyle Meyer wrote: Nick Savage writes: Hi everyone, See the attached patch. It is a small change to reduce code duplication between ob-sql.el and ob-sqlite.el by reusing org-babel-sql-expand-vars

[PATCH] Reduce code duplication in ob-sql.el and ob-sqlite.el

2021-03-03 Thread Nick Savage
Hi everyone, See the attached patch. It is a small change to reduce code duplication between ob-sql.el and ob-sqlite.el by reusing org-babel-sql-expand-vars as suggested by the FIXME in ob-sqlite.el. Thanks, Nick >From 849a1b7417b39abbf0aeb1b241e890470e4111cd Mon Sep 17 00:00:00 2001 From:

Re: Please help by becoming a maintainer for an Org Babel file

2021-03-02 Thread Nick Savage
Hi Bastien, I'm willing to volunteer to maintain ob-sqlite.el. I think like Andy, I have some work to do to get up to speed on my elisp but I'm comfortable enough with sqlite itself. As far as I'm aware my copyright process has been finalized as well. Thanks, Nick On 10/26/20 4:07 AM,