Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-06-25 Thread Ihor Radchenko
Allen Li writes: > Attached Thanks! Applied onto main via 711ada5ac. I changed the patch slightly adding ;; FIXME: Add tests for all other allowed prefix arguments. line to the test. Best, Ihor

Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-06-25 Thread Allen Li
Attached On Sat, Jun 25, 2022 at 9:48 PM Ihor Radchenko wrote: > Allen Li writes: > > >> Would you also be interested to write a test checking org-todo ARGS? > >> > > > > Attached > > Thanks! However, it is unclear what this test is checking for. > > > +(ert-deftest test-org/org-todo-prefix ()

Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-06-25 Thread Ihor Radchenko
Allen Li writes: >> Would you also be interested to write a test checking org-todo ARGS? >> > > Attached Thanks! However, it is unclear what this test is checking for. > +(ert-deftest test-org/org-todo-prefix () > + "Test `org-todo' prefix arg behavior." > + ;; -1 prefix arg should cancel rep

Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-06-25 Thread Allen Li
On Fri, Jun 17, 2022 at 11:09 PM Ihor Radchenko wrote: > Ihor Radchenko writes: > > > Allen Li writes: > > > >> On Sat, Jan 1, 2022 at 9:31 AM Allen Li > wrote: > >> > >>> It seems like the right fix here is to make - behave the same as -1, > and > >>> raise a user error for any other negative

Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-06-17 Thread Ihor Radchenko
Ihor Radchenko writes: > Allen Li writes: > >> On Sat, Jan 1, 2022 at 9:31 AM Allen Li wrote: >> >>> It seems like the right fix here is to make - behave the same as -1, and >>> raise a user error for any other negative numeric prefix, since it is >>> likely not doing whatever the user wanted.

Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-02-07 Thread Ihor Radchenko
Allen Li writes: > On Sat, Jan 1, 2022 at 9:31 AM Allen Li wrote: > >> It seems like the right fix here is to make - behave the same as -1, and >> raise a user error for any other negative numeric prefix, since it is >> likely not doing whatever the user wanted. >> > > Attached a small patch fix

Re: [BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-01-01 Thread Allen Li
On Sat, Jan 1, 2022 at 9:31 AM Allen Li wrote: > It seems like the right fix here is to make - behave the same as -1, and > raise a user error for any other negative numeric prefix, since it is > likely not doing whatever the user wanted. > Attached a small patch fixing this, which I tested manu

[BUG] org-todo (C-c C-t) bad negative prefix behavior [9.5.2 (9.5.2-gfbff08 @ /home/ionasal/.emacs.d/elpa/org-9.5.2/)]

2022-01-01 Thread Allen Li
The docstring for org-todo (C-c C-t) is unclear about the handling of - prefix compared to -1 prefix. Here is the relevant part of the docstring: With ‘C-u’ prefix ARG, force logging the state change and take a logging note. With a ‘C-u C-u’ prefix, switch to the next set of TODO keyw