Re: [O] [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns

2018-04-23 Thread Bastien
Hi, Nicolas Goaziou writes: >> BTW, I write some documents on Worg about ob-clojure :ns usage, >> ob-clojure-literate.el and ob-js :session usage etc. But I can't push to >> remote. Here is my steps. > > I'm Cc'ing Bastien about it. Yes, this has been sorted out,

Re: [O] [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns

2018-04-15 Thread Nicolas Goaziou
Hello, stardiviner writes: > About the compilation warnings. I only did "make test". have not do > compilation test. Do you mean compile whole org-mode project or compile > a single file ob-clojure.el with [M-x byte-compile-file]? I will include > this step in my future

Re: [O] [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns

2018-04-14 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Nicolas Goaziou writes: > Hello, > > I applied the patches with some substantial changes to commit messages > (often incomplete), removed "subr-x.el" calls (`thread-last' is just > confusing) and fixed compilation

Re: [O] [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns

2018-04-14 Thread Nicolas Goaziou
Hello, stardiviner writes: > After about 5 times test, And about 4 times review. I decide to PR. Thank you. I applied the patches with some substantial changes to commit messages (often incomplete), removed "subr-x.el" calls (`thread-last' is just confusing) and fixed

[O] [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns

2018-04-13 Thread stardiviner
After about 5 times test, And about 4 times review. I decide to PR. About new header argument :ns, I don't know how to write the test for it with loading CIDER in ERT. So have not write test. But I load my patch code, and run test on the following examples works fine. #+begin_src clojure