Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-05-06 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: I guess that's fine. Still, someone who never uses narrows may find jump better, especially for short documents. If the org-src window can be configured to show less than a fullscreen I guess I would have no concerns with this proposal. I pushed a different

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-28 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: To have a defcustom that let you choose preferred method. Whether the default should be changed I don't know. We don't need a defcustom if we can assign a different keybinding to each of them. This is not possible ATM because it doesn't handle inline footnotes

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-28 Thread Rasmus
Nicolas Goaziou m...@nicolasgoaziou.fr writes: To have a defcustom that let you choose preferred method. Whether the default should be changed I don't know. We don't need a defcustom if we can assign a different keybinding to each of them. Perhaps. Unless C-c C-c should reflect my

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-27 Thread Rasmus
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Wouldn't it only find definition in the same file? If you use a popup indirect buffer narrowed to the footnote-definition in question I don't think these problems can exist. In any case, this would seem similar to the way ob handles code blocks.

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-27 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: I added this to org.texi. OK. Note, C-c ' will fail in the following example 'cause the fn definition does not have contents-end. I started to try fix this but feel free to beat me to it. I likely will not have time to look more into it until the weekend.

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-27 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: Would it make sense to allow this to hook into org-footnote-action? What do you mean by hooking it into `org-footnote-action'? To replace default action with this? This is not possible ATM because it doesn't handle inline footnotes at all (this requires some work

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-26 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: The problem is that narrow can be time-consuming to recreate. This is why we shouldn't mess with it in the first place. Wouldn't it only find definition in the same file? If you use a popup indirect buffer narrowed to the footnote-definition in question I don't

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-26 Thread Rasmus
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Good idea. I didn't thought about using org-src.el, but, albeit not perfect, it goes a long way towards avoiding these problems. I toyed a bit with that. Now C-' on a (non inline) footnote reference should edit it in a dedicated buffer. I tried

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-25 Thread Rasmus
Nicolas Goaziou m...@nicolasgoaziou.fr writes: In any case, how about some of these alternative approaches to the issue of handling footnotes from a narrowed buffer. 1. Retrieve the footnote in the minibuffer. E.g. org-footnote-action shows the footnote-definition if it is outside

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-25 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: Nicolas Goaziou m...@nicolasgoaziou.fr writes: Point is moved, though. If narrow shouldn't be broken then point shouldn't be moved. I.e. no move when the definition is not within the buffer. Fixed in 5954f6aa25b51a3a9a8f258fb0f15ef51be31366. Thank you.

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-25 Thread Rasmus
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Rasmus ras...@gmx.us writes: Nicolas Goaziou m...@nicolasgoaziou.fr writes: Point is moved, though. If narrow shouldn't be broken then point shouldn't be moved. I.e. no move when the definition is not within the buffer. Fixed in

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-25 Thread Rasmus
Rasmus ras...@gmx.us writes: 1. Retrieve the footnote in the minibuffer. E.g. org-footnote-action shows the footnote-definition if it is outside of the narrow (and known) in the minibuffer? E.g. 2. when using prefix. 2. Show the definition in the minibuffer as editable

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-25 Thread Nicolas Goaziou
Rasmus ras...@gmx.us writes: If it covers x%, for x large, of the realized usecases when working with a narrowed buffer it's still worth it. Please do not mess with user's narrowing. There's no valid reason to do this, no matter how large x is. In any case, how about some of these

[O] [bug, org] footnote-action broken with narrowed buffer

2015-04-24 Thread Rasmus
Hi, Narrow to h1 in the following example and run org-footnote-action on the footnote-reference. Expected behavior is IMO to go to the definition. This does not happen. Ideally, it should be possible to get back to the narrowed stage again, but I'm not sure how this would work. Perhaps hooking

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-24 Thread Nicolas Goaziou
Hello, Rasmus ras...@gmx.us writes: Narrow to h1 in the following example and run org-footnote-action on the footnote-reference. Expected behavior is IMO to go to the definition. This does not happen. I disagree. Interactive commands are not expected to break current narrowing (try, e.g.,

Re: [O] [bug, org] footnote-action broken with narrowed buffer

2015-04-24 Thread Rasmus
Nicolas Goaziou m...@nicolasgoaziou.fr writes: Hello, Rasmus ras...@gmx.us writes: Narrow to h1 in the following example and run org-footnote-action on the footnote-reference. Expected behavior is IMO to go to the definition. This does not happen. I disagree. Interactive commands are