Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-05-08 Thread Ihor Radchenko
Max Nikulin writes: > To wrap up, I suggest (and I do not insist) to drop > "-Djava.awt.headless=true" since "-headless" is anyway added in jar > mode. Those who desperately need namely "-Djava.awt.headless=true" (for > some unknown to me reason) may customize :java header argument. I do not

Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-23 Thread Max Nikulin
On 21/01/2022 19:48, Ihor Radchenko wrote: Max Nikulin writes: I have reordered some parts of your message I do not see much point customising this particular argument. We _do not_ want plantuml in gui mode. Ever. Otherwise, babel behaviour will be unpredictable. If we make it customizeable,

Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-21 Thread Dejan Josifović
On 19-Jan-22 17:54, Max Nikulin wrote: FYI, you can customise any header arg globally. See manual page 16.3 Using Header Arguments. info "(org) Using Header Arguments" https://orgmode.org/manual/Using-Header-Arguments.html Thanks for the info. I'm still not fully proficient in org-mode so

Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-21 Thread Ihor Radchenko
Max Nikulin writes: >> #!/bin/bash >> gjl_package=plantuml >> gjl_jar="plantuml.jar" >> source /usr/share/java-config-2/launcher/launcher.bash > > It seems with with the suggested patch both -Djava.awt.headless=true and > -headless are passed to jar. I suspect it is either redundant or >

Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-19 Thread Max Nikulin
On 18/01/2022 20:30, Ihor Radchenko wrote: Dejan Josifović writes: But, since ob-plantuml already had variable for arguments for executable it fells natural to me to have customizable variables for when using jar. These headers are of course easier, but the user would have to write them on

Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-18 Thread Ihor Radchenko
Dejan Josifović writes: > But, since ob-plantuml already had variable for arguments for executable > it fells natural to me to have customizable variables for when using > jar. These headers are of course easier, but the user would have to > write them on each source block to achieve

Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-17 Thread Dejan Josifović
On 16-Jan-22 08:53, Max Nikulin wrote: Dejan, have you tried :java or :cmdline header arguments? Hi Max! Yes, I have tried with those header arguments and they naturally work. Maybe I should've mentioned that. But, since ob-plantuml already had variable for arguments for executable it

Re: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-15 Thread Max Nikulin
Hi. Disclaimer: I am neither plantuml nor ditaa user, so my comments may have no sense. On 15/01/2022 13:20, Ihor Radchenko wrote: Dejan Josifović writes: Comparing ob-plantuml.el and plantuml-mode.el files I found what is the problem. plantuml-mode has a customizable variable for

[PATCH] ob-plantuml: Allow setting PlantUML args for jar file

2022-01-14 Thread Ihor Radchenko
00:00:00 2001 Message-Id: <87accd87fa189198e69632da6081f60bc247ad94.1642227388.git.yanta...@gmail.com> From: Ihor Radchenko Date: Sat, 15 Jan 2022 14:14:36 +0800 Subject: [PATCH] ob-plantuml: Allow setting PlantUML args for jar file * lisp/ob-plantuml.el (org-plantuml-args): Rename `org-pla