Re: [PATCH] ox-icalendar.el: create alarm at event time

2022-07-31 Thread Ihor Radchenko
Mikhail Skorzhinskii writes: > Thank you for the review, appreciate your comments. I've applied your > suggestions. Please find the fixed file in the attachment to this > letter. It took a while, but Applied onto main via 31b3b164d after adding a TINYCHANGE cookie to the commit message (AFAIK, y

Re: [PATCH] ox-icalendar.el: create alarm at event time

2021-12-28 Thread Mikhail Skorzhinskii
Hi Nicolas, Thank you for the review, appreciate your comments. I've applied your suggestions. Please find the fixed file in the attachment to this letter. There is one important note that about this patch. There is one corner case: when we've set org-icalendar-force-alarm variable to nil, org- i

Re: [PATCH] ox-icalendar.el: create alarm at event time

2021-12-26 Thread Nicolas Goaziou
Hello, Mikhail Skorzhinskii writes: > * lisp/ox-icalendar.el (org-icalendar-force-alarm): option to set alarm > even if alarm time is set to zero. > * lisp/ox-icalendar.el (org-icalendar--valarm): create VALARM at the > event start if the alarm time is set to zero and > `org-icalendar-force-alar

[PATCH] ox-icalendar.el: create alarm at event time

2021-12-25 Thread Mikhail Skorzhinskii
* lisp/ox-icalendar.el (org-icalendar-force-alarm): option to set alarm even if alarm time is set to zero. * lisp/ox-icalendar.el (org-icalendar--valarm): create VALARM at the event start if the alarm time is set to zero and `org-icalendar-force-alarm' is set to true. ---  lisp/ox-icalendar.el |