Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

Dmitry Logvinenko writes: > Thank you for your comments, fixed. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=5b3a1a634 I also added you to the contributor list. https://git.sr.ht/~bzg/worg/commit/d9174193 -- Ihor Radchenko // yantar92, Org mode

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

Thank you for your comments, fixed. 0001-lisp-org-habit.el-Inherit-habit-style-property.patch Description: Binary data

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

Dmitry Logvinenko writes: > Subject: [PATCH] lisp/org-habit.el: Inherit habit style property > > * lisp/org-habit.el (org-is-habit-p): Use `org-entry-get' with > 'selective option to optionally find habit subheadings. > * etc/ORG-NEWS: Describe a breaking change. Thanks for the patch! May I

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

-- Dmitry Logvinenko // dmlogv 0001-lisp-org-habit.el-Inherit-habit-style-property.patch Description: Binary data

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally)

> Ihor Radchenko writes: > Colin Baxter writes: >> > No objections have been raised. >> >> Well, you have not really given much time to respond. > 2 weeks. I could have waited one month, but this is relatively > safe breaking change. >> Does this mean that all

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally)

Colin Baxter writes: > > No objections have been raised. > > Well, you have not really given much time to respond. 2 weeks. I could have waited one month, but this is relatively safe breaking change. > Does this mean that all sub-heading with their TODOs will now become > habits? I would

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally)

> Ihor Radchenko writes: > Ihor Radchenko writes: >> I am generally in favour of allowing STYLE to be inherited, but >> it is technically a breaking change, as I described. >> >> Let's see if anyone voices against this change. > No objections have been raised.

Re: [POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

Ihor Radchenko writes: > I am generally in favour of allowing STYLE to be inherited, but it is > technically a breaking change, as I described. > > Let's see if anyone voices against this change. No objections have been raised. Dmitry, could you please create a proper patch, adding

[POLL] Will it be ok to allow HABIT property inheritance? (optionally) (was: [BUG] org-habit does not respect STYLE property inheritance)

Дмитрий Логвиненко writes: > I've noticed that org-habits does not take an inherited STYLE property > when it searches entries. > > ;; Proposed > (defun org-is-habit-p ( pom) > "Is the task at POM or point a habit?" > (string= "habit" (org-entry-get (or pom (point))