Re: restore window configuration after org-edit-src-exit

2020-09-05 Thread Bastien
Hi Edgar, ed...@openmail.cc writes: > Hello. I would like to request this to be pushed onto the =maint= > branch (7684b59c7) or make it the default, please. this has been applied in the master branch back in January, it will be part of Org 9.4. Best, -- Bastien

Re: restore window configuration after org-edit-src-exit

2020-05-17 Thread edgar
Hello. I would like to request this to be pushed onto the =maint= branch (7684b59c7) or make it the default, please. https://lists.gnu.org/archive/html/emacs-orgmode/2019-12/txtr_q1WmvVPH.txt which is related to (at least) commits 7d5e931f7 and d833920de from the =master= branch. I have also

Re: [PATCH] restore window configuration after org-edit-src-exit

2020-01-14 Thread Jack Kamm
By the way -- I just got my copyright papers officially updated for my current job -- so we don't need to worry about line counts and whatnot anymore :) Best, John "Jack" Kamm

Re: [PATCH] restore window configuration after org-edit-src-exit

2020-01-09 Thread Jack Kamm
Hello, Nicolas Goaziou writes: > Thank you for the patch! Some comments follow. > > It would be useful to also explain what happens when the value is > `reorganize-frame', `split-window-right', or `split-window-right', e.g., > that previous window configuration is restored. > > It may be useful

Re: [PATCH] restore window configuration after org-edit-src-exit

2020-01-09 Thread Matt Price
Hi, sorry I missed this thread in the peri-holiday rush, just want to say thank you all for ironing out the difficulties arsing from that change earlier. On Tue, Jan 7, 2020 at 4:06 AM Nicolas Goaziou wrote: > Hello, > > Jack Kamm writes: > > > Attached is a patch to restore the window

Re: [PATCH] restore window configuration after org-edit-src-exit

2020-01-07 Thread Nicolas Goaziou
Hello, Jack Kamm writes: > Attached is a patch to restore the window configuration after exiting an > org source buffer, when org-src-window-setup is one of reorganize-frame, > split-window-below, or split-window-right. Thank you for the patch! Some comments follow. > @@ -156,8 +156,7 @@

[PATCH] restore window configuration after org-edit-src-exit

2019-12-23 Thread Jack Kamm
Attached is a patch to restore the window configuration after exiting an org source buffer, when org-src-window-setup is one of reorganize-frame, split-window-below, or split-window-right. References: https://lists.gnu.org/archive/html/emacs-orgmode/2019-12/msg00263.html

Re: restore window configuration after org-edit-src-exit

2019-12-23 Thread Nicolas Goaziou
Jack Kamm writes: > However, the change here is very small, I just wrote a small patch and > it's 15 insertions (+), 4 deletions(-), including the entry in > ORG-NEWS. My understanding is that such small changes don't require > explicit copyright assignment. > > Is it OK for me to send the patch

Re: restore window configuration after org-edit-src-exit

2019-12-23 Thread Jack Kamm
> OK. Would you want to implement it? Yes, but I'm still in the process of updating my copyright papers for my current job. My job said they won't be able to sign the copyright disclaimer until the new year, so I expect this to be sorted out later in January some time. However, the change here

Re: restore window configuration after org-edit-src-exit

2019-12-23 Thread Nicolas Goaziou
Hello, Jack Kamm writes: > I agree, this sounds like the correct behavior to me. OK. Would you want to implement it? Regards, -- Nicolas Goaziou

Re: restore window configuration after org-edit-src-exit

2019-12-22 Thread Jack Kamm
Hi, > I think any value that modifies the current layout ought to restore it: > - `split-window-below' > - `split-window-right' > - `reorganize-frame' > > OTOH, values that use the current layout should not restore it > afterwards: > - `current-window' > - `other-window' > - `other-frame' > >

Re: restore window configuration after org-edit-src-exit

2019-12-22 Thread Nicolas Goaziou
Hello, Jack Kamm writes: > Rather than adding a new option, how about we make the behavior > dependent on the value of org-src-window-setup? > > Basically, when org-src-window-setup is current-window, it never makes > sense to restore the original layout. But when org-src-window-setup is >

Re: restore window configuration after org-edit-src-exit

2019-12-17 Thread Fraga, Eric
On Tuesday, 17 Dec 2019 at 06:28, Jack Kamm wrote: > Basically, when org-src-window-setup is current-window, it never makes > sense to restore the original layout. But when org-src-window-setup is > reorganize-frame (the default), it always makes sense to restore the > original layout. This makes

Re: restore window configuration after org-edit-src-exit

2019-12-17 Thread Jack Kamm
Sorry for the noise, but I just had another thought: Rather than adding a new option, how about we make the behavior dependent on the value of org-src-window-setup? Basically, when org-src-window-setup is current-window, it never makes sense to restore the original layout. But when

Re: restore window configuration after org-edit-src-exit

2019-12-17 Thread Jack Kamm
I'd like to add a vote for the old behavior. I only recently noticed the new behavior, and agree with Richard that it's inconvenient. I think many of us missed this change because it wasn't in 9.2. In particular, I'd propose to make the old behavior the default, and hide the new behavior behind

Re: restore window configuration after org-edit-src-exit

2019-12-16 Thread Kyle Meyer
Nicolas Goaziou writes: > However, it doesn't mean the inconvenience shouldn't be fixed. I cannot > remember why 819e98afd018cad3c13fd58bfcbd979ab36dfbc7 was necessary. I'm > Cc'ing Matt Price. Here's the related thread: https://lists.gnu.org/archive/html/emacs-orgmode/2018-11/msg00253.html

Re: restore window configuration after org-edit-src-exit

2019-12-16 Thread Nicolas Goaziou
Hello, Richard Kim writes: > About a year ago change 819e98afd018cad3c13fd58bfcbd979ab36dfbc7 was checked > in > to remove code that restored window configuration when =org-edit-src-exit= > finished. The net result is af if =C-x 1= is called to remove all windows > except > the org buffer

restore window configuration after org-edit-src-exit

2019-12-16 Thread Richard Kim
About a year ago change 819e98afd018cad3c13fd58bfcbd979ab36dfbc7 was checked in to remove code that restored window configuration when =org-edit-src-exit= finished. The net result is af if =C-x 1= is called to remove all windows except the org buffer just edited. This is very inconvenient. Why