Re: [O] buffer-file-name in [* Org src *] buffers

2018-04-26 Thread Clément Pit-Claudel
On 2018-04-26 19:34, Bastien wrote: > Hi Clément and Nicolas, > […] > I've removed the setting of `buffer-file-name' in Org Src buffers. Wonderful news, thanks Bastien !

Re: [O] buffer-file-name in [* Org src *] buffers

2018-04-26 Thread Bastien
Hi Clément and Nicolas, Clément Pit-Claudel writes: >> * Proposed bug I >> C-x k kills the edit buffer without questions; the overlay >> remains, but now links to a deleted buffer. >> * Proposed bug II >> C-x C-c kills a modified edit buffer silently, without offering to >>

Re: [O] buffer-file-name in [* Org src *] buffers

2018-03-14 Thread Nicolas Goaziou
Hello, Clément Pit-Claudel writes: > 1. Set buffer-offer-save to 'always; this guarantees that C-x s will ask > about the edit buffer. > 2. Add an entry to kill-buffer-query-functions. For example, with-editor > (used by magit) does this: >(add-hook 'kill-buffer-query-functions >

Re: [O] buffer-file-name in [* Org src *] buffers

2018-03-14 Thread Clément Pit-Claudel
Hi Nicolas, > The explanation is here: > > > > AFAIU, this was needed so that Emacs would warn when closing a remote > editing buffer with C-x k. This feature doesn't appear to be functional > at the moment, tho. Sorry for

Re: [O] buffer-file-name in [* Org src *] buffers

2018-03-12 Thread Nicolas Goaziou
Hello, Clément Pit-Claudel writes: > TL;DR: why does org-src-mode-configure-edit-buffer set > buffer-file-name to a non-nil value? > https://code.orgmode.org/bzg/org-mode/commit/4b6988bf36cb458c9d113ee4332e016990c1eb04#diff-ea848b037ba2c0bf95915700bb6f4e539d80d8cR486 [...] > Why is that? The

Re: [O] buffer-file-name in [* Org src *] buffers

2018-03-11 Thread numbch...@gmail.com
I agree, should compatible with situations like `flycheck` need to use buffer-file-name. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiv

[O] buffer-file-name in [* Org src *] buffers

2018-03-11 Thread Clément Pit-Claudel
Hi all, TL;DR: why does org-src-mode-configure-edit-buffer set buffer-file-name to a non-nil value? https://code.orgmode.org/bzg/org-mode/commit/4b6988bf36cb458c9d113ee4332e016990c1eb04#diff-ea848b037ba2c0bf95915700bb6f4e539d80d8cR486 Background information: I'm reviewing a patch (https://git