Ihor Radchenko writes:
> Fixed now.
Fantastic! And thank you again, Ihor, for the guidance.
Rudy
--
"I love deadlines. I love the whooshing noise they make as they go by."
-- Douglas Adams, The Salmon of Doubt, 2002
Rudolf Adamkovič [he/him]
Studenohorská 25
84103 Bratislava
Slovakia
Rudolf Adamkovič writes:
>> I have replaced "MathJax 4" instances with "MathJax 3". I guess it was
>> a typo.
>
> The patch (correctly) distinguishes between:
>
> - MathJax 2 that we deprecated,
> - MathJax 3 that we now use by default, and
> - MathJax 4 that we support but do *not* use by
Ihor Radchenko writes:
> Rudolf, I have applied your patch onto main with amendments.
Thank you!
> I have replaced "MathJax 4" instances with "MathJax 3". I guess it was
> a typo.
The patch (correctly) distinguishes between:
- MathJax 2 that we deprecated,
- MathJax 3 that we now use by
Bastien Guerry writes:
>> Or should we do something in
>> addition to announce backwards-incompatible change?
>
> I suggest to make this change visible on update.orgmode.org by sending
> an announcement to the list using X-Woof-Change: 9.6 as a header.
Done. Hopefully it is going to work:
Ihor Radchenko writes:
> Is the current news entry is sufficient?
The ORG-NEWS entry in the patch looks good, thanks.
> Or should we do something in
> addition to announce backwards-incompatible change?
I suggest to make this change visible on update.orgmode.org by sending
an announcement to
Rudolf Adamkovič writes:
> Ihor Radchenko writes:
>
>> I note that you did not mention in the news that MathJax 2 support is
>> dropped. This is a very important thing we must highlight and ring all
>> the bells about.
>
> Fixed. See the 8th revision of the patch attached below. Better?
Ihor Radchenko writes:
> I note that you did not mention in the news that MathJax 2 support is
> dropped. This is a very important thing we must highlight and ring all
> the bells about.
Fixed. See the 8th revision of the patch attached below. Better?
> Consider that someone has customized
Rudolf Adamkovič writes:
> Below, I attach the 7th revision of the patch.
Thanks!
I note that you did not mention in the news that MathJax 2 support is
dropped. This is a very important thing we must highlight and ring all
the bells about.
Consider that someone has customized path option to a
Ihor Radchenko writes:
> Then, please mention this in the NEWS. Something like "we drop
> extension support as it never worked anyway".
Fixed. I also reworded the surrounding text to match.
> You may even drop append and use ,@options inside `(...). Not a big
> deal though.
Fixed.
> If
Rudolf Adamkovič writes:
>> Are these extensions no longer supported?
>
> MathJax 3+ supports extensions, and one can load them in multiple ways.
> See [1]. It deserves some thinking, for the extensions mirror LaTeX
> extensions. So, to make both HTML and PDF work, one has:
>
> Use the
Ihor Radchenko writes:
> Is it really recommended by mathjax?
Yes.
> I cannot find any mention of jsdelivr.com.
1. Open MathJax docs (https://docs.mathjax.org/en/latest/).
2. Type "jsDelivr" into the search box.
3. Check the search results.
> You may update the URL to something more precise.
Rudolf Adamkovič writes:
> Rudolf Adamkovič writes:
>
>> See the 4th version of the patch attached below.
>
> And, of course, I forgot to update the commit message with the new
> macro. Please see the 5th version of the patch attached below.
Thanks!
> with Org[fn:: By default Org loads
Rudolf Adamkovič writes:
>> Also, I think that conversion message may worth a warning.
>
> You have mentioned this twice, but you have never said why. I remain
> open, but I need know the reason. To give you mine:
>
> We need to inform the user, not necessarily warn them. They can keep
>
Rudolf Adamkovič writes:
> See the 4th version of the patch attached below.
And, of course, I forgot to update the commit message with the new
macro. Please see the 5th version of the patch attached below.
P.S. I also fixed a preposition in the documentation comment of the new
macro, now
Ihor Radchenko writes:
> Then, you can `cl-letf'-bind the message function in a new macro added
> to org-test.el. The binding will accumulate messages in some
> list. Then, use that macro to test the messages.
What a great piece of advice. Thank you, Ihor!
See the 4th version of the patch
Rudolf Adamkovič writes:
> Ihor Radchenko writes:
>
>> The proper test is not presence of the message, but the correct
>> conversion of the legacy options in the actual html output.
>
> We do test the results in the HTML output, of course. Still, I would
> like to test the user messages too.
Ihor Radchenko writes:
> The proper test is not presence of the message, but the correct
> conversion of the legacy options in the actual html output.
We do test the results in the HTML output, of course. Still, I would
like to test the user messages too. By my definition, "proper" tests
Rudolf Adamkovič writes:
> Bummer! Do you have any suggestions in mind? Perhaps we could define
> an advice for '(current-message)', if that ever runs? I would welcome
> any ideas.
Using `current-message' would not be reliable even if it worked. It is
not future-compatible if we decide to
Ihor Radchenko writes:
> Nothing is attached.
I apologize. Please see the attached patch.
> If you are using Emacs to send email, I suggest you to enable checks
> for attachments, as I do in notmuch [...]
TIL and thank you! Added to my configuration.
> AFAIK, `current-message' always
Rudolf Adamkovič writes:
> Rudolf Adamkovič writes:
>
>> Good points; I will fix everything.
>
> Please see the attached (3rd) revision of the patch.
Nothing is attached.
If you are using Emacs to send email, I suggest you to enable checks for
attachments, as I do in notmuch
(add-hook
Rudolf Adamkovič writes:
> Good points; I will fix everything.
Please see the attached (3rd) revision of the patch.
However, the tests still fail when ran via `make test'. See below.
> Ihor Radchenko writes:
>
>> Your tests are failing on my side...
>
> The tests *pass* when ran in-buffer
Ihor Radchenko writes:
Thank you for taking a look, Ihor!
> Your tests are failing on my side...
Oh, I see! The tests *pass* when ran in-buffer but *fail* when ran via
'make test'. Just the tests that call (current-message) have this
problem. Interesting.
> ...
Good points; I will fix
Rudolf Adamkovič writes:
> Rudolf Adamkovič writes:
>
>> I will resurrect the thread when I have something to show.
>
> All right, I have finished the second version of the patch.
Thanks!
> What do you think?
Your tests are failing on my side...
Also,
In org-html--build-mathjax-config:
Rudolf Adamkovič writes:
> I will resurrect the thread when I have something to show.
All right, I have finished the second version of the patch.
What do you think?
Rudy
>From aee823f34498cccd6c08bcedb177c82d5de40269 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rudolf=20Adamkovi=C4=8D?=
Date:
24 matches
Mail list logo
