Re: [BUG] Infinite loop in org-agenda-show-new-time
Hi Andrew, Andrew Hyatt writes: > Thanks Bastien! I've tested this out and confirmed it works, and > didn't notice any side effects. Great, thanks for testing and confirming! -- Bastien
Re: [BUG] Infinite loop in org-agenda-show-new-time
Thanks Bastien! I've tested this out and confirmed it works, and didn't notice any side effects. On Fri, Feb 14, 2020 at 6:02 AM Bastien wrote: > Hi Andrew, > > thanks a lot for the minimal recipe! Very helpful. > I confirm the bug and I have now (finally) fixed it. > > We can close this bug from... 2013 :) > > Best, > > -- > Bastien >
Re: [BUG] Infinite loop in org-agenda-show-new-time
Hi Andrew, thanks a lot for the minimal recipe! Very helpful. I confirm the bug and I have now (finally) fixed it. We can close this bug from... 2013 :) Best, -- Bastien
Re: [BUG] Infinite loop in org-agenda-show-new-time
I whittled this down to the smallest reproducible case, which I'm attaching. Hopefully should be clear upon viewing the file how to reproduce. I'm still unsure of the best solution, I'll have to think about this some more - but at least the reproducible case will make it easier to debug into this for anyone who wants to try. On Tue, Feb 11, 2020 at 3:56 AM Bastien wrote: > Hi Matthew, > > not sure I replied to this one but in case I didn't, yes, my initial > fix was wrong, I reverted it. > > Thanks! > > -- > Bastien > repro.org Description: Binary data
Re: [BUG] Infinite loop in org-agenda-show-new-time
Hi Matthew, not sure I replied to this one but in case I didn't, yes, my initial fix was wrong, I reverted it. Thanks! -- Bastien
Re: [BUG] Infinite loop in org-agenda-show-new-time
Hi Bastien, Bastien writes: > > Andrew Hyatt writes: > >> Removing the (beginning-of-line 1) at the end of the time display >> code in that function, and substituting (org-agenda-previous-line) >> seems to fix it. I'm not sure if that's the right approach - the >> previous code didn't use that function for a reason, but I don't know >> what that reason was. > > I think this approach is correct is it will move over visible lines. > > I've pushed a patch, please let me know if it is fixed. I'm finding that this patch (19676dce758038749887a057208ea33d9a1fad57) has the by-product of causing multiple paths to flash in the mini-buffer if org-agenda-show-outline-path is set to t. I believe that is because it calls org-agenda-previous-line, which in turn calls org-agenda-do-context-action. The effect is even more pronounced if org-agenda-follow-mode is on, causing a significant slowdown in rescheduling items. Thanks, Matt
Re: [BUG] Infinite loop in org-agenda-show-new-time
It is fixed, but now the new time that's supposed to be displayed via text-properties does not show up. Let me spend some time and get a small reproducible case, which will help us test this. On Tue, Feb 4, 2020 at 6:38 PM Bastien wrote: > Hi Andrew, > > thanks again. > > Andrew Hyatt writes: > > > Removing the (beginning-of-line 1) at the end of the time display > > code in that function, and substituting (org-agenda-previous-line) > > seems to fix it. I'm not sure if that's the right approach - the > > previous code didn't use that function for a reason, but I don't know > > what that reason was. > > I think this approach is correct is it will move over visible lines. > > I've pushed a patch, please let me know if it is fixed. > > Best, > > -- > Bastien >
Re: [BUG] Infinite loop in org-agenda-show-new-time
Hi Andrew, thanks again. Andrew Hyatt writes: > Removing the (beginning-of-line 1) at the end of the time display > code in that function, and substituting (org-agenda-previous-line) > seems to fix it. I'm not sure if that's the right approach - the > previous code didn't use that function for a reason, but I don't know > what that reason was. I think this approach is correct is it will move over visible lines. I've pushed a patch, please let me know if it is fixed. Best, -- Bastien
Re: [BUG] Infinite loop in org-agenda-show-new-time
I've tried the latest version from Feb 2nd, and it still has the same issue. After some more time with the issue, the issue is when the agenda has items A, and next line, invisibily (due to org-agenda-dim-blocked-tasks), B. Trying to set A gets you into an invisible loop because moving to the start of the line after displaying the time in org-agenda-show-new-time doesn't take you far enough back to proceed backwards. The next iteration through the loop, the time will be re-displayed. Removing the (beginning-of-line 1) at the end of the time display code in that function, and substituting (org-agenda-previous-line) seems to fix it. I'm not sure if that's the right approach - the previous code didn't use that function for a reason, but I don't know what that reason was. On Mon, Feb 3, 2020 at 2:04 PM Bastien wrote: > Hi Andrew, > > I have pushed some fixes in this area, if you have a chance to test > Org from the latest maint or master branch, please do so and report > if the problem persists. > > Thanks, > > -- > Bastien >
Re: [BUG] Infinite loop in org-agenda-show-new-time
Hi Andrew, I have pushed some fixes in this area, if you have a chance to test Org from the latest maint or master branch, please do so and report if the problem persists. Thanks, -- Bastien
Re: [BUG] Infinite loop in org-agenda-show-new-time
On Sat, Feb 1, 2020 at 4:33 AM Bastien wrote: > Hi Andrew, > > Andrew Hyatt writes: > > > I've been having this same issue - the issue is quite reproducible > > for me, and it has been for years. I just finally grew tired of the > > issue and decided to investigate it, and yes, the issue is > > org-agenda-show-new-time. > > > > I also have invisible entries in the org buffer, and the call to > > org-move-to-column apparently will move several lines forward, which > > causes us to process the same lines over and over. > > > > Wrapping the call to org-move-to-column with a let setting the > > buffer-invisibility-spec to nil does fix the issue. > > this problem is from... 2013! > https://lists.gnu.org/archive/html/emacs-orgmode/2013-08/msg00218.html > > Is there anything we still need to fix in this area? If so, can you > send it as a patch against current maint branch? > Yes, there's definitely still a problem similar to the one reported - although I have yet to pare it down to a reproducible case. I need to look at this more to understand why the fix that was done doesn't seem to work. Once I understand that, I'll be close to creating a patch. The issue is that I don't know this code very well, so any fix I make might be wrong for some other reason I don't understand. > > Thanks, > > -- > Bastien >
Re: [BUG] Infinite loop in org-agenda-show-new-time
Hi Andrew, Andrew Hyatt writes: > I've been having this same issue - the issue is quite reproducible > for me, and it has been for years. I just finally grew tired of the > issue and decided to investigate it, and yes, the issue is > org-agenda-show-new-time. > > I also have invisible entries in the org buffer, and the call to > org-move-to-column apparently will move several lines forward, which > causes us to process the same lines over and over. > > Wrapping the call to org-move-to-column with a let setting the > buffer-invisibility-spec to nil does fix the issue. this problem is from... 2013! https://lists.gnu.org/archive/html/emacs-orgmode/2013-08/msg00218.html Is there anything we still need to fix in this area? If so, can you send it as a patch against current maint branch? Thanks, -- Bastien
