> Kyle Meyer writes:
>>> I don't know if this still technically qualifies as a tinychange. I've
>>> sent the email to request the CA form just in case.
>>
>> I don't know either. How about I apply your *.el changes, and we can
>> update ORG-NEWS once your assignment comes through?
On second th
Kyle Meyer writes:
>From ea3007a8b35d727f71860bd7697808f90d5e1e66 Mon Sep 17 00:00:00 2001
From: Adam Porter
Date: Mon, 7 Aug 2017 08:50:26 -0500
Subject: [PATCH] org-agenda.el: Add option to automatically align tags in
agenda
* lisp/org-agenda.el:
(org-agenda-tags-column): Add 'auto setting
Kyle Meyer writes:
> As you can see in the diffs above, master-only changes are using 26.1
> for :version. Assuming Org 9.0.* ships with Emacs 26.1, these will be
> wrong, but they can be updated all together once 26.2 is released.
Adam Porter writes:
> Kyle Meyer writes:
[...]
>> Since you're changing the default value, shouldn't you add appropriate
>> values for the :version and :package-version keywords?
>
> Thanks, I didn't know about these. I set :package-version to 9.1, since
> that should be the next Org release,
Kyle Meyer writes:
>> (org-agenda-align-tags): Handle automatic alignment
>> (org-agenda-tags-column): Add 'auto setting
>
> You're missing the file name in the entries above. Also, the entries
> should end in a period.
Oops, fixed.
> Since you're changing the default value, shouldn't you add
Adam Porter writes:
> Ok, I've updated the patch.
Thanks. A few more comments.
> (org-agenda-align-tags): Handle automatic alignment
> (org-agenda-tags-column): Add 'auto setting
You're missing the file name in the entries above. Also, the entries
should end in a period.
> -(defcustom org-a
Kyle Meyer writes:
> ... with just one case and a fallthrough, I'd prefer you test with eq
> rather than using pcase.
Hi Kyle,
Ok, I've updated the patch.
Thanks,
Adam
>From 99a61e09d5267ddaa84e8f93fbab161144aea011 Mon Sep 17 00:00:00 2001
From: Adam Porter
Date: Mon, 7 Aug 2017 08:50:26 -050
Adam Porter writes:
[...]
> + (org-agenda-tags-column (pcase org-agenda-tags-column
> + ('auto (- (window-text-width)))
I believe that `auto is needed instead of 'auto because the latter will
fail with Emacs versions earlier than Emacs 25. Though ...
> +
