Aaron Ecay writes:
Fixed. (It actually required changes to the code, not the tests, since
my commit made org-babel-graphical-output-file stricter).
OK.
Good catch (especially since I recently pushed a patch changing some
errors to user-errors *blush*). Fixed.
Code review works. :-)
Hi,
Achim Gratz strom...@nexgo.de writes:
That breaks the tests for Octave and Maxima; since you're intentionally
not keeping backwards compatibility here this should be fixed in the
tests, I'd think.
Agreed. Aaron, can you take care of this?
Also, I'd think you should be using user-error
Hi Achim,
2014ko maiatzak 14an, Achim Gratz-ek idatzi zuen:
That breaks the tests for Octave and Maxima; since you're intentionally
not keeping backwards compatibility here this should be fixed in the
tests, I'd think.
Fixed. (It actually required changes to the code, not the tests, since
my
Aaron Ecay writes:
Thanks again for the feedback. I just pushed the revised patch to master.
I think I would prefer the code in this patch to do nothing in this case
(not create a :file value), but for language-specific code that needs a
:file to raise an error to prompt the user to add a
Hi Eric, Bastien, Achim, et al.,
Thanks again for the feedback. I just pushed the revised patch to master.
2014ko maiatzak 4an, Eric Schulte-ek idatzi zuen:
[...]
One option might be to borrow naming behavior from the comment
functionality in ob-tangle which looks like the following (from
Hi Aaron,
Thanks for this patch, and especially for including documentation. It
looks good to me, and it (largely [1]) passes all tests.
Aaron Ecay aarone...@gmail.com writes:
Hi Eric, Bastien, Achim,
Thanks so much for the feedback. I’ve adopted the :file-ext approach
suggested by
Hi Aaron,
Aaron Ecay aarone...@gmail.com writes:
Thanks so much for the feedback. I’ve adopted the :file-ext approach
suggested by Bastien, leaving the previous default behavior in place for
blocks with a :file argument.
Looks good -- please apply in master.
Thanks!
PS: I assume you have
Aaron Ecay writes:
Thanks so much for the feedback. I’ve adopted the :file-ext approach
suggested by Bastien, leaving the previous default behavior in place for
blocks with a :file argument.
THanks for taking care, I'll not have time to look at this for the
remainder of the week, though…
Hi Eric, Bastien, Achim,
Thanks so much for the feedback. I’ve adopted the :file-ext approach
suggested by Bastien, leaving the previous default behavior in place for
blocks with a :file argument.
2014ko apirilak 22an, Eric Schulte-ek idatzi zuen:
[...]
One option might be to borrow naming
Hi Aaron,
Aaron Ecay aarone...@gmail.com writes:
How does this sound as an algorithm:
1. if :file is present, behave exactly as we do now
2. if :file is absent but :file-ext and a #+name is present, generate a
:file parameter from :output-dir, the #+name, and :file-ext.
I suggest this
Looks useful to me, but :file png looks wrong, with too much
implicit. We should find something less confusing.
One option would be to use :file-ext instead, to generate a :file
parameter. I didn’t go this route because autogenerating :file from
other parameters seemed like too much magic.
Bastien b...@gnu.org writes:
Hi Aaron,
Aaron Ecay aarone...@gmail.com writes:
How does this sound as an algorithm:
1. if :file is present, behave exactly as we do now
2. if :file is absent but :file-ext and a #+name is present, generate a
:file parameter from :output-dir, the #+name,
Hi,
Eric Schulte schulte.e...@gmail.com writes:
One option might be to borrow naming behavior from the comment
functionality in ob-tangle which looks like the following (from line 426
in ob-tangle.el).
Indeed, it's safer than just using the buffer file name.
Aaron, please go ahead with the
Aaron Ecay writes:
How does this sound as an algorithm:
1. if :file is present, behave exactly as we do now
2. if :file is absent but :file-ext and a #+name is present, generate a
:file parameter from :output-dir, the #+name, and :file-ext.
3. If both :file and :file-ext are present, :file
Hi Aaron,
thanks for the patch.
Aaron Ecay aarone...@gmail.com writes:
#+name: one
#+begin_src R :results file graphics :file png
...
#+end_src
What happens when there is :file png with no #+name line?
The benefit comes from the reduced duplication of information in the
file. It also
Hi Bastien,
Thanks for your feedback.
2014ko apirilak 22an, Bastien-ek idatzi zuen:
[...]
#+name: one
#+begin_src R :results file graphics :file png
...
#+end_src
What happens when there is :file png with no #+name line?
This case will be treated as before the patch: output will go to
16 matches
Mail list logo
