Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Nicolas Goaziou
Rasmus writes: > What is the rational behind "Org 8.3 has Emacs 23 support; Org 8.4 does > not". I'm just trying to understand. . . Easy: 8.3 ends with a 3, like Emacs 23... Org 8.3 is close from being released. It started with Emacs 23 support, a long time ago, so it would make little sense t

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Rasmus
Nicolas Goaziou writes: > Org 8.4 will drop support for Emacs 23, i.e., as soon as Org 8.3 is > released, we can activate lexical binding on master. What is the rational behind "Org 8.3 has Emacs 23 support; Org 8.4 does not". I'm just trying to understand. . . —Rasmus -- Vote for proprietar

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Rasmus
Rasmus writes: >>> (define-obsolete-function-alias >>> 'show-all 'outline-show-all "25.1") >> >> Ah right. That's the same idea. Functions without a namespace are being >> renamed. > > My Debian Squeeze VM has 23.4.1. ^^ Wheezy that is Actually, Debian 7.8 has a Emacs 2

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Nicolas Goaziou
Rasmus writes: > So when can we target Emacs 24? Jessie? My Debian Squeeze VM has 23.4.1. > CentOS 7 is already on Emacs 24.3. Org 8.4 will drop support for Emacs 23, i.e., as soon as Org 8.3 is released, we can activate lexical binding on master. Regards,

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Rasmus
Nicolas Goaziou writes: > Rasmus writes: > >> The think that comes to mind is `show-all'. In my Emacs: >> >> (define-obsolete-function-alias >> 'show-all 'outline-show-all "25.1") > > Ah right. That's the same idea. Functions without a namespace are being > renamed. Good riddance.

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Nicolas Goaziou
Rasmus writes: > The think that comes to mind is `show-all'. In my Emacs: > > (define-obsolete-function-alias > 'show-all 'outline-show-all "25.1") Ah right. That's the same idea. Functions without a namespace are being renamed. Regards,

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Rasmus
Nicolas Goaziou writes: > What do you mean by "outline prefixes"? The think that comes to mind is `show-all'. In my Emacs: (define-obsolete-function-alias 'show-all 'outline-show-all "25.1") —Rasmus -- There are known knowns; there are things we know that we know

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-20 Thread Nicolas Goaziou
Rasmus writes: > PS: Is that also why the outline prefixes are being added? It complains > about it when you compile org. What do you mean by "outline prefixes"? Regards,

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-19 Thread Rasmus
Nicolas Goaziou writes: > Rasmus writes: > >> E.g. org-latex--find-verb-separator or org-get-outline-path also uses >> cl-loop (or at least loop which is an alias for cl-loop). > > `loop' is fine. `cl-loop' is not, at least in Org 8.3. The same goes for > `incf' instead of `cl-incf'. Okay. I r

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-19 Thread Nicolas Goaziou
Rasmus writes: > E.g. org-latex--find-verb-separator or org-get-outline-path also uses > cl-loop (or at least loop which is an alias for cl-loop). `loop' is fine. `cl-loop' is not, at least in Org 8.3. The same goes for `incf' instead of `cl-incf'. Regards,

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-19 Thread Rasmus
Nicolas Goaziou writes: > Rasmus writes: > >> Oh, I pushed this by accident (damn). Should I revert it? >> >> http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=14a9510ce1b5535906ceb6a93238e132964fd45f > > No, but you cannot let cl-loop and cl-incf in the code, since we still > support Emacs 2

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-19 Thread Nicolas Goaziou
Rasmus writes: > Oh, I pushed this by accident (damn). Should I revert it? > > http://orgmode.org/cgit.cgi/org-mode.git/commit/?id=14a9510ce1b5535906ceb6a93238e132964fd45f No, but you cannot let cl-loop and cl-incf in the code, since we still support Emacs 23. Regards,

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-19 Thread Rasmus
Rasmus writes: >> This is exactly what we want: indent (non empty) lines starting in >> [BEG ; END[. Or am I missing something? > > OK, the missing key is org-indent-line-to. It works better in this case > and I can use end. >> Another option: when ENV is inserted the first time, store (e.g., i

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-18 Thread Rasmus
Hi, Nicolas Goaziou writes: >> Perhaps there are clever ways to figure it out. I say there are too many >> dynamics and "fixes" in the code to get cdlatex-environment to work >> already. Just consider this example where | is cursor >> >>- foo | bar >> >> Midway through, when ENV is reinser

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-17 Thread Rasmus
Nicolas Goaziou writes: > Rasmus writes: > >> Perhaps there are clever ways to figure it out. I say there are too many >> dynamics and "fixes" in the code to get cdlatex-environment to work >> already. Just consider this example where | is cursor >> >>- foo | bar >> >> Midway through, when

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-17 Thread Nicolas Goaziou
Rasmus writes: > Perhaps there are clever ways to figure it out. I say there are too many > dynamics and "fixes" in the code to get cdlatex-environment to work > already. Just consider this example where | is cursor > >- foo | bar > > Midway through, when ENV is reinserted, but before inden

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-17 Thread Rasmus
Nicolas Goaziou writes: > I don't think you need `org-element-at-point' at all. You already have > BEG and END markers available. I didn't test it, but this should be > enough to indent the environment. Perhaps there are clever ways to figure it out. I say there are too many dynamics and "fixes

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-17 Thread Nicolas Goaziou
Rasmus writes: > + ;; cdlatex-environment always return nil. Therefore, capture output > + ;; first and determine if an environment was selected. > + (let* ((beg (point-marker)) > + (end (copy-marker (point) t)) > + (env (org-trim > +(or (progn (ignore-errors (cdlatex-en

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-16 Thread Rasmus
Hi, > Another idea: [...] Good trick. I used it in attached, which I think works well. —Rasmus -- With monopolies the cake is a lie! >From 4ab1df88e5bf87d01594e280af7887cc6cd0d3ca Mon Sep 17 00:00:00 2001 From: rasmus Date: Tue, 10 Feb 2015 12:02:59 +0100 Subject: [PATCH] org.el: Change inde

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-15 Thread Nicolas Goaziou
Rasmus writes: > It's a very good idea! On the top of my head there's two issues. > > 1. cdlatex-environment doesn't work with buffers, only files...¹ I think > it doesn't even work with (with-temp-file · ⋯) without saving the file > first. Try: > > (require 'cdlatex) >

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-14 Thread Rasmus
Nicolas Goaziou writes: > Another idea: insert the environment in a temp buffer. Check for buffer > emptiness. If there is something, insert it with appropriate > indentation. It's a very good idea! On the top of my head there's two issues. 1. cdlatex-environment doesn't work with buffers, on

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-14 Thread Nicolas Goaziou
Rasmus writes: > This patch applies indentation unless at BOL in which case it stays at > BOL. The rest is basically just to work with cdlatex and not insert too > many blank lines. It's still quicky, but these quirks seem to be cdlatex > quirks. > > I wonder, are there any commands to merge tw

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-13 Thread Nicolas Goaziou
Rasmus writes: > I insert a newline before I even call cdlatex. If point moved _after calling cdlatex_ you know it worked. Otherwise, you just remove the newline. > I fail to see the relevant of your example. I want to know why: > >-i1 > X -i2 > > => C-j > >-i1 > > -i2 > > I.e.

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-13 Thread Rasmus
Rasmus writes: > Hi, > > Nicolas Goaziou writes: > >>> I don't feel strongly about it. Anyway, I like this better. Cdlatex is, >>> um, "opinionated" about is insertion of newlines. >> >> I still think it is better to split line. Your behaviour just requires >> a C-e before calling the function

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-13 Thread Rasmus
Hi, Nicolas Goaziou writes: >> I don't feel strongly about it. Anyway, I like this better. Cdlatex is, >> um, "opinionated" about is insertion of newlines. > > I still think it is better to split line. Your behaviour just requires > a C-e before calling the function. I agree that the "simpler

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-13 Thread Nicolas Goaziou
Rasmus writes: > Nicolas Goaziou writes: > >> I don't see how it is desirable. The logical behaviour is to split the >> line, unless, of course, docstring clearly specifies this. > > I don't feel strongly about it. Anyway, I like this better. Cdlatex is, > um, "opinionated" about is insertion

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-11 Thread Rasmus
Hi, Thanks for the comments! Nicolas Goaziou writes: > I don't see how it is desirable. The logical behaviour is to split the > line, unless, of course, docstring clearly specifies this. I don't feel strongly about it. Anyway, I like this better. Cdlatex is, um, "opinionated" about is insert

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-11 Thread Nicolas Goaziou
Rasmus writes: > Indeed that this the trick. The attached patch seems to work nicely and > takes care of the corner cases I could think of. > > I now get the following (desirable) behavior > > - key :: foo | bar > baz > # insert latex-environment with cdlatex > > - key :: foo | bar >

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-11 Thread Rasmus
Nicolas Goaziou writes: > You can get real indentation by indenting a new line first. What about > the following? > > (org-return-indent) Indeed that this the trick. The attached patch seems to work nicely and takes care of the corner cases I could think of. I now get the following (desira

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-10 Thread Nicolas Goaziou
Hello, Rasmus writes: > Cdlatex environment inserted via org-cdlatex-environment-indent are pretty > bad at getting the right indention. Consider: > > - concept :: a long description of concept | > > Where | is cursor. When I call org-cdlatex-environment-indent, I expect > > - concept

Re: [O] [patch] better(?) indention for cdlatex-environment

2015-02-10 Thread Rasmus
Rasmus writes: > Hi, > > Cdlatex environment inserted via org-cdlatex-environment-indent are pretty > bad at getting the right indention. Consider: > > - concept :: a long description of concept | > > Where | is cursor. When I call org-cdlatex-environment-indent, I expect > > - concept