Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

After you two's discussion, I have some understanding about lexical scope and dynamic scope. I will add lexical binding if my code use it. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hi Nicolas, I'm all for lexical-binding, and it's good to have it in Org's core. The author of ob-sclang.el used "2011-2017" for the copyright years, which was obviously a typo and tells that the header was simply copied from another file (which is 100% fine btw). >From that, I inferred that the

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

On Mon, Jun 19, 2017, 5:21 AM Nicolas Goaziou wrote: > There is absolutely no drawback in using lexical binding. Since Org > 9.0, it _is_ the default for Org core: almost every Org library > activates it nowadays. > > Again, lexical binding has _no_ drawback and makes life of developers > e

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hello, Bastien Guerry writes: > Maybe I miss something: when I create a file with C-x C-f whatever.el RET > it does not use a template or does not get created with lexical > binding on. > What are you referring to when you say "every Elisp file created > activates it"? It requires to activate `

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hi Nicolas, Nicolas Goaziou writes: > There is absolutely no drawback in using lexical binding. Since Emacs > 24.1, it _is_ the default for Elisp: every Elisp file created activates > it, the other binding being for compatibility with older libraries. Maybe I miss something: when I create a fil

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Bastien Guerry writes: > I agree it's good to have lexical scoping, but I don't consider Elisp > to be lexical scopped -- I consider Elisp to let the user pick up the > constraints he wants, with dynamic binding still being the default. Not at all. Lexical binding is still the way to go. If you

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hi Nicolas, Nicolas Goaziou writes: > Bastien Guerry writes: > >> Still: when it is not used, why adding it? > > We are not adding it since it is in the file by default; you removed > it :) I guess it is in the file by default because the odds are good that lexical scoping will be actually use

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hello, Bastien Guerry writes: > Still: when it is not used, why adding it? We are not adding it since it is in the file by default; you removed it :) This is an odd question, however. The thing is: how is Emacs-lisp scoping, dynamic or lexical? We ought not consider it to be both throughout th

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hi Nicolas, Nicolas Goaziou writes: > I'm not sure to understand commit > a023d670eceb9121ef6a511b108fd82265e6d6a8. In particular, why did > you remove lexical binding? It really should be active in every > library, and is the default when you create a new one. I didn't know lexical binding wa

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hello, Bastien Guerry writes: > Applied, thanks! I'm not sure to understand commit a023d670eceb9121ef6a511b108fd82265e6d6a8. In particular, why did you remove lexical binding? It really should be active in every library, and is the default when you create a new one. Regards, -- Nicolas Goazi

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

I see, thanks very much. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Sat, Jun 17, 2017 at 8:46 PM, Bastien Guerry

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

"numbch...@gmail.com" writes: > Did my SSH public key add to org-mode repository? Now yes. You first need to pull org-mode again like this: ~$ git clone orgm...@orgmode.org:org-mode.git Then you will be able to push commits. Do not commit changes outside of the contrib/ repository. If you h

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Did my SSH public key add to org-mode repository? After added, if I want to update my `ob-sclang.el`. Command `git push upstream` (upstream: git://orgmode.org/org-mode.git) will allow my access? [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twit

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Applied, thanks! -- Bastien

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

I regenerated commit and patch by following changelog formats. ``` >From 9f0b5051bda5ae458242e37923ad18e3189663d9 Mon Sep 17 00:00:00 2001 From: stardiviner Date: Thu, 8 Jun 2017 18:24:53 +0800 Subject: [PATCH] ob-sclang.el: add ob-sclang for sclang Org-mode babel support * ob-sclang.el (org-bab

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

"numbch...@gmail.com" writes: > Here is the patch The patch needs to have a proper changelog. You can read http://orgmode.org/worg/org-contribute.html#patches carefully for details. Thanks! -- Bastien

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

I have resend it to your privately in email attachment. Thanks. [stardiviner] GPG key ID: 47C32433 IRC(freeenode): stardiviner Twitter: @numbchild Key fingerprint = 9BAA 92BC CDDD B9EF 3B36 CB99 B8C4 B8E5 47C3 2433 Blog: http://stardiviner.github.io/ On Thu,

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Here is the patch #+BEGIN_SRC diff >From 8bea0293ae22046bd4878a0ef9add5acd074bfde Mon Sep 17 00:00:00 2001 From: stardiviner Date: Thu, 8 Jun 2017 18:24:53 +0800 Subject: [PATCH] add ob-sclang for sclang Org-mode babel support --- contrib/lisp/ob-sclang.el | 102

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

"numbch...@gmail.com" writes: > Sorry, update SSH public key: Please resend it as an attachment in a private email. Thanks, -- Bastien

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Sorry, update SSH public key: The previous message ssh public key is generated from command: `ssh-add -L`. This one is from `cat ~/.ssh/id_rsa.pub` ``` ssh-rsa B3NzaC1yc2EDAQABAAABAQDIXnylmZoh1WzQnEx0Cf/bpeqfuXVTLXza2jtRTDNYzIgZpRATsRhnSkdFC+t8bgkt7vTur1PiAzFgXYQKTs5BNYsiMFc3j2dnxLWzRCQfVi7

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

@Bastien my SSH public key is: ``` ssh-rsa B3NzaC1yc2EDAQABAAABAQDIXnylmZoh1WzQnEx0Cf/bpeqfuXVTLXza2jtRTDNYzIgZpRATsRhnSkdFC+t8bgkt7vTur1PiAzFgXYQKTs5BNYsiMFc3j2dnxLWzRCQfVi7DhPJ/VfgyyL4tv3LkMbx7vzOUlRJrIRWsnnxiY31rx5xaJbKiF8t9GEz5ycqgW3D5lp60TE/sYCcSTlhRvenJYTcFr1+KFFIGPps5yMayyIZQgEumqln7

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hi, if you need commit access to org-mode to add code to contrib/, please send me your public key (the one in ~/.ssh/id...). Best, -- Bastien

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hello, "numbch...@gmail.com" writes: > Yeah, I have used to contrib to org-mode, but need to sign FSF papers spend > my time, and I don't know how. See , in particular "Copyright issues when contributing to Emacs Org mode". > So I decide to move cod

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Yeah, I have used to contrib to org-mode, but need to sign FSF papers spend my time, and I don't know how. So I decide to move code in `contrib/`. When I back home, I will try to sign FSF papers, because I have time and fixed location. If I move code into `contrib/`, do I need to do more in this co

Re: [O] Add ob-sclang.el for sclang Org-mode babel support in contrib/

Hello, "numbch...@gmail.com" writes: > Here is my branch > https://github.com/stardiviner/org-mode/tree/feature/ob-sclang > Merge this branch? Thank you for your work. I'd like to refrain more packages to contrib, unless the intent is to eventually merge them into core later. However, I think