Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-22 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Bastien writes: > Hi all, > > in future releases of Org, we will move toward stricter rules on what > to accept as ob-* libraries and what modes these libraries should rely > upon. > > This was briefly mentioned in this email: >

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-20 Thread Bastien
Hi Jack, Jack Kamm writes: > I think this is more or less the case today, and we're on the same page > here. Just wanted to make this goal explicit. OK, thanks for the precision! -- Bastien

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-20 Thread Jack Kamm
Hi, Bastien writes: > Also, for included ob-*, the idea would be to use the mode that are > bundled with Emacs core. For Python, it would mean that ob-python.el > should support python.el, not python-mode.el. I agree that ob-python.el should only rely on functionality from python.el, and

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-20 Thread Bastien
Hi all, in future releases of Org, we will move toward stricter rules on what to accept as ob-* libraries and what modes these libraries should rely upon. This was briefly mentioned in this email: https://lists.gnu.org/archive/html/emacs-orgmode/2020-02/msg00714.html For example, we can have a

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-20 Thread Andreas Röhler
, On 20.02.20 06:45, stardiviner wrote: Hi, python-mode.el developer here. Since python.el is built-in to Emacs, I think that things should continue to work for python-mode.el users, even if we entirely switch over to only using python.el. Thanks supporting python-mode.el. Both python-modes

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-19 Thread stardiviner
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Jack Kamm writes: > Hi stardiviner, > > "numbch...@gmail.com" writes: > >> Yes, Jack, as Bastien said, you can format my commit, because my home >> network is broken, I'm using Mobile Phone's 4G network to get online. Can't >> get update

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-19 Thread Bastien
Hi Jack, Jack Kamm writes: > I'll add a TODO for myself to explicitly mark python-mode-related > variables as deprecated. I'm also planning a major update to the Worg > documentation of ob-python when 9.4 comes out, and will mention the > deprecation there as well. Worg needs more love -

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-19 Thread Jack Kamm
Hi stardiviner, "numbch...@gmail.com" writes: > Yes, Jack, as Bastien said, you can format my commit, because my home > network is broken, I'm using Mobile Phone's 4G network to get online. Can't > get update immediately. OK, I've edited the commit message of your patch, and I also fixed the

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-18 Thread numbch...@gmail.com
Yes, Jack, as Bastien said, you can format my commit, because my home network is broken, I'm using Mobile Phone's 4G network to get online. Can't get update immediately. And thanks for tips about `python-mode' is deprecated. I didn't know that. I will migrate to `python.el'. [stardiviner]

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-18 Thread Bastien
Hi Jack, Jack Kamm writes: > Unless it is standard to take the subject line as the > commit message? Yes, it is - although in stardiviner's patch, the subject line should not have the asterisk. You can check for the propre format of a patch by doing ~$ git format-patch HEAD~10 and read the

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-18 Thread Jack Kamm
Hi stardiviner, Sorry for the noise, I have some additional comments below: When I run "make compile", I get the following message: In org-babel-python-initiate-session-by-key: ob-python.el:211:12:Warning: py-shell called with 9 arguments, but accepts only 0-1 I think this is because the

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-18 Thread Jack Kamm
Hi stardiviner, > This minor patch should fixed ~py-shell~ initiate Python session issue. It looks like this patch only affects users of python-mode.el. Since I don't use python-mode.el, I cannot test it. But the patch looks fine. Please add a commit message and changelog entry, and I'll merge

Re: [PATCH] Fix ob-python.el initiate session error with py-shell

2020-02-18 Thread Bastien
Hi Stardiviner, I add Jack to the loop, as he's deciding for these patches. Jack: feel free to go ahead with committing, the release of 9.4 is not yet planned (I'll write to the list when it is.) Thanks! stardiviner writes: > When I have a python src block like this: > > #+begin_src python