Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-14 Thread Ihor Radchenko
"Christopher M. Miles" writes: >>> #+begin_src emacs-lisp >>> (let ((bound-tags (seq-filter 'cdr temp-fulltable))) >>> (if (length> bound-tags 0) >>> bound-tags >>> (seq-take temp-fulltable 26))) >>> #+end_src >> >> This will unconditionally drop auto-labeled tags when user-bound

Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-14 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> Sorry, wrong code, here is the correct code snippet: >> >> #+begin_src emacs-lisp >> (let ((bound-tags (seq-filter 'cdr temp-fulltable))) >> (if (length> bound-tags 0) >> bound-tags >> (seq-take temp-fulltable 26))) >>

Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-14 Thread Ihor Radchenko
"Christopher M. Miles" writes: > Sorry, wrong code, here is the correct code snippet: > > #+begin_src emacs-lisp > (let ((bound-tags (seq-filter 'cdr temp-fulltable))) > (if (length> bound-tags 0) > bound-tags > (seq-take temp-fulltable 26))) > #+end_src This will unconditionally

Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-14 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >> What about like this? >> >> #+begin_src emacs-lisp >> (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable))) >> (if (length> shortkeys 0) >> bound-tags >> (seq-take

Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-14 Thread Ihor Radchenko
"Christopher M. Miles" writes: > What about like this? > > #+begin_src emacs-lisp > (setq tbl (let ((bound-tags (seq-filter 'cdr fulltable))) > (if (length> shortkeys 0) > bound-tags > (seq-take fulltable 26))) >

Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-13 Thread Christopher M. Miles
Ihor Radchenko writes: > "Christopher M. Miles" writes: > >>> It would be great if you can come up with a patch. >>> 1. Keeping tags with explicitly assigned key binding indeed makes sense >>> 2. If we limit the number of displayed tags (on top of explicitly >>>assigned), it should be a

Re: [PATCH] Re: Improve the performance of `org-set-tags-command` on large `org-tag-alist`

2023-05-13 Thread Ihor Radchenko
"Christopher M. Miles" writes: >> It would be great if you can come up with a patch. >> 1. Keeping tags with explicitly assigned key binding indeed makes sense >> 2. If we limit the number of displayed tags (on top of explicitly >>assigned), it should be a defcustom. > > Here is the patch. >