Re: [RFC] Refactoring org-element API (was: [DISCUSSION] Refactoring fontification system)

[Ihor Radchenko]

Ihor Radchenko  writes:

> In order not to turn org-element into another org-agenda, I am proposing
> to factor out Org syntax tree API into a separate file
> org-element-ast.el and add a number of breaking changes how the syntax
> tree is structured.

Applied, onto main.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [RFC] Refactoring org-element API

[Ihor Radchenko]

Ihor Radchenko  writes:

>>> One minor nitpick: I would prefer a function like
>>> ~org-element-property-1~ to be named e.g. ~org-element-property-lazy~
>>> (or something similar), because the "-1" is just obfuscation to me.
>> ...
>> I'd prefer to see several more ideas about the alternative names, if
>> possible.
>
> What about org-element-property-raw?

Now renamed to `org-element-property-raw'.

Since one month have passed and no major concerns have been raised, I
plan to push the branch onto main tomorrow.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [RFC] Refactoring org-element API

[Ihor Radchenko]

Ihor Radchenko  writes:

>> One minor nitpick: I would prefer a function like
>> ~org-element-property-1~ to be named e.g. ~org-element-property-lazy~
>> (or something similar), because the "-1" is just obfuscation to me.
> ...
> I'd prefer to see several more ideas about the alternative names, if
> possible.

What about org-element-property-raw?

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [RFC] Refactoring org-element API

[Ihor Radchenko]

Stefan Nobis  writes:

> One minor nitpick: I would prefer a function like
> ~org-element-property-1~ to be named e.g. ~org-element-property-lazy~
> (or something similar), because the "-1" is just obfuscation to me.

foo-...-1 is actually frequently used in Emacs code for semi-internal
helper functions.

I do not mind alternative name, although I feel that
~org-element-property-lazy~ is not very descriptive.
I'd prefer to see several more ideas about the alternative names, if
possible.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at 

Re: [RFC] Refactoring org-element API

[Stefan Nobis]

Hi Ihor,

thank you for all your great work. I did not dive deep into all the
details, but the overview you provided sounds sensible.

One minor nitpick: I would prefer a function like
~org-element-property-1~ to be named e.g. ~org-element-property-lazy~
(or something similar), because the "-1" is just obfuscation to me.

--
Until the next mail...,
Stefan.

Re: [RFC] Refactoring org-element API (was: [DISCUSSION] Refactoring fontification system)

[Ihor Radchenko]

Hi,

Heads up to org-ml developers as the discussed change is very likely to
break org-ml (https://github.com/ndwarshuis/org-ml).

See https://list.orgmode.org/874jnudps5.fsf@localhost/T/#u

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at .
Support Org development at ,
or support my work at