Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-26 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > Hopefully all remarks addressed.. > Best, /PA Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=f124b616d -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at .

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-24 Thread Pedro Andres Aranda Gutierrez
Hopefully all remarks addressed.. Best, /PA On Wed, 24 Apr 2024 at 19:05, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > > > Oops, you are right. My local copy got a bit messed up. > > > > Here is a hopefully clean patch. I have tried it out on a local > test-patch > > branch

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-24 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > Oops, you are right. My local copy got a bit messed up. > > Here is a hopefully clean patch. I have tried it out on a local test-patch > branch of current main and it applied. Thanks! May you also add NEWS entry? Also, a few comments inline. > Subject:

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-22 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: >> What about something like >> >> #+cite_export: biblatex backend=bibtex,bibstyle=numeric >> > Just tested on a work document. It generates > \usepackage[backend=bibtex,bibstyle=numeric]{biblatex} > which is a perfectly valid options string for biblatex and

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-21 Thread Pedro Andres Aranda Gutierrez
Hi Ihor, On Sun, 21 Apr 2024 at 15:20, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > > > +: #+cite_export: biblatex backend=bibtex,style=numeric > > What about something like > > #+cite_export: biblatex backend=bibtex,bibstyle=numeric > Just tested on a work document. It

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-21 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > +: #+cite_export: biblatex backend=bibtex,style=numeric What about something like #+cite_export: biblatex backend=bibtex,bibstyle=numeric > BTW, I was thinking that maybe "\\`[^=]+=" may be better than matching > style= anywhere in the options string...

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-17 Thread Pedro Andres Aranda Gutierrez
BTW, I was thinking that maybe "\\`[^=]+=" may be better than matching style= anywhere in the options string... Open to discuss it... /PA On Wed, 17 Apr 2024 at 09:00, Pedro Andres Aranda Gutierrez < paag...@gmail.com> wrote: > Stop the press... I discovered a small bug in the last patch. >

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-17 Thread Pedro Andres Aranda Gutierrez
Stop the press... I discovered a small bug in the last patch. Attached is a new version. /PA On Wed, 17 Apr 2024 at 08:22, Pedro Andres Aranda Gutierrez < paag...@gmail.com> wrote: > Hi again > > Rationale of the patch: > Currently, when the options to biblatex are _not_ xxx/xxx format, a

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-17 Thread Pedro Andres Aranda Gutierrez
Hi again Rationale of the patch: Currently, when the options to biblatex are _not_ xxx/xxx format, a style= is prepended, because it is assumed that it will be a biblatex options string starting with a style. With the proposed patch, I add the possibility of using a biblatex options string where

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-14 Thread Pedro Andres Aranda Gutierrez
HI, full answer... In the original code, that section prepends "style=" in some cases. I have stumbled across instances where the options started with style= because they were taken directly from LaTeX and the generated code ended by like: \usepackage[style=style=numeric,backend=biber]{biblatex}

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-13 Thread Pedro Andres Aranda Gutierrez
Sorry... I was not right... You are right. I'll take a look at it again. /PA On Sun, 14 Apr 2024 at 07:22, Pedro Andres Aranda Gutierrez < paag...@gmail.com> wrote: > Hi, > > Maybe not... because style= is a keyword for the biblatex package, while > bibstyle or citestyle aren't. > > Best, /PA >

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-13 Thread Pedro Andres Aranda Gutierrez
Hi, Maybe not... because style= is a keyword for the biblatex package, while bibstyle or citestyle aren't. Best, /PA On Sat, 13 Apr 2024 at 16:32, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > > > HI, > > Attached is a small patch to allow explicitly adding style= in the >

Re: PATCH allow explicit style= in #+cite_export: biblatex

2024-04-13 Thread Ihor Radchenko
Pedro Andres Aranda Gutierrez writes: > HI, > Attached is a small patch to allow explicitly adding style= in the biblatex > export options, to increase consistency with > Customisation variables. Thanks! > (style-options > (cond >((null style) nil) > +