Re: tiny patch to ange-ftp

2005-08-09 Thread Katsumi Yamaoka
> In <[EMAIL PROTECTED]> Michael Albinus wrote: > Katsumi Yamaoka <[EMAIL PROTECTED]> writes: >> Recently, I located the causes of the problems and succeeded in >> fixing of them. The patch is below. Could anyone verify it? > I've committed your patch to Emacs CVS. Looks good to me. Than

Re: tiny patch to ange-ftp

2005-08-09 Thread Katsumi Yamaoka
> In <[EMAIL PROTECTED]> Stefan Monnier wrote: >> !;; Concatenate the switches and the target to be used with `ls'. >> !(setq cmd1 (concat "\"" cmd3 " " cmd1 "\"" > This looks wrong to me. NetBSD's ftpd does not accept two arguments to the > LS command, last I tried. Concatenati

Re: Sorting in custom-set-variables doesn't work for minor modes

2005-08-09 Thread Stefan Monnier
> A possible solution is given in the patch below. It uses the same reasoning > as used in the patch for autoload.el by Stefan Monnier: test for > custom-set-minor-mode as setter function. The patch looks good, except that it should probably not only place custom vars at the end if they have a cus

Re: tiny patch to ange-ftp

2005-08-09 Thread Stefan Monnier
> *** > *** 2328,2335 > ;; We cd and then use `ls' with no directory argument. > ;; This works around a misfeature of some versions of netbsd ftpd. > (unless (equal cmd1 ".") > ! (setq result (ange-ftp-cd host user (nth 1 cmd) 'noerror))) > ! (setq cmd1

Re: tiny patch to ange-ftp

2005-08-09 Thread Stefan Monnier
>> Recently, I located the causes of the problems and succeeded in >> fixing of them. The patch is below. Could anyone verify it? > I've committed your patch to Emacs CVS. Looks good to me. The first hunk is wrong. Please revert it and replace it with a comment trying to explain the problem s

Re: insert-buffer vs insert-buffer-substring

2005-08-09 Thread Richard M. Stallman
I just fixed a bug in info.el caused by replacing `insert-buffer' with `insert-buffer-substring'. Instead of `(insert-buffer-substring buffer)', Sorry. I didn't see that the change caused a problem. I added the following construct: (goto-char (prog1 (point) (insert-buffer-sub

Re: tiny patch to ange-ftp

2005-08-09 Thread Michael Albinus
Katsumi Yamaoka <[EMAIL PROTECTED]> writes: > Hi, Hi, > Recently, I located the causes of the problems and succeeded in > fixing of them. The patch is below. Could anyone verify it? I've committed your patch to Emacs CVS. Looks good to me. > Thanks in advance. Best regards, Michael.

Sorting in custom-set-variables doesn't work for minor modes (was: Customizing recentf-save-file doesn't work properly)

2005-08-09 Thread Luc Van Eycken
In a previous bug report I wrote: > When customizing both recentf-mode and recentf-save-file, the customized > value of recentf-save-file is not used for loading the list of recent files. > ... options are saved in alpha

insert-buffer vs insert-buffer-substring

2005-08-09 Thread Juri Linkov
`insert-buffer-substring' is not equivalent to `insert-buffer' in regard to the point position after calling these functions. `insert-buffer' leaves point before inserted text, but `insert-buffer-substring' - after it. I just fixed a bug in info.el caused by replacing `insert-buffer' with `insert