On 1 July 2013 05:29, Sebastian Kuzminsky s...@highlab.com wrote:
Thanks for your continued work on this driver. I hope to merge it into
master before the 2.6 release branch is made, and have it be included in
the next official release of LinuxCNC.
I have seen a few comments to the effect
I don't believe it ever was merged.
It is available here...
https://github.com/OKComputers/linuxcnc-mirror/tree/wj200_vfd
If I can help with integration I will. Also a code review and any
suggesstions on things I may be doing wrong would be welcome as well. It
has worked for me well, but I'm
On Thu, May 22, 2014 at 09:31:56AM -0400, Curtis Dutton wrote:
I don't believe it ever was merged.
It is available here...
https://github.com/OKComputers/linuxcnc-mirror/tree/wj200_vfd
I rebased this onto 2.6 and pushed it for the buildbot to chew on,
so we should know in an hour or two
On 05/22/2014 07:31 AM, Curtis Dutton wrote:
I don't believe it ever was merged.
It is available here...
https://github.com/OKComputers/linuxcnc-mirror/tree/wj200_vfd
Looks like the code review issues i raised last time we talked about
this driver have been addressed, that's great. It looks
Ok so I think this code is well enough tested, and the comp files also
includes the documentation.
What do I need to do to get this integrated into the codebase.
I have a branch on github with my changes. I can provide a patch if
necessary. https://github.com/OKComputers/linuxcnc
Thanks,
On 06/30/2013 07:45 PM, Curtis Dutton wrote:
Ok so I think this code is well enough tested, and the comp files also
includes the documentation.
What do I need to do to get this integrated into the codebase.
I have a branch on github with my changes. I can provide a patch if
necessary.
If you need help on the man page or adding this to the Integrators
Manual just let me know.
JT
On 5/20/2013 8:50 PM, Curtis Dutton wrote:
Ok I have the driver pretty much completed and it has been working well for
a week now. It can now take command line arguments to control the modbus
On 21 May 2013 02:50, Curtis Dutton curtd...@gmail.com wrote:
Now I'd like to add a manpage for the driver and any other documentation
where appropriate. I need some guidance on what documentation to add and
where to add it.
If (as the thread title suggests) the driver is written in comp then
On 05/21/2013 03:14 AM, andy pugh wrote:
On 21 May 2013 02:50, Curtis Dutton curtd...@gmail.com wrote:
Now I'd like to add a manpage for the driver and any other documentation
where appropriate. I need some guidance on what documentation to add and
where to add it.
If (as the thread title
On 05/20/2013 07:50 PM, Curtis Dutton wrote:
Ok I have the driver pretty much completed and it has been working well for
a week now. It can now take command line arguments to control the modbus
serial connection parameters.
Great!
Now I'd like to add a manpage for the driver and any other
I plan on using the userinit section for parsing command line options. This
is where I plan to allow users to specify modbus connection parameters. Is
that the preferred way to configure the driver?
I did not intend to check in wj200_vfd.c. I looked at my repository on
github, and it doesn't
On 15 May 2013 04:20, Sebastian Kuzminsky s...@highlab.com wrote:
The only comp that sets 'option userinit yes' is bldc, but it doesnt set
'option userspace yes', so comp doesn't try to call it.
Which means that I messed up with bldc then.
I will remove that line later (and check that
On 05/15/2013 04:27 AM, andy pugh wrote:
On 15 May 2013 04:20, Sebastian Kuzminsky s...@highlab.com wrote:
The only comp that sets 'option userinit yes' is bldc, but it doesnt set
'option userspace yes', so comp doesn't try to call it.
Which means that I messed up with bldc then.
I will
Ok I have integrated the wj200_vfd driver into linuxcnc
src/hal/user_comps/wj200_vfd
The repository is available at https://github.com/OKComputers/linuxcnc
I have not yet completed the driver, I need to add command line option
parsing to set the modbus communication parameters. However I have
Curtis Dutton curtd...@gmail.com wrote:
Ok I have integrated the wj200_vfd driver into linuxcnc
src/hal/user_comps/wj200_vfd
The repository is available at https://github.com/OKComputers/linuxcnc
Great, i'll review it later today.
During my work, I discovered a bug in the comp.py program.
On 05/14/2013 08:51 AM, Sebastian Kuzminsky wrote:
Curtis Dutton curtd...@gmail.com wrote:
Ok I have integrated the wj200_vfd driver into linuxcnc
src/hal/user_comps/wj200_vfd
The repository is available at https://github.com/OKComputers/linuxcnc
Great, i'll review it later today.
Looks
Thanks for the feedback. Very useful!
I will handle integrating this into the linuxcnc source tree after I get
things cleaned up, tested, and get the code production worthy. I'll also
move all of the code into the comp file as suggested by Sebastian.
As far as capturing output, I'll just write
Am 08.05.2013 um 17:09 schrieb Curtis Dutton curtd...@gmail.com:
As far as capturing output, I'll just write any errors encountered to
stderr. That is perfectly fine as far as I'm concerned. I just had a hard
time finding out where the linuxcnc logs were located. I couldn't find them
in the
The architecture of the future logging systems sounds nice.
Are there any pointers on how to integrate my .comp file into the Makefile
system? Even examples elsewhere in the source tree would be useful.
On Wed, May 8, 2013 at 4:56 PM, Michael Haberler mai...@mah.priv.at wrote:
Am
On Wed, May 08, 2013 at 06:46:21PM -0400, Curtis Dutton wrote:
The architecture of the future logging systems sounds nice.
Are there any pointers on how to integrate my .comp file into the Makefile
system? Even examples elsewhere in the source tree would be useful.
To build and package a
On May 8, 2013, at 16:46 , Curtis Dutton wrote:
Are there any pointers on how to integrate my .comp file into the Makefile
system? Even examples elsewhere in the source tree would be useful.
You just put your .comp in src/hal/components. Add a test if you're feeling
frisky.
Check out commit
Am 07.05.2013 um 16:43 schrieb Curtis Dutton curtd...@gmail.com:
I have a preliminary WJ200 modbus inverter driver that I've written, based
upon other modbus drivers I have seen from the VFD wiki page.
The source code so far is posted at https://github.com/OKComputers/wj200vfd
How do I
22 matches
Mail list logo
