Re: _main no longer called?
Sure, I filed an issue at https://github.com/kripken/emscripten/issues/6581. Thanks, David On Tuesday, May 22, 2018 at 12:35:01 PM UTC-7, Alon Zakai wrote: > > Can you please file an issue with a testcase for those spaces that you > mention? That sounds like a bug we should fix (possibly related to the > recent commandline parsing changes). > > - Alon > > > On Tue, May 22, 2018 at 10:34 AM, > > wrote: > >> Thanks Alon. >> >> I ran into some additional issues with spaces in >> EXTRA_EXPORTED_RUNTIME_METHODS which didn't cause emcc to error, but did >> cause it to ignore subsequent entries. However now that those are fixed >> everything seems to be working as expected. >> >> Thanks, >> >> David >> >> On Friday, May 18, 2018 at 4:22:34 PM UTC-7, Alon Zakai wrote: >>> >>> We did stop exporting those things by default, so probably it's that. See >>> >>> >>> http://kripken.github.io/emscripten-site/docs/getting_started/FAQ.html#why-do-i-get-typeerror-module-something-is-not-a-function >>> >>> (and the changelog). >>> >>> If that doesn't fix it, please file an issue with a testcase, it could >>> be an unknown bug somehow. >>> >>> On Fri, May 18, 2018 at 4:06 PM, wrote: >>> Thanks, that fixed my initial problem. I am now encountering methods that are no longer exported. In particular Runtime which contains stackSave, stackRestore and addFunction is undefined. I tried to add it to EXTRA_EXPORTED_RUNTIME_METHODS in multiple ways with no success. What is the recommended way to export Runtime.stackSave, Runtime.stackRestore and Runtime.addFunction or did they change as well? Thanks, David On Thursday, May 17, 2018 at 7:11:57 PM UTC-7, Alon Zakai wrote: > > One possible issue is that a while ago (a few months I think) we > started to depend on static detection of main(). The reason is that > knowing > if it's present statically at compile time lets us optimize better, and > also it overlaps with the onRuntimeInitialized JS callback which does > basically the same thing as adding a main in JS, that is, get called when > compiled code is all ready to run. > > Does changing from _main to onRuntimeInitialized fix things for you? > If so then it's probably that. > > > On Thu, May 17, 2018 at 6:59 PM, wrote: > >> I updated the latest incoming a couple of days ago and noticed that >> _main is no longer called in the generated .js file. (Currently testing >> Wasm) Is this intended? >> >> In my code I define _main manually in JavaScript. >> >> Thanks, >> >> David >> >> -- >> > > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout. >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to emscripten-discuss+unsubscr...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: _main no longer called?
Can you please file an issue with a testcase for those spaces that you mention? That sounds like a bug we should fix (possibly related to the recent commandline parsing changes). - Alon On Tue, May 22, 2018 at 10:34 AM, wrote: > Thanks Alon. > > I ran into some additional issues with spaces in > EXTRA_EXPORTED_RUNTIME_METHODS which didn't cause emcc to error, but did > cause it to ignore subsequent entries. However now that those are fixed > everything seems to be working as expected. > > Thanks, > > David > > On Friday, May 18, 2018 at 4:22:34 PM UTC-7, Alon Zakai wrote: >> >> We did stop exporting those things by default, so probably it's that. See >> >> http://kripken.github.io/emscripten-site/docs/getting_starte >> d/FAQ.html#why-do-i-get-typeerror-module-something-is-not-a-function >> >> (and the changelog). >> >> If that doesn't fix it, please file an issue with a testcase, it could be >> an unknown bug somehow. >> >> On Fri, May 18, 2018 at 4:06 PM, wrote: >> >>> Thanks, that fixed my initial problem. >>> >>> I am now encountering methods that are no longer exported. In particular >>> Runtime which contains stackSave, stackRestore and addFunction is >>> undefined. I tried to add it to EXTRA_EXPORTED_RUNTIME_METHODS in multiple >>> ways with no success. What is the recommended way to export >>> Runtime.stackSave, Runtime.stackRestore and Runtime.addFunction or did they >>> change as well? >>> >>> Thanks, >>> >>> David >>> >>> On Thursday, May 17, 2018 at 7:11:57 PM UTC-7, Alon Zakai wrote: One possible issue is that a while ago (a few months I think) we started to depend on static detection of main(). The reason is that knowing if it's present statically at compile time lets us optimize better, and also it overlaps with the onRuntimeInitialized JS callback which does basically the same thing as adding a main in JS, that is, get called when compiled code is all ready to run. Does changing from _main to onRuntimeInitialized fix things for you? If so then it's probably that. On Thu, May 17, 2018 at 6:59 PM, wrote: > I updated the latest incoming a couple of days ago and noticed that > _main is no longer called in the generated .js file. (Currently testing > Wasm) Is this intended? > > In my code I define _main manually in JavaScript. > > Thanks, > > David > > -- > -- >>> You received this message because you are subscribed to the Google >>> Groups "emscripten-discuss" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to emscripten-discuss+unsubscr...@googlegroups.com. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to emscripten-discuss+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: _main no longer called?
Thanks Alon. I ran into some additional issues with spaces in EXTRA_EXPORTED_RUNTIME_METHODS which didn't cause emcc to error, but did cause it to ignore subsequent entries. However now that those are fixed everything seems to be working as expected. Thanks, David On Friday, May 18, 2018 at 4:22:34 PM UTC-7, Alon Zakai wrote: > > We did stop exporting those things by default, so probably it's that. See > > > http://kripken.github.io/emscripten-site/docs/getting_started/FAQ.html#why-do-i-get-typeerror-module-something-is-not-a-function > > (and the changelog). > > If that doesn't fix it, please file an issue with a testcase, it could be > an unknown bug somehow. > > On Fri, May 18, 2018 at 4:06 PM, > wrote: > >> Thanks, that fixed my initial problem. >> >> I am now encountering methods that are no longer exported. In particular >> Runtime which contains stackSave, stackRestore and addFunction is >> undefined. I tried to add it to EXTRA_EXPORTED_RUNTIME_METHODS in multiple >> ways with no success. What is the recommended way to export >> Runtime.stackSave, Runtime.stackRestore and Runtime.addFunction or did they >> change as well? >> >> Thanks, >> >> David >> >> On Thursday, May 17, 2018 at 7:11:57 PM UTC-7, Alon Zakai wrote: >>> >>> One possible issue is that a while ago (a few months I think) we started >>> to depend on static detection of main(). The reason is that knowing if it's >>> present statically at compile time lets us optimize better, and also it >>> overlaps with the onRuntimeInitialized JS callback which does basically the >>> same thing as adding a main in JS, that is, get called when compiled code >>> is all ready to run. >>> >>> Does changing from _main to onRuntimeInitialized fix things for you? If >>> so then it's probably that. >>> >>> >>> On Thu, May 17, 2018 at 6:59 PM, wrote: >>> I updated the latest incoming a couple of days ago and noticed that _main is no longer called in the generated .js file. (Currently testing Wasm) Is this intended? In my code I define _main manually in JavaScript. Thanks, David -- >>> >>> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to emscripten-discuss+unsubscr...@googlegroups.com . >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: _main no longer called?
We did stop exporting those things by default, so probably it's that. See http://kripken.github.io/emscripten-site/docs/getting_started/FAQ.html#why-do-i-get-typeerror-module-something-is-not-a-function (and the changelog). If that doesn't fix it, please file an issue with a testcase, it could be an unknown bug somehow. On Fri, May 18, 2018 at 4:06 PM, wrote: > Thanks, that fixed my initial problem. > > I am now encountering methods that are no longer exported. In particular > Runtime which contains stackSave, stackRestore and addFunction is > undefined. I tried to add it to EXTRA_EXPORTED_RUNTIME_METHODS in multiple > ways with no success. What is the recommended way to export > Runtime.stackSave, Runtime.stackRestore and Runtime.addFunction or did they > change as well? > > Thanks, > > David > > On Thursday, May 17, 2018 at 7:11:57 PM UTC-7, Alon Zakai wrote: >> >> One possible issue is that a while ago (a few months I think) we started >> to depend on static detection of main(). The reason is that knowing if it's >> present statically at compile time lets us optimize better, and also it >> overlaps with the onRuntimeInitialized JS callback which does basically the >> same thing as adding a main in JS, that is, get called when compiled code >> is all ready to run. >> >> Does changing from _main to onRuntimeInitialized fix things for you? If >> so then it's probably that. >> >> >> On Thu, May 17, 2018 at 6:59 PM, wrote: >> >>> I updated the latest incoming a couple of days ago and noticed that >>> _main is no longer called in the generated .js file. (Currently testing >>> Wasm) Is this intended? >>> >>> In my code I define _main manually in JavaScript. >>> >>> Thanks, >>> >>> David >>> >>> -- >>> >> >> -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to emscripten-discuss+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: _main no longer called?
Thanks, that fixed my initial problem. I am now encountering methods that are no longer exported. In particular Runtime which contains stackSave, stackRestore and addFunction is undefined. I tried to add it to EXTRA_EXPORTED_RUNTIME_METHODS in multiple ways with no success. What is the recommended way to export Runtime.stackSave, Runtime.stackRestore and Runtime.addFunction or did they change as well? Thanks, David On Thursday, May 17, 2018 at 7:11:57 PM UTC-7, Alon Zakai wrote: > > One possible issue is that a while ago (a few months I think) we started > to depend on static detection of main(). The reason is that knowing if it's > present statically at compile time lets us optimize better, and also it > overlaps with the onRuntimeInitialized JS callback which does basically the > same thing as adding a main in JS, that is, get called when compiled code > is all ready to run. > > Does changing from _main to onRuntimeInitialized fix things for you? If so > then it's probably that. > > > On Thu, May 17, 2018 at 6:59 PM, > wrote: > >> I updated the latest incoming a couple of days ago and noticed that _main >> is no longer called in the generated .js file. (Currently testing Wasm) Is >> this intended? >> >> In my code I define _main manually in JavaScript. >> >> Thanks, >> >> David >> >> -- >> > > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: _main no longer called?
One possible issue is that a while ago (a few months I think) we started to depend on static detection of main(). The reason is that knowing if it's present statically at compile time lets us optimize better, and also it overlaps with the onRuntimeInitialized JS callback which does basically the same thing as adding a main in JS, that is, get called when compiled code is all ready to run. Does changing from _main to onRuntimeInitialized fix things for you? If so then it's probably that. On Thu, May 17, 2018 at 6:59 PM, wrote: > I updated the latest incoming a couple of days ago and noticed that _main > is no longer called in the generated .js file. (Currently testing Wasm) Is > this intended? > > In my code I define _main manually in JavaScript. > > Thanks, > > David > > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to emscripten-discuss+unsubscr...@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
_main no longer called?
I updated the latest incoming a couple of days ago and noticed that _main is no longer called in the generated .js file. (Currently testing Wasm) Is this intended? In my code I define _main manually in JavaScript. Thanks, David -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to emscripten-discuss+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
