Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VmStaticDAODbFacadeImpl
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4222
To unsubscribe, visit
Doron Fediuck has posted comments on this change.
Change subject: core: Remove pubkey2ssh
..
Patch Set 14: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3138
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: WIP: Introducing MockConfigRule
..
Patch Set 1: (1 inline comment)
File
Omer Frenkel has posted comments on this change.
Change subject: core: license usage cleanup
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4115
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Introducing MockConfigRule
..
Patch Set 3: Verified
Moved test-jar generation to the root pom, as per Laszlo's review.
--
To view, visit
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Removing deprecated commands
..
webadmin: Removing deprecated commands
Hiding 'Move VM' and 'Copy Template'
Change-Id:
Doron Fediuck has submitted this change and it was merged.
Change subject: core: Remove pubkey2ssh
..
core: Remove pubkey2ssh
Including this binary forces the Fedora RPM to be architecture
specific instead of noarch. It can be
Omer Frenkel has posted comments on this change.
Change subject: core: Cleanup VmStatic warnings
..
Patch Set 2: (1 inline comment)
File
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Shahar Havivi has posted comments on this change.
Change subject: restapi: add VmPayload support
..
Patch Set 8: Verified
(1 inline comment)
Commit Message
Line 19:
Please
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Move ROOT.war to the EAR
..
Patch Set 4: Looks good to me, but someone else must approve
Reviewed .py, Makefile and .spec changes.
All good.
+1
Shahar Havivi has posted comments on this change.
Change subject: restapi: add VmPayload support
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/3460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] DoubleCompat RefObject removal
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4235
To
Michael Kublin has posted comments on this change.
Change subject: core: Use getAllForVm to filter by allow snapshot
..
Patch Set 2: (3 inline comments)
File
Maor Lipchuk has uploaded a new change for review.
Change subject: searchbackend: Add search for shared and snapshotable
..
searchbackend: Add search for shared and snapshotable
Adding allow snaoshot field and shareable fields
Itamar Heim has posted comments on this change.
Change subject: core: Changing oVirt Enterprise Virtualization Engine to oVirt
Engine
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1641
Michael Kublin has posted comments on this change.
Change subject: core: Use getAllForVm to filter by allow snapshot
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Project: http://jenkins.ovirt.org/job/ovirt_engine/
Build: http://jenkins.ovirt.org/job/ovirt_engine/1091/
Build Number: 1091
Build Status: Failure
Triggered By: Started by an SCM change
-
Changes Since Last Success:
-
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/602/
Build Number: 602
Build Status: Failure
Triggered By: Started by upstream project ovirt_engine build number 1,090
-
Changes Since
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/833/
Build Number: 833
Build Status: Failure
Triggered By: Started by upstream project ovirt_engine build number 1,090
-
Changes
Roy Golan has abandoned this change.
Change subject: engine-config: support setting a password from file or ask
interacively
..
Patch Set 1: Abandoned
--
To view, visit http://gerrit.ovirt.org/86
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: rest: Add comment for potential bug
..
Patch Set 3: (1 inline comment)
File
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] remove Refobject from MacPoolManager
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] RefreshPoolSingleAsyncOperation
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4237
To
Ori Liel has posted comments on this change.
Change subject: restapi: add VmPayload support
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3460
To unsubscribe, visit
Ori Liel has submitted this change and it was merged.
Change subject: restapi: add VmPayload support
..
restapi: add VmPayload support
vm
...
payloads
payload type='cdrom'
file name='my.txt'
Yair Zaslavsky has posted comments on this change.
Change subject: core: [rmd] RefreshPoolSingleAsyncOperation
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4237
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: [rmd] removed RefObject from GuidUtils
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Maor Lipchuk has posted comments on this change.
Change subject: core: Use getAllForVm to filter by allow snapshot
..
Patch Set 3: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: core: Use allow snapshot when Adding a disk to VM.
..
Patch Set 3: (5 inline comments)
File
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup of DiskImageDaoWrapper
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4228
To
Jaroslav Henner has abandoned this change.
Change subject: backend,frontend: Remove TimeLeapseVmPool.
..
Patch Set 4: Abandoned
I have no time to fix this right now.
--
To view, visit http://gerrit.ovirt.org/965
To
Maor Lipchuk has posted comments on this change.
Change subject: rest: Add comment for potential bug
..
Patch Set 3: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: core: Use allow snapshot attribute on disk update.
..
Patch Set 3: (5 inline comments)
File
Yair Zaslavsky has abandoned this change.
Change subject: DO NOT SUBMIT core: refactor AbstractQueryTest
..
Patch Set 2: Abandoned
Not needed anymore
--
To view, visit http://gerrit.ovirt.org/2290
To unsubscribe, visit
Yair Zaslavsky has abandoned this change.
Change subject: core: Fixing images_storage_domain_view
..
Patch Set 1: Abandoned
Not needed anymore
--
To view, visit http://gerrit.ovirt.org/2447
To unsubscribe, visit
Yair Zaslavsky has abandoned this change.
Change subject: DO NOT SUBMIT core: DAL - adding exists method to SnapshotDao
..
Patch Set 14: Abandoned
Not needed anymore
--
To view, visit http://gerrit.ovirt.org/2542
To
Yair Zaslavsky has abandoned this change.
Change subject: DO NOT SUBMIT common: CopyImage parameters
..
Patch Set 10: Abandoned
Not needed anymore
--
To view, visit http://gerrit.ovirt.org/2297
To unsubscribe, visit
Yair Zaslavsky has abandoned this change.
Change subject: DO NOT SUBMIT core: Fixing MoveOrCopyImageGroup to support new
param fields
..
Patch Set 5: Abandoned
Not needed anymore
--
To view, visit
Yair Zaslavsky has abandoned this change.
Change subject: core: Removing CreateCloneOfTemplate command
..
Patch Set 7: Abandoned
Not needed anymore
--
To view, visit http://gerrit.ovirt.org/2688
To unsubscribe, visit
Yair Zaslavsky has abandoned this change.
Change subject: core: Fixing values filling in query
..
Patch Set 1: Abandoned
Not needed anymore
--
To view, visit http://gerrit.ovirt.org/2915
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup DiskImageDAO and its test
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
Rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Quota UI fields - DiskImage (819603)
..
Patch Set 4: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4206
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmStatic
..
Patch Set 3: Verified
rebased, implemented ofrenkel's review.
--
To view, visit http://gerrit.ovirt.org/4218
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmTemplate warnings
..
Patch Set 3: Verified
rebased.
--
To view, visit http://gerrit.ovirt.org/4219
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VmStaticDAODbFacadeImpl
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4222
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmStaticDAODbFacadeImpl
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VmTemplate warnings
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4219
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Fix warnings in VmTemplateDAOTest
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4223
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Quota UI fields - VM and VmTemplate (819603)
..
Patch Set 2: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4224
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VmStatic
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4218
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VM warnings
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4217
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: rest: Add comment for potential bug
..
Patch Set 3: (1 inline comment)
File
Alona Kaplan has posted comments on this change.
Change subject: webadmin: change locale location in login screen
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4211
To unsubscribe, visit
Juan Hernandez has abandoned this change.
Change subject: packaging: Replace pubkey2ssh with ssh-keygen
..
Patch Set 2: Abandoned
This has been solved implementing the pubkey2ssh in Java, and it has been
merged. Seek change
Roy Golan has posted comments on this change.
Change subject: core: clean QueriesCommandBase.CreateRetuenValue
..
Patch Set 3: (3 inline comments)
File
Roy Golan has posted comments on this change.
Change subject: core: SearchQuery: remove getSearchReturnValue
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4182
To unsubscribe, visit
Project: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/
Build: http://jenkins.ovirt.org/job/ovirt_engine_gwt_admin/603/
Build Number: 603
Build Status: Fixed
Triggered By: Started by upstream project ovirt_engine build number 1,092
-
Changes Since Last
Michael Kublin has posted comments on this change.
Change subject: core: Introduce allow snapshot attribute for disk
..
Patch Set 2: (1 inline comment)
File
Roy Golan has posted comments on this change.
Change subject: core: AdUsersSearch as a user query
..
Patch Set 3: Looks good to me, approved
(1 inline comment)
Commit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VM warnings
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending submit.
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmStatic
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending submit.
--
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmTemplate warnings
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review - pending
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup VmStaticDAODbFacadeImpl
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2 review -
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup DiskImageDAO and its test
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
rebased - no changes since last +2 review,
Allon Mureinik has posted comments on this change.
Change subject: core: Quota UI fields - VM and VmTemplate (819603)
..
Patch Set 3: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4224
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Quota UI fields - DiskImage (819603)
..
Patch Set 5: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4206
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: Cleanup VM warnings
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4217
To unsubscribe, visit
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Cleanup VM warnings
..
core: Cleanup VM warnings
Addressed issues discovered by Eclipse IDE.
Change-Id:
Omer Frenkel has posted comments on this change.
Change subject: core: Adding can do action messages for shared
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3789
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: core: SearchQuery - refactor ldap searches
..
Patch Set 1: Looks good to me, approved
(2 inline comments)
File
Ori Liel has posted comments on this change.
Change subject: restapi: Basic Quota API Support
..
Patch Set 1: (1 inline comment)
File
Omer Frenkel has posted comments on this change.
Change subject: core: Use shareable disk when creating VM
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4226
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: core: fixing spelling error in luns table column name
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3562
To unsubscribe,
Omer Frenkel has posted comments on this change.
Change subject: core: Introduce allow snapshot attribute for disk
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4227
To unsubscribe, visit
Einav Cohen has uploaded a new change for review.
Change subject: userportal: Added missing message in userportal-gwtp.
..
userportal: Added missing message in userportal-gwtp.
Change-Id:
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Juan Hernandez has posted comments on this change.
Change subject: userportal: Added missing message in userportal-gwtp.
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Ori Liel has posted comments on this change.
Change subject: restapi: Remove Update From User-Role, Group-Role
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2809
To unsubscribe,
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Remove Update From User-Role, Group-Role
..
restapi: Remove Update From User-Role, Group-Role
Change-Id: I91d483cbe8eb9f348fbc39d978be5e1f1c277801
Omer Frenkel has posted comments on this change.
Change subject: core: Quota UI fields - VM and VmTemplate (819603)
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4224
To unsubscribe,
Omer Frenkel has posted comments on this change.
Change subject: core: Cleanup VmStatic
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4218
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: clean QueriesCommandBase.CreateRetuenValue
..
Patch Set 3: (3 inline comments)
File
Allon Mureinik has posted comments on this change.
Change subject: core: AdUsersSearch as a user query
..
Patch Set 3: (1 inline comment)
Commit Message
Line 10: users
Allon Mureinik has posted comments on this change.
Change subject: core: AdGroupsSearch as a user query
..
Patch Set 1: (3 inline comments)
File
Maor Lipchuk has posted comments on this change.
Change subject: core: Use allow snapshot attribute on disk update.
..
Patch Set 3: (5 inline comments)
File
Allon Mureinik has posted comments on this change.
Change subject: core: New base classes for GetAllImageListQuery
..
Patch Set 7: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: New queries to get ISOs by StoragePoolIds
..
Patch Set 7: Verified
rebased only
--
To view, visit http://gerrit.ovirt.org/4148
To unsubscribe, visit
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Shireesh Anjal has posted comments on this change.
Change subject: restapi: Added Gluster entities in REST schema
..
Patch Set 20:
- removed gluster_option and started using the existing option element
- renamed gluster_brick
Maor Lipchuk has posted comments on this change.
Change subject: core: Validate shared disk for export vm/template
..
Patch Set 5: (2 inline comments)
File
Allon Mureinik has posted comments on this change.
Change subject: core: Clean QueriesCommandBase.CreateRetuenValue
..
Patch Set 5: Verified
Addressed rgolan's comments.
--
To view, visit http://gerrit.ovirt.org/4181
To
Allon Mureinik has posted comments on this change.
Change subject: core: SearchQuery: remove getSearchReturnValue
..
Patch Set 5: Verified; Looks good to me, but someone else must approve
rebased, no changes since last +2
Allon Mureinik has posted comments on this change.
Change subject: core: Make LdapSearchQueryTest meaningful
..
Patch Set 5: Verified
rebase only
--
To view, visit http://gerrit.ovirt.org/4183
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: AdUsersSearch as a user query
..
Patch Set 5: Verified
rebased, fixed typo rgolan noticed in last review.
--
To view, visit http://gerrit.ovirt.org/4184
Allon Mureinik has posted comments on this change.
Change subject: core: SearchQuery - refactor ldap searches
..
Patch Set 3: Verified
rebased
--
To view, visit http://gerrit.ovirt.org/4189
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Moved LdapSearchQueryTest out of itest
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/4190
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: AdGroupsSearch as a user query
..
Patch Set 3: Verified
rebased, fixed issues rgolan commented on.
--
To view, visit http://gerrit.ovirt.org/4192
To
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce allow snapshot attribute for disk
..
Patch Set 2: (1 inline comment)
File
Maor Lipchuk has posted comments on this change.
Change subject: rest: Add comment for potential bug
..
Patch Set 3: (1 inline comment)
File
1 - 100 of 440 matches
Mail list logo
