Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread The Rasterman
On Wed, 21 Dec 2016 16:02:50 + Mike Blumenkrantz said: time to butt in i guess... > > Getting the code in shape for correct float comparisons is actually > > something I would like to see. > > > > The real problem here is/was how this was handled. Forcing the

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread The Rasterman
On Wed, 21 Dec 2016 19:38:33 -0200 Gustavo Sverzut Barbieri said: > >> Floating point comparison in C leads to very difficult to diagnose bugs. > >> > >> I'm strongly in favor of turning this warning back on immediately. > > > > Then only where it makes sense please. Even

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Gustavo Sverzut Barbieri
>> Floating point comparison in C leads to very difficult to diagnose bugs. >> >> I'm strongly in favor of turning this warning back on immediately. > > Then only where it makes sense please. Even then, I don't think > forcing the whole community to deal with this is the right approach. > I'm with

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Felipe Magno de Almeida
On Wed, Dec 21, 2016 at 3:02 PM, Derek Foreman wrote: > On 21/12/16 10:45 AM, marcel-hollerb...@t-online.de wrote: >> On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote: [snip] > Are you asking for an explanation of why floating point comparison with > == in

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Stefan Schmidt
Hello. On 21/12/16 18:02, Derek Foreman wrote: > On 21/12/16 10:45 AM, marcel-hollerb...@t-online.de wrote: >> On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote: >>> Hello. >>> >>> On 21/12/16 17:02, Mike Blumenkrantz wrote: On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Cedric BAIL
Hello, On Wed, Dec 21, 2016 at 8:56 AM, Stefan Schmidt wrote: > On 21/12/16 17:46, Christopher Michael wrote: >> On 12/21/2016 11:33 AM, Stefan Schmidt wrote: >>> On 21/12/16 17:02, Mike Blumenkrantz wrote: On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Cedric BAIL
On Wed, Dec 21, 2016 at 9:13 AM, Gustavo Sverzut Barbieri wrote: > On Wed, Dec 21, 2016 at 3:02 PM, Derek Foreman wrote: >> On 21/12/16 10:45 AM, marcel-hollerb...@t-online.de wrote: >>> On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote:

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread marcel-hollerbach
On Wed, Dec 21, 2016 at 11:02:27AM -0600, Derek Foreman wrote: > On 21/12/16 10:45 AM, marcel-hollerb...@t-online.de wrote: > > On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote: > >> Hello. > >> > >> On 21/12/16 17:02, Mike Blumenkrantz wrote: > >>> On Wed, Dec 21, 2016 at 5:11 AM

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Derek Foreman
On 21/12/16 11:13 AM, Gustavo Sverzut Barbieri wrote: > On Wed, Dec 21, 2016 at 3:02 PM, Derek Foreman wrote: >> On 21/12/16 10:45 AM, marcel-hollerb...@t-online.de wrote: >>> On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote: Hello. On 21/12/16

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Gustavo Sverzut Barbieri
On Wed, Dec 21, 2016 at 3:02 PM, Derek Foreman wrote: > On 21/12/16 10:45 AM, marcel-hollerb...@t-online.de wrote: >> On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote: >>> Hello. >>> >>> On 21/12/16 17:02, Mike Blumenkrantz wrote: On Wed, Dec 21, 2016 at

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Derek Foreman
On 21/12/16 10:45 AM, marcel-hollerb...@t-online.de wrote: > On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote: >> Hello. >> >> On 21/12/16 17:02, Mike Blumenkrantz wrote: >>> On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt >>> wrote: >>> Hello

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Christopher Michael
On 12/21/2016 11:56 AM, Stefan Schmidt wrote: > Hello. > > On 21/12/16 17:46, Christopher Michael wrote: >> On 12/21/2016 11:33 AM, Stefan Schmidt wrote: >>> Hello. >>> >>> On 21/12/16 17:02, Mike Blumenkrantz wrote: On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Stefan Schmidt
Hello. On 21/12/16 17:46, Christopher Michael wrote: > On 12/21/2016 11:33 AM, Stefan Schmidt wrote: >> Hello. >> >> On 21/12/16 17:02, Mike Blumenkrantz wrote: >>> On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt >>> wrote: >>> Hello On 20/12/16 17:36, Mike

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Christopher Michael
On 12/21/2016 11:33 AM, Stefan Schmidt wrote: > Hello. > > On 21/12/16 17:02, Mike Blumenkrantz wrote: >> On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt >> wrote: >> >>> Hello >>> >>> On 20/12/16 17:36, Mike Blumenkrantz wrote: I think your "How many real issues have

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread marcel-hollerbach
On Wed, Dec 21, 2016 at 05:33:20PM +0100, Stefan Schmidt wrote: > Hello. > > On 21/12/16 17:02, Mike Blumenkrantz wrote: > > On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt > > wrote: > > > >> Hello > >> > >> On 20/12/16 17:36, Mike Blumenkrantz wrote: > >>> I think your

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Stefan Schmidt
Hello. On 21/12/16 17:02, Mike Blumenkrantz wrote: > On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt > wrote: > >> Hello >> >> On 20/12/16 17:36, Mike Blumenkrantz wrote: >>> I think your "How many real issues have you seen" was the same argument >>> against running any

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Mike Blumenkrantz
On Wed, Dec 21, 2016 at 5:11 AM Stefan Schmidt wrote: > Hello > > On 20/12/16 17:36, Mike Blumenkrantz wrote: > > I think your "How many real issues have you seen" was the same argument > > against running any static analysis a couple years ago; now we have > weekly > >

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-21 Thread Stefan Schmidt
Hello On 20/12/16 17:36, Mike Blumenkrantz wrote: > I think your "How many real issues have you seen" was the same argument > against running any static analysis a couple years ago; now we have weekly > reports for that. > > I have seen bugs that resulted from illegal float comparison. The fact

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-20 Thread Jean-Philippe André
Hi, On 21 December 2016 at 08:06, Cedric BAIL wrote: > On Mon, Dec 19, 2016 at 11:12 PM, Jean-Philippe André > wrote: > > Hey Mike, > > > > On 20 December 2016 at 01:12, Mike Blumenkrantz < > > michael.blumenkra...@gmail.com> wrote: > >> discomfitor

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-20 Thread Cedric BAIL
On Mon, Dec 19, 2016 at 11:12 PM, Jean-Philippe André wrote: > Hey Mike, > > On 20 December 2016 at 01:12, Mike Blumenkrantz < > michael.blumenkra...@gmail.com> wrote: >> discomfitor pushed a commit to branch master. >> >> http://git.enlightenment.org/core/efl.git/commit/?id=

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-20 Thread marcel-hollerbach
Hello, If this makes sense or not is the one thing. But why pushing just the addition of a warning, and not merge a branch where it cleans up all the warnings and adds this flag? I know you were not in Paris this year, but i think we talked about exactly this. And the answer was: Add the compiler

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-20 Thread Mike Blumenkrantz
I think your "How many real issues have you seen" was the same argument against running any static analysis a couple years ago; now we have weekly reports for that. I have seen bugs that resulted from illegal float comparison. The fact that a warning may be a false positive in some or even most

Re: [E-devel] [EGIT] [core/efl] master 01/01: build: enable -Wfloat-equal for compiling

2016-12-19 Thread Jean-Philippe André
Hey Mike, On 20 December 2016 at 01:12, Mike Blumenkrantz < michael.blumenkra...@gmail.com> wrote: > discomfitor pushed a commit to branch master. > > http://git.enlightenment.org/core/efl.git/commit/?id= > 25792d64165ad4f5f647a36f087af2d2206a6618 > > commit