Re: [E-devel] [PATCH] Eina logging domains

2009-08-20 Thread Andre Dieb
This new module doesn't break old code, it doesn't delete eina_error. Also, changing everything is not so easy, as lots of people use EINA_ERROR macros without calling eina_error_init() (that is, we can't just sed the macros as eina_log won't be init'd and it will break everything). As the patch d

Re: [E-devel] [PATCH] Eina logging domains

2009-08-18 Thread Gustavo Sverzut Barbieri
This feels all right, prepare a commit changing other SVN stuff to this new system and mail me so I don't leave svn broken for too long. Ready to commit as soon as you send the patch converting other stuff. Regards, On Sun, Aug 16, 2009 at 9:32 PM, Andre Dieb wrote: > - Added eina_log to Eina.h

Re: [E-devel] [PATCH] Eina logging domains

2009-08-16 Thread Gustavo Sverzut Barbieri
On Sun, Aug 16, 2009 at 8:54 PM, Andre Dieb wrote: > Another attempt attached, see modifications list and inline comments below. > > - DOM is now a prefix: EINA_LOG_DOM_(level) > - renamed EINA_COLOR_NOTHING to EINA_COLOR_RESET > - fixed loop problem at pending domains parse > - removed eina_log_ms

Re: [E-devel] [PATCH] Eina logging domains

2009-08-16 Thread Andre Dieb
- Added eina_log to Eina.h - Removed debug fprintf, do not use eina_safety for (level > d->level) check, it floods the screen On Sun, Aug 16, 2009 at 8:54 PM, Andre Dieb wrote: > Another attempt attached, see modifications list and inline comments below. > > - DOM is now a prefix: EINA_LOG_DOM_(l

Re: [E-devel] [PATCH] Eina logging domains

2009-08-16 Thread Andre Dieb
Another attempt attached, see modifications list and inline comments below. - DOM is now a prefix: EINA_LOG_DOM_(level) - renamed EINA_COLOR_NOTHING to EINA_COLOR_RESET - fixed loop problem at pending domains parse - removed eina_log_msg_* funcs, they're kept on eina_error - removed trailing white

Re: [E-devel] [PATCH] Eina logging domains

2009-08-16 Thread Gustavo Sverzut Barbieri
On Sun, Aug 16, 2009 at 5:45 AM, Andre Dieb wrote: > One more thing, > > On Sun, Aug 16, 2009 at 5:26 AM, Andre Dieb > wrote: >> >> Sorry for the HTML! :) >> >> On Sat, Aug 15, 2009 at 10:39 PM, Gustavo Sverzut Barbieri >> wrote: >>> >>> On Sat, Aug 15, 2009 at 5:55 PM, Andre Dieb >>> wrote: >>>

Re: [E-devel] [PATCH] Eina logging domains

2009-08-16 Thread Andre Dieb
One more thing, On Sun, Aug 16, 2009 at 5:26 AM, Andre Dieb wrote: > Sorry for the HTML! :) > > On Sat, Aug 15, 2009 at 10:39 PM, Gustavo Sverzut Barbieri > wrote: > >> On Sat, Aug 15, 2009 at 5:55 PM, Andre Dieb >> wrote: >> > Changes: >> > >> > Module name is now eina_log (but I didn't delete

Re: [E-devel] [PATCH] Eina logging domains

2009-08-16 Thread Andre Dieb
Sorry for the HTML! :) On Sat, Aug 15, 2009 at 10:39 PM, Gustavo Sverzut Barbieri wrote: > On Sat, Aug 15, 2009 at 5:55 PM, Andre Dieb > wrote: > > Changes: > > > > Module name is now eina_log (but I didn't delete eina_error yet, as we > > should delete it only when the transition is completed)

Re: [E-devel] [PATCH] Eina logging domains

2009-08-15 Thread Vincent Torri
On Sat, 15 Aug 2009, Gustavo Sverzut Barbieri wrote: On Sat, Aug 15, 2009 at 5:55 PM, Andre Dieb wrote: Changes: Module name is now eina_log (but I didn't delete eina_error yet, as we should delete it only when the transition is completed) Docs on header and basic doc on .c file, but there's

Re: [E-devel] [PATCH] Eina logging domains

2009-08-15 Thread Gustavo Sverzut Barbieri
On Sat, Aug 15, 2009 at 5:55 PM, Andre Dieb wrote: > Changes: > > Module name is now eina_log (but I didn't delete eina_error yet, as we > should delete it only when the transition is completed) > Docs on header and basic doc on .c file, but there's a lot of room for doc > improvement > Save name o

Re: [E-devel] [PATCH] Eina logging domains

2009-08-01 Thread Andre Dieb
Newer version: fix EINA_ERROR_LEVELS parsing issue. On Sat, Jul 25, 2009 at 10:44 PM, Andre Dieb wrote: > Removing workaround with unused variable.. > > > On Sat, Jul 25, 2009 at 10:30 PM, Andre Dieb > wrote: > >> Fix a missing free() spotted by Sachiel. >> >> >> On Sat, Jul 25, 2009 at 9:21 PM,

Re: [E-devel] [PATCH] Eina logging domains

2009-07-25 Thread Andre Dieb
Fix a missing free() spotted by Sachiel. On Sat, Jul 25, 2009 at 9:21 PM, Andre Dieb wrote: > The new patch is attached (hope it works now). > > > On Sat, Jul 25, 2009 at 9:04 PM, Andre Dieb > wrote: > >> The new patch is attached. >> >> On Sat, Jul 18, 2009 at 1:57 PM, Gustavo Sverzut Barbieri

Re: [E-devel] [PATCH] Eina logging domains

2009-07-25 Thread Andre Dieb
Removing workaround with unused variable.. On Sat, Jul 25, 2009 at 10:30 PM, Andre Dieb wrote: > Fix a missing free() spotted by Sachiel. > > > On Sat, Jul 25, 2009 at 9:21 PM, Andre Dieb > wrote: > >> The new patch is attached (hope it works now). >> >> >> On Sat, Jul 25, 2009 at 9:04 PM, Andre

Re: [E-devel] [PATCH] Eina logging domains

2009-07-25 Thread Andre Dieb
The new patch is attached (hope it works now). On Sat, Jul 25, 2009 at 9:04 PM, Andre Dieb wrote: > The new patch is attached. > > On Sat, Jul 18, 2009 at 1:57 PM, Gustavo Sverzut Barbieri > wrote: > >> On Fri, Jul 17, 2009 at 6:55 PM, Andre Dieb >> wrote: >> > Hello, >> > >> > This patch contai

Re: [E-devel] [PATCH] Eina logging domains

2009-07-25 Thread Andre Dieb
The new patch is attached. On Sat, Jul 18, 2009 at 1:57 PM, Gustavo Sverzut Barbieri wrote: > On Fri, Jul 17, 2009 at 6:55 PM, Andre Dieb > wrote: > > Hello, > > > > This patch contains an initial implementation of logging domains for eina > > error module. Please be aware that this a very rough

Re: [E-devel] [PATCH] Eina logging domains

2009-07-18 Thread Gustavo Sverzut Barbieri
On Fri, Jul 17, 2009 at 6:55 PM, Andre Dieb wrote: > Hello, > > This patch contains an initial implementation of logging domains for eina > error module. Please be aware that this a very rough version and there are > lots of things that must be improved. > > The patch is also with lots of fprintf's

Re: [E-devel] [PATCH] Eina logging domains

2009-07-17 Thread Sachiel
On Fri, Jul 17, 2009 at 7:35 PM, Andre Dieb wrote: > I'd also suggest renaming the env var EINA_ERROR_DOMAIN_LEVELS to > EINA_ERROR_LEVELS. It's smaller and more compatible with the global one > (EINA_ERROR_LEVEL). > + // Did not found a slot, realloc 8 more slots. Also works on the first time +

Re: [E-devel] [PATCH] Eina logging domains

2009-07-17 Thread Andre Dieb
I'd also suggest renaming the env var EINA_ERROR_DOMAIN_LEVELS to EINA_ERROR_LEVELS. It's smaller and more compatible with the global one (EINA_ERROR_LEVEL). On Fri, Jul 17, 2009 at 6:55 PM, Andre Dieb wrote: > Hello, > > This patch contains an initial implementation of logging domains for eina

[E-devel] [PATCH] Eina logging domains

2009-07-17 Thread Andre Dieb
Hello, This patch contains an initial implementation of logging domains for eina error module. Please be aware that this a very rough version and there are lots of things that must be improved. The patch is also with lots of fprintf's that I was using for debugging, please ignore them. When we're