Thank you for your response.
I have attached revised patch.
Please review this again, Thanks :)
2012/3/22 Carsten Haitzler ras...@rasterman.com:
On Wed, 21 Mar 2012 18:19:26 +0900 cnook kimci...@gmail.com said:
Dear All, Hello.
The patch is for using elm_list as a item controller of
On Thu, 22 Mar 2012 16:40:39 +0900 Kim Shinwoo kimcinoo@gmail.com said:
looks like its the exact same patch as before :)
Thank you for your response.
I have attached revised patch.
Please review this again, Thanks :)
2012/3/22 Carsten Haitzler ras...@rasterman.com:
On Wed, 21 Mar
OMG.
I checked and revised whole elc_ctxpopup.c file to follow the coding
style as bellows.
Add parenthesis around all conditions:
if (a) ...
if (!a) ...
if ((a) (b))...
if ((!a) (b))...
Please review the attached patch. Thanks!
2012/3/22 Carsten Haitzler
On Thu, 22 Mar 2012 17:41:49 +0900 Kim Shinwoo kimcinoo@gmail.com said:
i STILL see a if() (vs if ().. notice the SPACE) :)
OMG.
I checked and revised whole elc_ctxpopup.c file to follow the coding
style as bellows.
Add parenthesis around all conditions:
if (a) ...
if
AH!! sorry for this. now the patch follows..
- 1 space before parenthesis for keywords: if, for, while, switch
Thanks for your response
2012/3/22 Carsten Haitzler ras...@rasterman.com:
On Thu, 22 Mar 2012 17:41:49 +0900 Kim Shinwoo kimcinoo@gmail.com said:
i STILL see a if() (vs if
On Thu, 22 Mar 2012 18:44:40 +0900 Kim Shinwoo kimcinoo@gmail.com said:
in svn! :)
AH!! sorry for this. now the patch follows..
- 1 space before parenthesis for keywords: if, for, while, switch
Thanks for your response
2012/3/22 Carsten Haitzler ras...@rasterman.com:
On Thu,
Dear All, Hello.
The patch is for using elm_list as a item controller of elc_ctxpopup.
I have learned that there was an opinion to change the internal structure
of ctxpopup using the list.
It would be able to match up to your expectation. but it is just a draft
version of using list in ctxpopup.
yeap, it seems nice.
btw, i have a question.
- if (eina_list_count(wd-items) 1)
+ list = elm_object_item_widget_get(ctxpopup_it-list_item);
+
+ if (eina_list_count(elm_list_items_get(list)) 2)
{
+elm_object_item_del(ctxpopup_it-list_item);
Thanks for your response.
It is for hiding ctxpopup if there is no item..
2012/3/21 Hyoyoung Chang hyoyo...@gmail.com:
yeap, it seems nice.
btw, i have a question.
- if (eina_list_count(wd-items) 1)
+ list = elm_object_item_widget_get(ctxpopup_it-list_item);
+
+ if
On Wed, 21 Mar 2012 18:19:26 +0900 cnook kimci...@gmail.com said:
Dear All, Hello.
The patch is for using elm_list as a item controller of elc_ctxpopup.
I have learned that there was an opinion to change the internal structure
of ctxpopup using the list.
It would be able to match up to
10 matches
Mail list logo
