Re: [E-devel] [Patch][elementary_test] test_list

2012-04-19 Thread Daniel Juyung Seo
Belated review. I have some comments. I just committed the fixed version but it'll be good for you to know. 1) two spaces between bt, and 4!!. elm_grid_pack(gd, bt, 4, 80, 20, 10); There were more than 10 instances of this. I fixed it. 2) internal function position I moved

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-19 Thread Kim Shinwoo
Thanks for your response. Your review is always great. :) 2012/4/19 Daniel Juyung Seo seojuyu...@gmail.com: Belated review. I have some comments. I just committed the fixed version but it'll be good for you to know. 1) two spaces between bt, and 4!!. elm_grid_pack(gd, bt,  4,  80, 20, 10);

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-17 Thread Kim Shinwoo
Yeap, I see. :) 2012/4/17 Vincent Torri vincent.to...@gmail.com: hey On Tue, Apr 17, 2012 at 6:35 AM, cnook kimci...@gmail.com wrote: Dear All, Hello. I had added test code for the elementary. but I made a pause it because of some reasons and just started again. Today I have attached a

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-17 Thread ChunEon Park
: 2012-04-17 (화) 13:35:19 Subject: [E-devel] [Patch][elementary_test] test_list Dear All, Hello. I had added test code for the elementary. but I made a pause it because of some reasons and just started again. Today I have attached a patch for the elm_list which does not have test code for the API

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-17 Thread Kim Shinwoo
;enlightenment-devel@lists.sourceforge.netgt;; Cc: Sent: 2012-04-17 (화) 13:35:19 Subject: [E-devel] [Patch][elementary_test] test_list Dear All, Hello. I had added test code for the elementary. but I made a pause it because of some reasons and just started again. Today I have attached a patch

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-17 Thread ChunEon Park
-devel@lists.sourceforge.netgt;; Cc: Sent: 2012-04-17 (화) 17:44:34 Subject: Re: [E-devel] [Patch][elementary_test] test_list Thanks for your response. Even though the list item - lit - is NULL, the elm_list_item_prev/next(); does not occur error message. But other APIs

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-17 Thread Kim Shinwoo
Shinwoolt;kimcinoo@gmail.comgt; To: Enlightenment developer listlt;enlightenment-devel@lists.sourceforge.netgt;; Cc: Sent: 2012-04-17 (화) 17:44:34 Subject: Re: [E-devel] [Patch][elementary_test] test_list Thanks for your response. Even though the list item - lit - is NULL

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-17 Thread The Rasterman
On Tue, 17 Apr 2012 13:35:19 +0900 cnook kimci...@gmail.com said: Dear All, Hello. I had added test code for the elementary. but I made a pause it because of some reasons and just started again. Today I have attached a patch for the elm_list which does not have test code for the API

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-17 Thread Kim Shinwoo
hehe~ I like grid! hmm.. If you want... I will be back with the box! 2012/4/17 Carsten Haitzler ras...@rasterman.com: On Tue, 17 Apr 2012 13:35:19 +0900 cnook kimci...@gmail.com said: Dear All, Hello. I had added test code for the elementary. but I made a pause it because of some reasons

[E-devel] [Patch][elementary_test] test_list

2012-04-16 Thread cnook
Dear All, Hello. I had added test code for the elementary. but I made a pause it because of some reasons and just started again. Today I have attached a patch for the elm_list which does not have test code for the API elm_list_item_prev(); Please review the attached patch and give any feedbacks.

Re: [E-devel] [Patch][elementary_test] test_list

2012-04-16 Thread Vincent Torri
hey On Tue, Apr 17, 2012 at 6:35 AM, cnook kimci...@gmail.com wrote: Dear All, Hello. I had added test code for the elementary. but I made a pause it because of some reasons and just started again. Today I have attached a patch for the elm_list which does not have test code for the API