Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-11-30 Thread Gustavo Sverzut Barbieri
On Tuesday, November 30, 2010, Daniel Juyung Seo wrote: >> >>  By: WooHyun Jung >> > > k-s: see some one else is motivated :) Yeah! Keep rocking! > > > On Wed, Dec 1, 2010 at 3:53 AM, Enlightenment SVN > wrote: >> Log: >> Improve elm_colorselector readability and fix clicked entry sig emission

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-11-30 Thread Daniel Juyung Seo
> > By: WooHyun Jung > k-s: see some one else is motivated :) On Wed, Dec 1, 2010 at 3:53 AM, Enlightenment SVN wrote: > Log: > Improve elm_colorselector readability and fix clicked entry sig emission > >  The reason for modifying about elm_colorselector can be "readability". >  Each bar in t

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Gustavo Sverzut Barbieri
On Tue, Oct 19, 2010 at 10:26 AM, Lucas De Marchi wrote: > On Tue, Oct 19, 2010 at 10:19 AM, Gustavo Sverzut Barbieri > wrote: >> This seems good, but would it handle the following cases? >> >> 1. >> >> void name_set(struct my_struct *p, const char *name) { >>    eina_stringshare_replace(&p->str,

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Lucas De Marchi
On Tue, Oct 19, 2010 at 10:19 AM, Gustavo Sverzut Barbieri wrote: > This seems good, but would it handle the following cases? > > 1. > > void name_set(struct my_struct *p, const char *name) { >    eina_stringshare_replace(&p->str, name); // could be a simple > eina_stringshare_add() as well > } >

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Gustavo Sverzut Barbieri
On Tue, Oct 19, 2010 at 10:08 AM, Lucas De Marchi wrote: > On Tue, Oct 19, 2010 at 9:54 AM, Gustavo Sverzut Barbieri > wrote: >> I guess it's hard if not impossible to know for sure, unfortunately we >> have no way to tell from a const char* if it came from stringshare or >> regular malloc :-/ >

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Lucas De Marchi
On Tue, Oct 19, 2010 at 9:54 AM, Gustavo Sverzut Barbieri wrote: > I guess it's hard if not impossible to know for sure, unfortunately we > have no way to tell from a const char* if it came from stringshare or > regular malloc :-/ What about the following first attempt of a semantic patch? The a

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Gustavo Sverzut Barbieri
On Tue, Oct 19, 2010 at 9:38 AM, Bruno Dilly wrote: > On Tue, Oct 19, 2010 at 9:34 AM, Lucas De Marchi > wrote: >> On Tue, Oct 19, 2010 at 8:58 AM, Gustavo Sverzut Barbieri >> wrote: --- trunk/TMP/st/elementary/src/lib/elm_diskpicker.c    2010-10-19 05:58:26 UTC (rev 53590) +++ t

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Bruno Dilly
On Tue, Oct 19, 2010 at 9:34 AM, Lucas De Marchi wrote: > On Tue, Oct 19, 2010 at 8:58 AM, Gustavo Sverzut Barbieri > wrote: >>> --- trunk/TMP/st/elementary/src/lib/elm_diskpicker.c    2010-10-19 05:58:26 >>> UTC (rev 53590) >>> +++ trunk/TMP/st/elementary/src/lib/elm_diskpicker.c    2010-10-19

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Lucas De Marchi
On Tue, Oct 19, 2010 at 8:58 AM, Gustavo Sverzut Barbieri wrote: >> --- trunk/TMP/st/elementary/src/lib/elm_diskpicker.c    2010-10-19 05:58:26 >> UTC (rev 53590) >> +++ trunk/TMP/st/elementary/src/lib/elm_diskpicker.c    2010-10-19 10:48:11 >> UTC (rev 53591) >> @@ -388,13 +388,15 @@ >> >>    E

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-19 Thread Gustavo Sverzut Barbieri
On Tue, Oct 19, 2010 at 8:48 AM, Enlightenment SVN wrote: > Log: >  elm_diskpicker: save (list_len - 3) strlen calls > >  demarchi-- for reducing performance just to solve a comparison between >  signed and unsigned. > > > Author:       bdilly > Date:         2010-10-19 03:48:11 -0700 (Tue, 19 Oct

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-10-18 Thread Brett Nash
On Mon, 18 Oct 2010 11:15:59 -0700 "Enlightenment SVN" wrote: > Log: > Fixes for clang warnings > > Author: bdilly > Date: 2010-10-18 11:15:59 -0700 (Mon, 18 Oct 2010) > New Revision: 53576 > > Modified: > trunk/TMP/st/elementary/src/lib/elm_cnp_helper.c > trunk/TMP/st/eleme

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-06-25 Thread Gustavo Sverzut Barbieri
Listen and unlisten are quite bad. Keep Edje name compat as did for emit. I know it may be used differently, but even them signal_callback_add is good On Friday, June 25, 2010, Enlightenment SVN wrote: > Log: >  Implement elm_object_signal_listen and unlisten > >  elm_object_signal_listen add c

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-06-07 Thread Gustavo Sverzut Barbieri
On Mon, Jun 7, 2010 at 10:43 AM, Enlightenment SVN wrote: > Log: >  oops - forgot to return CALLBACK_CANCEL on elm_clock > > > Author:       bdilly > Date:         2010-06-07 06:43:07 -0700 (Mon, 07 Jun 2010) > New Revision: 49553 > > Modified: >  trunk/TMP/st/elementary/src/lib/elm_clock.c > > Mo

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-05-24 Thread Sachiel
On Mon, May 24, 2010 at 10:48 PM, Bruno Dilly wrote: > On Mon, May 24, 2010 at 12:06 AM, Iván Briano (Sachiel) > wrote: >> On Mon, May 24, 2010 at 8:41 AM, Enlightenment SVN >> wrote: >>> Log: >>>  Implement elm index sorted insert >>>   - Name index item as Elm_Index_Item >>>   - Add some other

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-05-24 Thread Bruno Dilly
On Mon, May 24, 2010 at 12:06 AM, Iván Briano (Sachiel) wrote: > On Mon, May 24, 2010 at 8:41 AM, Enlightenment SVN > wrote: >> Log: >>  Implement elm index sorted insert >>   - Name index item as Elm_Index_Item >>   - Add some other index functions: >>     + Item find >>     + Data get/set >>  

Re: [E-devel] E SVN: bdilly trunk/TMP/st/elementary/src/lib

2010-05-23 Thread Sachiel
On Mon, May 24, 2010 at 8:41 AM, Enlightenment SVN wrote: > Log: >  Implement elm index sorted insert >   - Name index item as Elm_Index_Item >   - Add some other index functions: >     + Item find >     + Data get/set >     + Letter get > >  I think this stuff will make easier to create index for