Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2012-11-12 Thread Jose Souza
Good catch, I will write a EDBus_Connection_Event_Type for Disconnection. On Sun, Nov 11, 2012 at 6:59 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: efreet: shutdown on error and disconnect When bus stops it send Disconnect signal. Trap and die. Author: englebass

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-16 Thread Vincent Torri
On Wed, 16 Mar 2011, Sebastian Dransfeld wrote: On 03/15/2011 11:55 PM, Vincent Torri wrote: On Tue, 15 Mar 2011, Enlightenment SVN wrote: Log: Efreet: And revert logging, no longer needed eina_log support is enabled, but it seems that it is disabled in efreet. See efreet_private.h

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-16 Thread sd
On Wed, 16 Mar 2011, Sebastian Dransfeld wrote: On 03/15/2011 11:55 PM, Vincent Torri wrote: On Tue, 15 Mar 2011, Enlightenment SVN wrote: Log: Efreet: And revert logging, no longer needed eina_log support is enabled, but it seems that it is disabled in efreet. See efreet_private.h

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Vincent Torri
On Tue, 15 Mar 2011, Enlightenment SVN wrote: Log: Efreet: Add some logging why not using eina_log ? Vincent Author: englebass Date: 2011-03-15 10:07:19 -0700 (Tue, 15 Mar 2011) New Revision: 57769 Trac: http://trac.enlightenment.org/e/changeset/57769 Modified:

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Sebastian Dransfeld
On 03/15/2011 06:12 PM, Vincent Torri wrote: On Tue, 15 Mar 2011, Enlightenment SVN wrote: Log: Efreet: Add some logging why not using eina_log ? Because I needed quick and dirty logging to track down the Mac OS X issue, and eina logging is still not enabled here which is the same

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Gustavo Sverzut Barbieri
You dont need any enablement to use eina_log, just use the global macros and you'll get it. Of couse it would be desirable to have one domain for efreet On Tuesday, March 15, 2011, Sebastian Dransfeld s...@tango.flipp.net wrote: On 03/15/2011 06:12 PM, Vincent Torri wrote: On Tue, 15 Mar

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Tom Hacohen
On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld s...@tango.flipp.netwrote: Because I needed quick and dirty logging to track down the Mac OS X issue, and eina logging is still not enabled here which is the same reason as last time. Do you have an auto script to check for added

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Sebastian Dransfeld
On 03/15/2011 07:15 PM, Tom Hacohen wrote: On Tue, Mar 15, 2011 at 7:54 PM, Sebastian Dransfeld s...@tango.flipp.net mailto:s...@tango.flipp.net wrote: Because I needed quick and dirty logging to track down the Mac OS X issue, and eina logging is still not enabled here which is the

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Tom Hacohen
Because I don't do the testing, someone else is. And that person is no coder. - What's wrong with a patch? Maybe it's just me, but I don't think debugging should happen through SVN. :) -- Tom. On Tue, Mar 15, 2011 at 8:24 PM, Sebastian Dransfeld s...@tango.flipp.netwrote: On 03/15/2011 07:15

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Sebastian Dransfeld
Code gone, I'll never do it again. S. On 03/15/2011 07:32 PM, Tom Hacohen wrote: Because I don't do the testing, someone else is. And that person is no coder. - What's wrong with a patch? Maybe it's just me, but I don't think debugging should happen through SVN. :) -- Tom. On Tue, Mar

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Mike Blumenkrantz
On Tue, 15 Mar 2011 19:51:26 +0100 Sebastian Dransfeld s...@tango.flipp.net wrote: Code gone, I'll never do it again. S. On 03/15/2011 07:32 PM, Tom Hacohen wrote: Because I don't do the testing, someone else is. And that person is no coder. - What's wrong with a patch? Maybe

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Tom Hacohen
:))) discomfitor: no one is fighting (or at least I wasn't). On Tue, Mar 15, 2011 at 8:51 PM, Sebastian Dransfeld s...@tango.flipp.netwrote: Code gone, I'll never do it again. S. On 03/15/2011 07:32 PM, Tom Hacohen wrote: Because I don't do the testing, someone else is. And that person

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Vincent Torri
On Tue, 15 Mar 2011, Enlightenment SVN wrote: Log: Efreet: And revert logging, no longer needed eina_log support is enabled, but it seems that it is disabled in efreet. See efreet_private.h lines 72 and after and efreet.c line 36. On the other hand, it's enabled in efreet_mime (see

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread The Rasterman
On Wed, 16 Mar 2011 00:08:28 +0200 Tom Hacohen t...@stosb.com said: i don't see a problem with quick and dirty printfs in trunk when working on an issue. if you want more permanent logging abilities - eina_log is probably good as u can turn it on and off at will. :))) discomfitor: no one is

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-03-15 Thread Sebastian Dransfeld
On 03/15/2011 11:55 PM, Vincent Torri wrote: On Tue, 15 Mar 2011, Enlightenment SVN wrote: Log: Efreet: And revert logging, no longer needed eina_log support is enabled, but it seems that it is disabled in efreet. See efreet_private.h lines 72 and after and efreet.c line 36. On the other

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-02-22 Thread Atton Jonathan
If the problem is in e why you don't fix e instead of revert a fix in efreet ? 2011/2/22 Enlightenment SVN no-re...@enlightenment.org Log: Efreet: Reset changed before scanning fallback Changed must be EINA_FALSE before scanning fallback to not create false positive. Author:

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-02-22 Thread Sebastian Dransfeld
On 02/22/2011 04:22 PM, Atton Jonathan wrote: If the problem is in e why you don't fix e instead of revert a fix in efreet ? E always wants to wait for desktop cache to be updated. So we always need to wait there. What we need to do is to differentiate between cache build done and change, and

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-02-22 Thread Sebastian Dransfeld
On 02/22/2011 08:45 PM, Sebastian Dransfeld wrote: On 02/22/2011 04:22 PM, Atton Jonathan wrote: If the problem is in e why you don't fix e instead of revert a fix in efreet ? E always wants to wait for desktop cache to be updated. So we always need to wait there. What we need to do is to

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-02-19 Thread Vincent Torri
On Sat, 19 Feb 2011, Enlightenment SVN wrote: Log: Only print if verbose and TODO++ why using fprintf(stder ***) and not eina_log ? Vincent Author: englebass Date: 2011-02-19 12:54:03 -0800 (Sat, 19 Feb 2011) New Revision: 57175 Trac:

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2011-02-19 Thread Sebastian Dransfeld
On 02/19/2011 10:01 PM, Vincent Torri wrote: On Sat, 19 Feb 2011, Enlightenment SVN wrote: Log: Only print if verbose and TODO++ why using fprintf(stder ***) and not eina_log ? Ask cedric, he wrote it. A lot of other printf's are older than eina, and I haven't bothered fixing them. And

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-29 Thread Sebastian Dransfeld
Vincent Torri h: On Sun, 28 Mar 2010, Enlightenment SVN wrote: Log: efreet: Only read data from disk when modified what about using file monitoring for that ? Well, we need to build the complete cache every time the bin is executed. So we need all information, the patch just makes the

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-28 Thread Vincent Torri
On Sun, 28 Mar 2010, Enlightenment SVN wrote: Log: efreet: Only read data from disk when modified what about using file monitoring for that ? Vincent Author: englebass Date: 2010-03-28 12:31:37 -0700 (Sun, 28 Mar 2010) New Revision: 47539 Modified:

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-11 Thread Sebastian Dransfeld
static int +strcmplen(const void *data1, const void *data2) +{ +return strncmp(data1, data2, strlen(data2)); +} If you used stringshare, you could use much faster eina_stringshare_len() here. Well, since one of the parameters isn't stringshared, it can't be done. +

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-11 Thread Gustavo Sverzut Barbieri
On Thu, Mar 11, 2010 at 3:33 PM, Sebastian Dransfeld sebas...@tango.flipp.net wrote:  static int +strcmplen(const void *data1, const void *data2) +{ +    return strncmp(data1, data2, strlen(data2)); +} If you used stringshare, you could use much faster eina_stringshare_len() here. Well,

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-10 Thread Gustavo Sverzut Barbieri
On Wed, Mar 10, 2010 at 6:33 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log:  read user dir cache Author:       englebass Date:         2010-03-10 13:33:43 -0800 (Wed, 10 Mar 2010) New Revision: 47120 Modified:  trunk/efreet/src/bin/efreet_desktop_cache_create.c Modified:

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-02 Thread Sebastian Dransfeld
Gustavo Sverzut Barbieri wrote: On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: truncate old cache so we don't read cached values Author: englebass Date: 2010-03-01 10:42:24 -0800 (Mon, 01 Mar 2010) New Revision: 46727 Modified:

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-02 Thread The Rasterman
On Tue, 02 Mar 2010 10:09:30 +0100 Sebastian Dransfeld sebas...@tango.flipp.net said: Gustavo Sverzut Barbieri wrote: On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: truncate old cache so we don't read cached values Author: englebass

Re: [E-devel] E SVN: englebass trunk/efreet/src/bin

2010-03-01 Thread Gustavo Sverzut Barbieri
On Mon, Mar 1, 2010 at 3:42 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log:  truncate old cache so we don't read cached values Author:       englebass Date:         2010-03-01 10:42:24 -0800 (Mon, 01 Mar 2010) New Revision: 46727 Modified: