On Mon, 16 Aug 2010 15:22 -0700, Michael Jennings wrote :
> On Monday, 16 August 2010, at 19:15:02 (-0300),
> Lucas De Marchi wrote:
>
> > 6) i = a == NULL;=> i = !a;
> > 7) i = a != NULL;=> i = !!a;
> >
> > Those four are valid also for while loops.
> >
>
On Mon, 16 Aug 2010 19:15:02 -0300 Lucas De Marchi
said:
> On Mon, Aug 16, 2010 at 9:48 AM, Carsten Haitzler
> wrote:
> >> Raster, k-s, others, what do you think? Can I apply for the other ones?
> > checking - this is a patch to go
> > if (x == NULL) -> if (!x)
> > right? (and the inverse).
> >
On Monday, 16 August 2010, at 19:15:02 (-0300),
Lucas De Marchi wrote:
> 6) i = a == NULL;=> i = !a;
> 7) i = a != NULL;=> i = !!a;
>
> Those four are valid also for while loops.
>
>Eina_Bool func(char *a)
>{
> 8)return a == NULL;=>
On Mon, Aug 16, 2010 at 9:48 AM, Carsten Haitzler wrote:
>> Raster, k-s, others, what do you think? Can I apply for the other ones?
> checking - this is a patch to go
> if (x == NULL) -> if (!x)
> right? (and the inverse).
> if (x != NULL) -> if (x)
>
> right?
right.
What about these others?
On Thu, 12 Aug 2010 08:21:10 -0300 Lucas De Marchi
said:
> On Wed, Aug 11, 2010 at 6:36 PM, Michael Jennings wrote:
> > I'm all for consistency, and this is certainly a great tool for
> > producing that consistency, but shouldn't a concensus be reached
> > amongst the developers for stylistic pe
On Fri, 13 Aug 2010 19:08:46 +0200, Lucas De Marchi
wrote:
> On Thu, Aug 12, 2010 at 6:08 PM, Kim Woelders wrote:
>>>
>> If this causes trouble just forget about it. In any case, please don't
>> introduce bugs :)
>>
>
> Kim, i've committed the change in E16. But it went with a bogus log
> mess
On Thu, Aug 12, 2010 at 6:08 PM, Kim Woelders wrote:
>>
> If this causes trouble just forget about it. In any case, please don't
> introduce bugs :)
>
Kim, i've committed the change in E16. But it went with a bogus log
message. The reason why it can have false negatives is that I don't
have the f
On Thu, 12 Aug 2010 20:09:20 +0200, Lucas De Marchi
wrote:
> On Thu, Aug 12, 2010 at 2:47 PM, Kim Woelders wrote:
>> I think we are in the personal taste department here, so it's probably
>> dangerous just to change this all over.
>
> I took embryo as the first victim because it has examples o
On Thu, Aug 12, 2010 at 2:47 PM, Kim Woelders wrote:
> I think we are in the personal taste department here, so it's probably
> dangerous just to change this all over.
I took embryo as the first victim because it has examples of most of
the cases. I would really like to apply the changes universa
On Thu, 12 Aug 2010 13:21:10 +0200, Lucas De Marchi
wrote:
> On Wed, Aug 11, 2010 at 6:36 PM, Michael Jennings wrote:
>> I'm all for consistency, and this is certainly a great tool for
>> producing that consistency, but shouldn't a concensus be reached
>> amongst the developers for stylistic p
On Thu, Aug 12, 2010 at 9:20 AM, Vincent Torri wrote:
> On Thu, 12 Aug 2010, Lucas De Marchi wrote:
>> On Wed, Aug 11, 2010 at 6:36 PM, Michael Jennings wrote:
> "EFL style" ? Where is it described ?
Good time to start writing what we know by asking each other on irc /
mailing list.
Lucas De
On Thu, 12 Aug 2010, Lucas De Marchi wrote:
> On Wed, Aug 11, 2010 at 6:36 PM, Michael Jennings wrote:
>> I'm all for consistency, and this is certainly a great tool for
>> producing that consistency, but shouldn't a concensus be reached
>> amongst the developers for stylistic personal preferen
On Wed, Aug 11, 2010 at 6:36 PM, Michael Jennings wrote:
> I'm all for consistency, and this is certainly a great tool for
> producing that consistency, but shouldn't a concensus be reached
> amongst the developers for stylistic personal preference changes as
> opposed to actual algorithmic correc
On Wednesday, 11 August 2010, at 13:35:26 (-0700),
Enlightenment SVN wrote:
> Log:
> Remove comparisons to NULL
>
> Rather than using "== NULL" or "!= NULL", use expression or !expression
> where
> possible.
>
> Patch automatically generated by coccinelle from badnull.cocci and
>
14 matches
Mail list logo
