Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2013-07-23 Thread Tom Hacohen
Hey, From the setlocale man page: If locale is NULL, the current locale is only queried, not modified. I am only querying it there, not modifying it. It's up to the application to set the locale to whatever it wants, for example by calling setlocale with like you've suggested. This is

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2013-07-22 Thread Daniel Juyung Seo
Dear Tom, what does if the app using elm is translatable. mean? With setlocale LC_MESSAGES to NULL, running applications with environment variable with LANG doesn't translate the texts. const char *msg_locale = setlocale(LC_MESSAGES, NULL); I tried with instead of NULL and it worked.

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-09-03 Thread Gustavo Lima Chaves
* Enlightenment SVN no-re...@enlightenment.org [2012-09-03 04:14:17 -0700]: Log: Elm layout: Fix segfault in some cases. Apparently this fixes stuff for Daniel Zaoui with some more complicated cases. Author: tasn Date: 2012-09-03 04:14:17 -0700 (Mon, 03 Sep 2012) New

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-09-03 Thread Tom Hacohen
I completely agree. Daniel caught me in a moment of weakness and tricked me into committing this. I'm reverting it now. -- Tom. On 03/09/12 16:48, Gustavo Lima Chaves wrote: * Enlightenment SVN no-re...@enlightenment.org [2012-09-03 04:14:17 -0700]: Log: Elm layout: Fix segfault in some

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-09-03 Thread Daniel Juyung Seo
Good review from glima. Thanks. Daniel Juyung Seo (SeoZ) On Mon, Sep 3, 2012 at 10:53 PM, Tom Hacohen tom.haco...@samsung.com wrote: I completely agree. Daniel caught me in a moment of weakness and tricked me into committing this. I'm reverting it now. -- Tom. On 03/09/12 16:48, Gustavo

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-17 Thread Tom Hacohen
On 17/05/12 02:15, Carsten Haitzler (The Rasterman) wrote: the point of releases and stability is that regardless if *YOU* care, you have users (customers) who care and stability is about supporting them. making bugfix releases with no nasty surprises they can DEPEND on. if you personally care

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-17 Thread Stefan Schmidt
Hello. On 05/17/2012 08:05 AM, Tom Hacohen wrote: On 17/05/12 02:15, Carsten Haitzler (The Rasterman) wrote: I know what a changelog is for, but you have to put a line somewhere. I'm certain you'll agree that Fixed elm_object_text_set to work when inserting the text 'aouaAHA*(KAo34'. hardly

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-16 Thread Davide Andreoli
2012/5/16 Enlightenment SVN no-re...@enlightenment.org Log: Elm fileselector_button: Fixed a bug when choosing a file. Author: tasn Date: 2012-05-16 05:12:34 -0700 (Wed, 16 May 2012) New Revision: 71165 Trac: http://trac.enlightenment.org/e/changeset/71165

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-16 Thread Tom Hacohen
On 16/05/12 22:02, Davide Andreoli wrote: Changelog? Backport? no? Changelog: fix a stupid bug in a widget no one uses (but my colleague it seems). Though seriously, changelog: no way I'm adding a changelog entry for that, we are really getting nuts with the changelog, we have 1 changes

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-05-16 Thread The Rasterman
On Wed, 16 May 2012 23:59:38 +0300 Tom Hacohen t...@stosb.com said: On 16/05/12 22:02, Davide Andreoli wrote: Changelog? Backport? no? Changelog: fix a stupid bug in a widget no one uses (but my colleague it seems). the point of releases and stability is that regardless if *YOU* care,

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-02-20 Thread Daniel Juyung Seo
This introduces following warnings. elm_gesture_layer.c: In function '_add_device_pending': elm_gesture_layer.c:859:13: warning: passing argument 3 of 'eina_list_search_unsorted_list' makes pointer from integer without a cast /usr/local/include/eina-1/eina/eina_list.h:1163:28: note: expected

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-02-20 Thread ChunEon Park
; To: enlightenment-devel@lists.sourceforge.net Cc: enlightenment-...@lists.sourceforge.net Sent: 12-02-21(화) 10:56:54 Subject: Re: [E-devel] E SVN: tasn trunk/elementary/src/lib This introduces following warnings. elm_gesture_layer.c: In function '_add_device_pending': elm_gesture_layer.c:859:13

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-02-17 Thread Tom Hacohen
Just to conform with pager... look at the bottom of the .h file, you have the item style default set function... -- Tom. On 17/02/12 04:56, ChunEon Park wrote: Why does elm_naviframe_item_style_default_set API required? This API says that elm_object_style_default_set is also needed.

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2012-02-16 Thread ChunEon Park
Why does elm_naviframe_item_style_default_set API required? This API says that elm_object_style_default_set is also needed. -Regards, Hermet- -Original Message- From: Enlightenment SVNlt;no-re...@enlightenment.orggt; To:

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread Tom Hacohen
On 08/12/11 04:43, Daniel Juyung Seo wrote: Hello Tom, Thanks for you fix. I have one question here. I think this macro has no big benefit. +#define BASE(it) ((it)-base) There is no much difference between BASE(it) and it-base. But there are two macros for base.view and base.widget in

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread ChunEon Park
: enlightenment-...@lists.sourceforge.net Sent: 11-12-08(목) 17:05:56 Subject: Re: [E-devel] E SVN: tasn trunk/elementary/src/lib On 08/12/11 04:43, Daniel Juyung Seo wrote: Hello Tom, Thanks for you fix. I have one question here. I think this macro has no big benefit. +#define BASE

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread ChunEon Park
: enlightenment-...@lists.sourceforge.net Sent: 11-12-08(목) 17:05:56 Subject: Re: [E-devel] E SVN: tasn trunk/elementary/src/lib On 08/12/11 04:43, Daniel Juyung Seo wrote: Hello Tom, Thanks for you fix. I have one question here. I think this macro has no big benefit. +#define BASE(it) ((it)-base

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread Tom Hacohen
On 08/12/11 11:28, ChunEon Park wrote: simply, we can call elm_widget_item_disabled_get API it's more clear. It is, that's what I was talking about in my previous mail, didn't know it existed. :) Mind fixing it? Thanks, Tom.

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread ChunEon Park
-...@lists.sourceforge.net Sent: 11-12-08(목) 18:55:33 Subject: Re: [E-devel] E SVN: tasn trunk/elementary/src/lib On 08/12/11 11:28, ChunEon Park wrote: simply, we can call elm_widget_item_disabled_get API it's more clear. It is, that's what I was talking about in my previous mail, didn't know

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread Tom Hacohen
Hacohentom.haco...@partner.samsung.com *To:* Enlightenment developer listenlightenment-devel@lists.sourceforge.net *Cc:* ChunEon Parkher...@naver.com; enlightenment-...@lists.sourceforge.net *Sent:* 11-12-08(목) 18:55:33 *Subject:* Re: [E-devel] E SVN: tasn trunk/elementary/src/lib On 08/12/11 11:28

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread ChunEon Park
@lists.sourceforge.netgt;; enlightenment-...@lists.sourceforge.net Sent: 11-12-08(목) 20:08:04 Subject: Re: [E-devel] E SVN: tasn trunk/elementary/src/lib I can fix it, will try to squeeze it in today, but if you get to it before I do, feel free to do it yourself. :P -- Tom. On 08/12/11 13:04, ChunEon Park wrote

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-08 Thread Tom Hacohen
- -Original Message- *From:* Tom Hacohentom.haco...@partner.samsung.com *To:* ChunEon Parkher...@naver.com *Cc:* Enlightenment develoenlightenment-devel@lists.sourceforge.net; enlightenment-...@lists.sourceforge.net *Sent:* 11-12-08(목) 20:08:04 *Subject:* Re: [E-devel] E SVN: tasn trunk

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-12-07 Thread Daniel Juyung Seo
Hello Tom, Thanks for you fix. I have one question here. I think this macro has no big benefit. +#define BASE(it) ((it)-base) There is no much difference between BASE(it) and it-base. But there are two macros for base.view and base.widget in elm_widget.h #define VIEW(X) X-base.view #define

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-08-29 Thread Gustavo Barbieri
Hey Tasn, need to check but before there were no limits that the tooltip must be on an elm object. It could be an edje or a single rectangle. All it should use are mouse events. --Gustavo Sent from my iPhone On 28/08/2011, at 11:13, Enlightenment SVN no-re...@enlightenment.org wrote: Log:

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-08-29 Thread Tom Hacohen
On 29/08/11 14:32, Gustavo Barbieri wrote: Hey Tasn, need to check but before there were no limits that the tooltip must be on an elm object. It could be an edje or a single rectangle. All it should use are mouse events. --Gustavo Sent from my iPhone Ah. I'm sorry then, will revert, my

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-08-29 Thread Gustavo Barbieri
Went bad? But evas_object_data_get() should be safe with it using magic numbers. --Gustavo Sent from my iPhone On 29/08/2011, at 08:36, Tom Hacohen tom.haco...@partner.samsung.com wrote: On 29/08/11 14:32, Gustavo Barbieri wrote: Hey Tasn, need to check but before there were no limits that

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-08-29 Thread Tom Hacohen
Ok, reverted. A big win for informative commit logs that made it easier for you to detect this bad commit. :) On 29/08/11 14:43, Gustavo Barbieri wrote: Went bad? But evas_object_data_get() should be safe with it using magic numbers. I'm not sure I got you, you suggest I'll change it to

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-08-29 Thread Sachiel
2011/8/29 Tom Hacohen tom.haco...@partner.samsung.com: Ok, reverted. A big win for informative commit logs that made it easier for you to detect this bad commit. :) On 29/08/11 14:43, Gustavo Barbieri wrote: Went bad? But evas_object_data_get() should be safe with it using magic numbers.

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-08-29 Thread Tom Hacohen
On 29/08/11 14:59, Iván Briano (Sachiel) wrote: Or tell your friend to read the warnings in the compile log. Or not to cast pointers to incompatible types to silence those warnings. I tell him that all the time... To his defence though, in this case it wasn't entirely his fault. He did

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-08-29 Thread Gustavo Sverzut Barbieri
On Mon, Aug 29, 2011 at 9:07 AM, Tom Hacohen tom.haco...@partner.samsung.com wrote: On 29/08/11 14:59, Iván Briano (Sachiel) wrote: Or tell your friend to read the warnings in the compile log. Or not to cast pointers to incompatible types to silence those warnings. I tell him that all the

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-05-19 Thread Leif Middelschulte
2011/5/19 Enlightenment SVN no-re...@enlightenment.org: Log: Elm entry: strndup is not portable, use memcpy. If it's in the context of copying a string, why don't you define strndup as a macro for platforms it's not supported on? BR, Leif  Thanks to vtorri for the notice. Author:      

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-05-19 Thread Tom Hacohen
On Thu, 2011-05-19 at 18:19 +0200, Leif Middelschulte wrote: 2011/5/19 Enlightenment SVN no-re...@enlightenment.org: Log: Elm entry: strndup is not portable, use memcpy. If it's in the context of copying a string, why don't you define strndup as a macro for platforms it's not supported on?

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-04-06 Thread Daniel Juyung Seo
Tom! This is so good. I waited this patch for so long. Sorry I was too busy to fix this. ; or lazy :) Thanks! Daniel Juyung Seo (SeoZ) On Wed, Apr 6, 2011 at 4:51 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Elementary smart-scroller: Fixed scroller jumping in some cases.

Re: [E-devel] E SVN: tasn trunk/elementary/src/lib

2011-04-06 Thread Tom Hacohen
Lazy bastard! I forgot about it, but got reminded by ephoto yesterday night, so I decided to fix it. :) -- Tom. On Wed, 2011-04-06 at 18:28 +0900, Daniel Juyung Seo wrote: Tom! This is so good. I waited this patch for so long. Sorry I was too busy to fix this. ; or lazy :) Thanks! Daniel