Re: [E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file

2012-10-10 Thread The Rasterman
On Thu, 20 Sep 2012 11:19:57 +0200 KoziarekBeata said: i'm going to be a bit harsh here.. :( but.. it'd be nice if you didn't make 99% of your patch whitepsace changes? it really discourages review - when u see a long patch u delay it only to find.. its all wasted stuff. :-P so please.. next time

Re: [E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file

2012-09-21 Thread KoziarekBeata
@gmail.com] Sent: Friday, September 21, 2012 4:08 AM To: Enlightenment developer list Subject: Re: [E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file NULL checks again! Daniel Juyung Seo (SeoZ) On Fri, Sep 21, 2012 at 2:27 AM, Gustavo Sverzut Barbieri wrote: >

Re: [E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file

2012-09-20 Thread Daniel Juyung Seo
NULL checks again! Daniel Juyung Seo (SeoZ) On Fri, Sep 21, 2012 at 2:27 AM, Gustavo Sverzut Barbieri wrote: > On Thu, Sep 20, 2012 at 11:50 AM, Leandro Dorileo > wrote: >> Hi Beata, >> >> On Thu, Sep 20, 2012 at 11:19:57AM +0200, KoziarekBeata wrote: >>> Hi, >>> >>> >>> >>> This patch contains

Re: [E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file

2012-09-20 Thread Gustavo Sverzut Barbieri
On Thu, Sep 20, 2012 at 11:50 AM, Leandro Dorileo wrote: > Hi Beata, > > On Thu, Sep 20, 2012 at 11:19:57AM +0200, KoziarekBeata wrote: >> Hi, >> >> >> >> This patch contains NULL checks for some functions in edje_entry file. >> >> Lack of these NULL checks after calling these function causes seg

Re: [E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file

2012-09-20 Thread Leandro Dorileo
Hi Beata, On Thu, Sep 20, 2012 at 11:19:57AM +0200, KoziarekBeata wrote: > Hi, > > > > This patch contains NULL checks for some functions in edje_entry file. > > Lack of these NULL checks after calling these function causes segmentation > faults. > I'm afraid your patch hides the "real"

[E-devel] [Edje][Patch] Patch with NULL checks for some functions in edje_entry file

2012-09-20 Thread KoziarekBeata
Hi, This patch contains NULL checks for some functions in edje_entry file. Lack of these NULL checks after calling these function causes segmentation faults. Please find attached file and give me some feedback. Regards, Beata edje_entry_NULL_check.patch Description: Binary dat

Re: [E-devel] edje patch (lua)

2012-02-19 Thread cpmichael1
- Original Message - From: "David Seikel" To: "Vincent Torri" Cc: enlightenment-devel@lists.sourceforge.net Sent: Saturday, February 18, 2012 1:41:56 PM Subject: Re: [E-devel] edje patch (lua) On Sat, 18 Feb 2012 14:46:36 +0100 Vincent Torri wrote: > h

Re: [E-devel] edje patch (lua)

2012-02-18 Thread David Seikel
On Sat, 18 Feb 2012 14:46:36 +0100 Vincent Torri wrote: > hey > > does the below break something ? > > Vincent > > > Index: src/lib/edje_lua2.c > === > --- src/lib/edje_lua2.c (revision 68106) > +++ src/lib/edje_lua2.c

Re: [E-devel] [Edje] [Patch] Drop pointless _edje_fetch call.

2011-03-24 Thread The Rasterman
On Tue, 22 Mar 2011 01:25:45 -0400 Mike Blumenkrantz said: > On Tue, 22 Mar 2011 04:51:18 + > Brett Nash wrote: > > > As the subject really. _edje_fetch is a get call, so no point doing it to > > assign to a variable that is about to go out of scope. > > > > I can commit if someone prefer

Re: [E-devel] [Edje] [Patch] Drop pointless _edje_fetch call.

2011-03-21 Thread Mike Blumenkrantz
On Tue, 22 Mar 2011 04:51:18 + Brett Nash wrote: > As the subject really. _edje_fetch is a get call, so no point doing it to > assign to a variable that is about to go out of scope. > > I can commit if someone prefers. > > Regards, > nash go for it -- Mike Blumenkrantz Zentif

[E-devel] [Edje] [Patch] Drop pointless _edje_fetch call.

2011-03-21 Thread Brett Nash
As the subject really. _edje_fetch is a get call, so no point doing it to assign to a variable that is about to go out of scope. I can commit if someone prefers. Regards, nash >From 961906e692dfd8dcd051e9a0668fc19309cf6adc Mon Sep 17 00:00:00 2001 From: Brett Nash Date: Tue, 22

Re: [E-devel] edje patch

2009-02-19 Thread Vincent Torri
On Thu, 19 Feb 2009, Carsten Haitzler (The Rasterman) wrote: > On Thu, 19 Feb 2009 10:29:57 +0100 (CET) Vincent Torri > said: > > hmm - no. no objection. :) interesting that you have to do the patch > though... :) thanks, in svn Vincent ---

Re: [E-devel] edje patch

2009-02-19 Thread The Rasterman
On Thu, 19 Feb 2009 10:29:57 +0100 (CET) Vincent Torri said: hmm - no. no objection. :) interesting that you have to do the patch though... :) > hey, > > no objection of i commit the patch below ? It's for Windows :p > > Vincent > > > Index: src/bin/edje_cc_parse.c >

[E-devel] edje patch

2009-02-19 Thread Vincent Torri
hey, no objection of i commit the patch below ? It's for Windows :p Vincent Index: src/bin/edje_cc_parse.c === --- src/bin/edje_cc_parse.c (révision 39091) +++ src/bin/edje_cc_parse.c (copie de travail) @@ -721,7 +721,7 @

Re: [E-devel] Edje patch again.

2005-07-26 Thread The Rasterman
On Fri, 08 Jul 2005 14:01:21 +0500 Boldin Pavel <[EMAIL PROTECTED]> babbled: > Carsten Haitzler (The Rasterman) wrote: > > >On Fri, 08 Jul 2005 02:04:33 +0500 Boldin Pavel <[EMAIL PROTECTED]> > >babbled: > > > > > >it's marked for me to read. i9 still don't like the "incompatible .edj" > >thing

Re: [E-devel] Edje patch again.

2005-07-08 Thread Boldin Pavel
Carsten Haitzler (The Rasterman) wrote: >On Fri, 08 Jul 2005 02:04:33 +0500 Boldin Pavel <[EMAIL PROTECTED]> >babbled: > > >it's marked for me to read. i9 still don't like the "incompatible .edj" thing. >i >dont think this is something u neeed to break the format for. you DO know that >the defa

Re: [E-devel] Edje patch again.

2005-07-07 Thread The Rasterman
On Fri, 08 Jul 2005 02:04:33 +0500 Boldin Pavel <[EMAIL PROTECTED]> babbled: > Hi, all! > > One question to Rasterman: you planing to include edje patch to cvs? > Or it is again ugly and unusable? it's marked for me to read. i9 still don't like the "incompatible .edj" thing. i dont think this is

[E-devel] Edje patch again.

2005-07-07 Thread Boldin Pavel
Hi, all! One question to Rasterman: you planing to include edje patch to cvs? Or it is again ugly and unusable? And more: would we need one more patch for scrolling dragable objects by scroll wheel? Or it should be realized on application level? Or it can already be realized by edje events pas

Re: [E-devel] Edje patch again.

2005-07-05 Thread Boldin Pavel
Tilman Sauerbeck wrote: Boldin Pavel <[EMAIL PROTECTED]> [2005-07-05 02:42]: FAQ: Q: Still I need to recompile all *.edj files? A: Yes, you still need to do it. This is CVS and you should understand, that backward compability is out of there. Luckily, it's not you who will make that

Re: [E-devel] Edje patch again.

2005-07-05 Thread Tilman Sauerbeck
Boldin Pavel <[EMAIL PROTECTED]> [2005-07-05 02:42]: > FAQ: > Q: Still I need to recompile all *.edj files? > A: Yes, you still need to do it. This is CVS and you should understand, that > backward compability is out of there. Luckily, it's not you who will make that decision. Regards, Tilman -

[E-devel] Edje patch again.

2005-07-04 Thread Boldin Pavel
Hi, it's me again. and again with fool pach for edje: adding "click and drag" ability for edje. Now it is seems to work in plugins (i use it in evolume plugin). For testing this feature try to do: $ cd /data $ sh e_logo.sh $ edje e_logo.edj and click on random place of background. There is s

Re: [E-devel] Edje patch

2005-06-22 Thread The Rasterman
On Sun, 19 Jun 2005 21:51:29 +0500 Boldin Pavel <[EMAIL PROTECTED]> babbled: > Y axis work in this new patch. ok- i see the usefulness of this. is it possible you could do this in a way that doesnt break older built edjes? -- - Codito, ergo sum - "I code, therefore I am" ---

Re: [E-devel] Edje patch

2005-06-19 Thread Boldin Pavel
Y axis work in this new patch. -- Boldin Pavel aka davinchi. mail-to: ldavinchi /at\ inbox _dot_ ru ZU - Zagovor Unixoidov. SSAU 303. diff -NurpP -x compile -x '*-config' -x '*.Tpo' -x '.*' -x 'output.*' -x autom4te.cache -x '*.orig' -x '*.o' -x '*.so*' -x '*.a' -x missing -x install-sh

Re: [E-devel] Edje patch

2005-06-19 Thread Boldin Pavel
Carsten Haitzler (The Rasterman) пишет: >On Sun, 19 Jun 2005 01:38:26 +0500 Boldin Pavel <[EMAIL PROTECTED]> >babbled: > > > >>Hello all! >> >>I patch edje to get working dragable objects like progressbars. >> >>this done by event handling and passing to dragable (mouse_down, >>mouse_up, mouse_

Re: [E-devel] Edje patch

2005-06-19 Thread The Rasterman
On Sun, 19 Jun 2005 01:38:26 +0500 Boldin Pavel <[EMAIL PROTECTED]> babbled: > Hello all! > > I patch edje to get working dragable objects like progressbars. > > this done by event handling and passing to dragable (mouse_down, > mouse_up, mouse_move). > you should add section like next one > ==

Re: [E-devel] Edje patch

2005-06-19 Thread Tilman Sauerbeck
Boldin Pavel <[EMAIL PROTECTED]> [2005-06-19 14:51]: > >I applied your patch and compiled it, but it seems to break all the edje > >interfaces: buttons do not respond anymore and I can't move dragable > >parts anymore. > > > sorry. you should rebuild all *.edj files with new edje_cc (or make > ed

Re: [E-devel] Edje patch

2005-06-19 Thread Boldin Pavel
Simon TRENY пишет: Hi Boldin, I applied your patch and compiled it, but it seems to break all the edje interfaces: buttons do not respond anymore and I can't move dragable parts anymore. sorry. you should rebuild all *.edj files with new edje_cc (or make edje_recc). for theme files to (for

Re: [E-devel] Edje patch

2005-06-19 Thread Simon TRENY
Hi Boldin, I applied your patch and compiled it, but it seems to break all the edje interfaces: buttons do not respond anymore and I can't move dragable parts anymore. Also, I haven't really understand what your patch should do? Dragable parts can already act like progress bars, you just need to c

[E-devel] Edje patch

2005-06-18 Thread Boldin Pavel
Hello all! I patch edje to get working dragable objects like progressbars. this done by event handling and passing to dragable (mouse_down, mouse_up, mouse_move). you should add section like next one === dragable { events: "progress_bar_drag"; } === into "part" section of object on that you ma