Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-20 Thread The Rasterman
On Sat, 18 Feb 2012 01:28:21 +0900 Hyoyoung Chang said: ok in. i added 2 #defines though for the header values so if people want to have const classes in code this makes it easier to define without knowing what the header has. :) > well, that means you have expectations to this feature. > that's

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-17 Thread Hyoyoung Chang
well, that means you have expectations to this feature. that's very good for me and thanks. revised version is attached. On Fri, Feb 17, 2012 at 8:53 PM, Carsten Haitzler wrote: > On Thu, 16 Feb 2012 15:10:16 +0900 Hyoyoung Chang said: > > can you adjust elc_fileselector.c to use the new creatio

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-17 Thread The Rasterman
On Thu, 16 Feb 2012 15:10:16 +0900 Hyoyoung Chang said: can you adjust elc_fileselector.c to use the new creation/free of smart classes. also test_store.c as well? :) (i know - the requests keep coming!) :) > oops i miss that. thanks. > attaching improved version > > On Thu, Feb 16, 2012 at 2:5

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-15 Thread Hyoyoung Chang
oops i miss that. thanks. attaching improved version On Thu, Feb 16, 2012 at 2:59 PM, Daniel Juyung Seo wrote: > Great! > But add NULL check for itc. > Thanks. > > Daniel Juyung Seo (SeoZ) > > On Wed, Feb 15, 2012 at 7:09 PM, Hyoyoung Chang wrote: > >> yeah, it's right. >> added free and ref to

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-15 Thread Daniel Juyung Seo
Great! But add NULL check for itc. Thanks. Daniel Juyung Seo (SeoZ) On Wed, Feb 15, 2012 at 7:09 PM, Hyoyoung Chang wrote: > yeah, it's right. > added free and ref to examples. > > On Tue, Feb 14, 2012 at 2:47 PM, Carsten Haitzler > wrote: > > On Mon, 13 Feb 2012 19:07:07 +0900 Hyoyoung Chang

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-13 Thread The Rasterman
On Fri, 10 Feb 2012 18:26:08 +0900 Hyoyoung Chang said: 1. your patch has your "minw ... wd->w" stuff (bugfix at genlist rotation) 2. refcount should start at 1 imho. 3. delete_me -> use bitfield (delete_me : 1) 4. i'd prefer the version field to be at the start, not end of class. i kn-w this bre

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-10 Thread Hyoyoung Chang
On Fri, Feb 10, 2012 at 8:34 PM, Gustavo Sverzut Barbieri wrote: > On Fri, Feb 10, 2012 at 7:26 AM, Hyoyoung Chang wrote: >> Dear all. >> >> I make controversial apis for item class management. >> As raster and other guys suggest, I simplify APIs and its behaviors. >> >> First, Two public apis an

Re: [E-devel] [patch] elm_genlist - add item_class management functions

2012-02-10 Thread Gustavo Sverzut Barbieri
On Fri, Feb 10, 2012 at 7:26 AM, Hyoyoung Chang wrote: > Dear all. > > I make controversial apis for item class management. > As raster and other guys suggest, I simplify APIs and its behaviors. > > First, Two public apis and two internal apis are introduced > > +EAPI Elm_Genlist_Item_Class * > +e