Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-05 Thread The Rasterman
On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: Hi all, sorry for not finding the time for doing this earlier. Attached is a patch that sorts out a number of smaller issues with eina on NetBSD and Solaris. Some are noise, some are real bugs. This brings it

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread The Rasterman
On Fri, 2 Dec 2011 08:42:43 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman) wrote: On Fri, 2 Dec 2011 08:28:36 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman)

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Joerg Sonnenberger
On Fri, Dec 02, 2011 at 04:00:46PM +0900, Carsten Haitzler wrote: On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: Hi all, sorry for not finding the time for doing this earlier. Attached is a patch that sorts out a number of smaller issues with eina on

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Joerg Sonnenberger
On Fri, Dec 02, 2011 at 03:37:30PM +0900, Carsten Haitzler wrote: On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: this is really late... and a lot of these patches i find questionable. i'll question here (things not questioned seem ok): 1. __SUNPRO_C

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Sachiel
2011/12/2 Joerg Sonnenberger jo...@britannica.bec.de: On Fri, Dec 02, 2011 at 03:37:30PM +0900, Carsten Haitzler wrote: On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: this is really late... and a lot of these patches i find questionable. i'll question

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread The Rasterman
On Fri, 2 Dec 2011 13:39:41 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: On Fri, Dec 02, 2011 at 03:37:30PM +0900, Carsten Haitzler wrote: On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: this is really late... and a lot of these patches i

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Joerg Sonnenberger
On Fri, Dec 02, 2011 at 09:51:12PM +0900, Carsten Haitzler wrote: 2. all the chasting and changing to unsigned char for passing into isspace () - isspace() actually takes an int, not unsigned char, so this just doesn't make sense. :( (well it does according to the manual page i have)

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Vincent Torri
On Fri, 2 Dec 2011, Joerg Sonnenberger wrote: On Fri, Dec 02, 2011 at 09:51:12PM +0900, Carsten Haitzler wrote: 2. all the chasting and changing to unsigned char for passing into isspace () - isspace() actually takes an int, not unsigned char, so this just doesn't make sense. :( (well it

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Joerg Sonnenberger
On Fri, Dec 02, 2011 at 10:16:17PM +0100, Vincent Torri wrote: so why not just do a 0xff instead of casting ? The cast is IMO cleaner in the intentions. It also has the theoretical advantage of working independent of CHAR_BIT==8. Joerg

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Sachiel
2011/12/2 Joerg Sonnenberger jo...@britannica.bec.de: On Fri, Dec 02, 2011 at 10:16:17PM +0100, Vincent Torri wrote: so why not just do a 0xff instead of casting ? The cast is IMO cleaner in the intentions. It also has the theoretical advantage of working independent of CHAR_BIT==8. We are

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Vincent Torri
On Fri, 2 Dec 2011, Joerg Sonnenberger wrote: On Fri, Dec 02, 2011 at 10:16:17PM +0100, Vincent Torri wrote: so why not just do a 0xff instead of casting ? The cast is IMO cleaner in the intentions. It also has the theoretical advantage of working independent of CHAR_BIT==8. except some

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Joerg Sonnenberger
On Fri, Dec 02, 2011 at 07:33:15PM -0200, Iván Briano (Sachiel) wrote: 2011/12/2 Joerg Sonnenberger jo...@britannica.bec.de: On Fri, Dec 02, 2011 at 10:16:17PM +0100, Vincent Torri wrote: so why not just do a 0xff instead of casting ? The cast is IMO cleaner in the intentions. It also

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-02 Thread Sachiel
2011/12/2 Joerg Sonnenberger jo...@britannica.bec.de: On Fri, Dec 02, 2011 at 07:33:15PM -0200, Iván Briano (Sachiel) wrote: 2011/12/2 Joerg Sonnenberger jo...@britannica.bec.de: On Fri, Dec 02, 2011 at 10:16:17PM +0100, Vincent Torri wrote: so why not just do a 0xff instead of casting ?

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-01 Thread The Rasterman
On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: this is really late... and a lot of these patches i find questionable. i'll question here (things not questioned seem ok): 1. __SUNPRO_C instead of __sun - explain why you dont just ADD an extra ||

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-01 Thread The Rasterman
On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: Hi all, sorry for not finding the time for doing this earlier. Attached is a patch that sorts out a number of smaller issues with eina on NetBSD and Solaris. Some are noise, some are real bugs. This brings it

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-01 Thread Vincent Torri
On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman) wrote: On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: this is really late... and a lot of these patches i find questionable. i'll question here (things not questioned seem ok): 1. __SUNPRO_C instead

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-01 Thread The Rasterman
On Fri, 2 Dec 2011 08:28:36 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman) wrote: On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: this is really late... and a lot of these patches i find

Re: [E-devel] eina 1.1.0beta patches for/from pkgsrc

2011-12-01 Thread Vincent Torri
On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman) wrote: On Fri, 2 Dec 2011 08:28:36 +0100 (CET) Vincent Torri vto...@univ-evry.fr said: On Fri, 2 Dec 2011, Carsten Haitzler (The Rasterman) wrote: On Thu, 1 Dec 2011 17:41:17 +0100 Joerg Sonnenberger jo...@britannica.bec.de said: