Please split you patch. why adding a macro used nowhere in this patch ?
And stop to cut and paste some code. A group isn't a file ... Try to give a
better quality in your patch
2014-04-02 17:55 GMT+02:00 Marcel Hollerbach :
> bu5hm4n pushed a commit to branch master.
>
>
> http://git.enlightenme
Like before, Split your patch.
Here you remove all the modularity of conf panel. This is really bad
2014-04-02 17:55 GMT+02:00 Marcel Hollerbach :
> bu5hm4n pushed a commit to branch master.
>
>
> http://git.enlightenment.org/misc/entrance.git/commit/?id=bd7d06b2c4f58d3fb1d420d0c0a93d96118
Good idea to use a macro inside a macro, where the first one is never used
...
2014-04-07 10:45 GMT+02:00 Michaël Bouchaud :
> Like before, Split your patch.
> Here you remove all the modularity of conf panel. This is really bad
>
>
>
> 2014-04-02 17:55 GMT+02:00 Marcel Hollerbach
> :
>
>
Factorizing code could be a better idea instead cut and paste ...
2014-04-02 17:55 GMT+02:00 Marcel Hollerbach :
> bu5hm4n pushed a commit to branch master.
>
>
> http://git.enlightenment.org/misc/entrance.git/commit/?id=ad00fd25dfe971aff71d8c2c735b52d978e19c29
>
> commit ad00fd25dfe971aff71d8c2
Really ???
You break one more time settings of background. You get the main
background not user background ...
I really think a revert of all your patch could be a better solution. None
have a good quality, I really think you are coding without understanding of
what you are doing.
2014-04-02 17:
what did you want to display in this conf log panel ?
Split your patch !!!
2014-04-06 21:23 GMT+02:00 Marcel Hollerbach :
> bu5hm4n pushed a commit to branch master.
>
>
> http://git.enlightenment.org/misc/entrance.git/commit/?id=1539a34296d9bf04a4d17a54ce0060c9f6bba380
>
> commit 1539a34296d9b
Hi boyz,
I don't have any problem to rename the stuff. We named it in that way
because the filenames were named in this way.
So my question is: what is the purpose of elc_, els_... if not to
distinguish them from regular widgets?
Jack, DanielZ
On 04/06/2014 01:36 PM, Cedric BAIL wrote:
> Ced
kuuko pushed a commit to branch master.
http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=d8613c88f88eb0239c089442b1b67154121ee7af
commit d8613c88f88eb0239c089442b1b67154121ee7af
Author: Kai Huuhko
Date: Mon Apr 7 12:55:15 2014 +0300
tests: Added a very simple unit te
Cedric Bail
On Apr 7, 2014 6:17 PM, "Daniel Zaoui" wrote:
>
> Hi boyz,
>
> I don't have any problem to rename the stuff. We named it in that way
> because the filenames were named in this way.
>
> So my question is: what is the purpose of elc_, els_... if not to
> distinguish them from regular wid
On Mon, Apr 07, 2014 at 10:42:20AM +0200, Michaël Bouchaud wrote:
> Please split you patch. why adding a macro used nowhere in this patch ?
I am using this macro in the user settings and the general settings.
Should I put them in the headers od the user and general settings ?
> And stop to cut an
On Mon, Apr 07, 2014 at 10:45:12AM +0200, Michaël Bouchaud wrote:
> Like before, Split your patch.
> Here you remove all the modularity of conf panel. This is really bad
Where do I remove the modularity ? I moved the theme and log stuff
allready to there own conf modules. (If you mean that)
>
What do you mean ? Its exactly the same thing in those two cases, so why
factorizing, it would end up in the same ??
On Mon, Apr 07, 2014 at 10:48:33AM +0200, Michaël Bouchaud wrote:
> Factorizing code could be a better idea instead cut and paste ...
>
>
> 2014-04-02 17:55 GMT+02:00 Marcel Holle
On Mon, Apr 07, 2014 at 10:55:40AM +0200, Michaël Bouchaud wrote:
> Really ???
> You break one more time settings of background. You get the main
One more time ??
> background not user background ...
Okay, I will fix that !
> I really think a revert of all your patch could be a better solution.
Idea is to display the log file and a few labels where the log files are
located!
On Mon, Apr 07, 2014 at 11:03:40AM +0200, Michaël Bouchaud wrote:
> what did you want to display in this conf log panel ?
> Split your patch !!!
>
>
>
> 2014-04-06 21:23 GMT+02:00 Marcel Hollerbach :
>
> > bu5hm4
nothing to do in a .h if you are using in one place. It's a design request.
And a macro calling another macro is just a wrong design. Or you target is
to write unmaintainable code.
ecore_file is for file and nothing else ...
Write a little algo to find last / ???
2014-04-07 12:57 GMT+02:00 Marcel
Same as you said, so we could factorize. Less code to maintain and if we
found a bug in it, we don't need to do same in two place. It's the basic of
the programation
2014-04-07 13:02 GMT+02:00 Marcel Hollerbach
:
> What do you mean ? Its exactly the same thing in those two cases, so why
> facto
you don't respect ui design, having multiple toolbar isn't a good things
for user. They go to be lost in multiple menu and can't be a good gui
(multiple context). And why you break modularity because your code don't
match the previous design made by me few weeks ago.
2014-04-07 12:59 GMT+02:00 Ma
Settings in entrance_client must just to be related to ui not to system. So
this panel is just uneeded.
2014-04-07 13:15 GMT+02:00 Marcel Hollerbach
:
> Idea is to display the log file and a few labels where the log files are
> located!
>
> On Mon, Apr 07, 2014 at 11:03:40AM +0200, Michaël Bouc
I use them in entrance_conf_main.c and entrance_conf_user.c, so where
should I put the macro ?
The group has the name entrance/wallpaper/foo
I just want to display foo so I need something which returns me "foo"
ecore_file_file_get does that, but okay, I will do it different.
On Mon, Apr 07, 201
And REALLY SPLIT YOUR PATCH NEXT TIMES. Or I couldn't review it correctly.
Next time, I don't read them. I will just do a revert.
2014-04-07 14:30 GMT+02:00 Michaël Bouchaud :
> Settings in entrance_client must just to be related to ui not to system.
> So this panel is just uneeded.
>
>
> 2014-0
mhmm a few users asked me where to find the logs etc. so I thought if
would be a good idea to display them there. Where so you think should we
place them ??
On Mon, Apr 07, 2014 at 02:30:20PM +0200, Michaël Bouchaud wrote:
> Settings in entrance_client must just to be related to ui not to system.
yeah you write two times a macro LIST_FILL who call IMG_LIST_FORK. Why not
creating only one macro in entrance_conf.h
2014-04-07 14:30 GMT+02:00 Marcel Hollerbach
:
> I use them in entrance_conf_main.c and entrance_conf_user.c, so where
> should I put the macro ?
>
> The group has the name entr
Well I dont understand what you want me to do now ?
On Mon, Apr 07, 2014 at 02:28:08PM +0200, Michaël Bouchaud wrote:
> Same as you said, so we could factorize. Less code to maintain and if we
> found a bug in it, we don't need to do same in two place. It's the basic of
> the programation
>
>
>
No we don't have to place them anywhere. It's already in configuration of
entrance. /etc/entrance.conf. It's a system feature not ui feature.
2014-04-07 14:35 GMT+02:00 Marcel Hollerbach
:
> mhmm a few users asked me where to find the logs etc. so I thought if
> would be a good idea to display
discomfitor pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=4e1b7308b755ffe46498b05aa3199d45f867bcd3
commit 4e1b7308b755ffe46498b05aa3199d45f867bcd3
Author: Mike Blumenkrantz
Date: Mon Apr 7 09:54:42 2014 -0400
+eeze_udev_get()
@feature
---
give us the numbers comparing both solutions? (benchmarks)
On Fri, Apr 4, 2014 at 12:42 PM, Tom Hacohen wrote:
> On 04/04/14 13:29, Stefan Schmidt wrote:
> > Hello.
> >
> > On Thu, 2014-04-03 at 18:01, Tom Hacohen wrote:
> >> On 03/04/14 17:42, Tom Hacohen wrote:
> >>> On 01/04/14 15:47, Tom Hac
strrchr
Sendt fra min iPad
> Den Apr 7, 2014 kl. 14:30 skrev Marcel Hollerbach
> :
>
> I use them in entrance_conf_main.c and entrance_conf_user.c, so where
> should I put the macro ?
>
> The group has the name entrance/wallpaper/foo
>
> I just want to display foo so I need something which re
yes libc give already some func, no need to add an algo for that. look for
strrchr or memrchr. Last one is better
2014-04-07 16:44 GMT+02:00 Sebastian Dransfeld :
> strrchr
>
> Sendt fra min iPad
>
> > Den Apr 7, 2014 kl. 14:30 skrev Marcel Hollerbach <
> marcel-hollerb...@t-online.de>:
> >
> >
discomfitor pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=2373269ad7322f487520d0c7e1a7a237e5553f12
commit 2373269ad7322f487520d0c7e1a7a237e5553f12
Author: zmike
Date: Mon Apr 7 13:15:40 2014 -0400
reformat edje_player
ffs these tabs
---
s
2014-04-07 11:17 GMT+02:00 Daniel Zaoui :
> Hi boyz,
>
> I don't have any problem to rename the stuff. We named it in that way
> because the filenames were named in this way.
>
> So my question is: what is the purpose of elc_, els_... if not to
> distinguish them from regular widgets?
>
For what
davemds pushed a commit to branch master.
http://git.enlightenment.org/bindings/python/python-efl.git/commit/?id=ea8f7ca9d6af82fc9a974d6e16d8c4e2791739fc
commit ea8f7ca9d6af82fc9a974d6e16d8c4e2791739fc
Author: davemds
Date: Mon Apr 7 19:57:40 2014 +0200
docs: make the Eo class appear in t
jackdanielz pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=912409df3cee321a354d8de6cef95ed3d4e77a54
commit 912409df3cee321a354d8de6cef95ed3d4e77a54
Author: Daniel Zaoui
Date: Sun Apr 6 16:41:45 2014 +0300
Eolian: rename enums.
Add the EOLIA
jackdanielz pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=1d89978c5bcf7de7a5867e42fe4bc5e1ca70dda3
commit 1d89978c5bcf7de7a5867e42fe4bc5e1ca70dda3
Author: Daniel Zaoui
Date: Sun Apr 6 17:10:05 2014 +0300
Eolian: clean API.
defines used as
jackdanielz pushed a commit to branch master.
http://git.enlightenment.org/core/efl.git/commit/?id=01c162697793a013ec559c1b2368d2d1a7a5dee3
commit 01c162697793a013ec559c1b2368d2d1a7a5dee3
Author: Yossi Kantor
Date: Tue Apr 1 17:35:04 2014 +0300
Eolian: Fix legacy generation.
Semi
34 matches
Mail list logo
