Re: [E-devel] [Patch][elementary_test] test_hover

2012-03-04 Thread Elevate Efl
Looks good to me. Tested and in svn. Regards Sanjeev On Mon, Mar 5, 2012 at 4:07 PM, cnook kimci...@gmail.com wrote: Dear All, Hello. I have attached a patch for test_hover. Please review the patch and give any feedbacks. Thanks. Sincerely, Shinwoo kim.

Re: [E-devel] [Patch][elementary_test] test_gengrid

2012-03-04 Thread Elevate Efl
+ GRID_TOOLTIP_ETC, Does it mean etcetra? If yes, can we be more specific with enums. case GRID_ITEM_CLASS_SET: /* 8 */ No need to specify constants in comments. I see some formatting issues in the code (callback decalrations.) Kindly fix and resubmit. On Mon, Mar 5, 2012 at 4:04 PM,

Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http

2012-03-02 Thread Elevate Efl
Ubuntu 11.10. I am upgrading to 12.04 beta and it has 3.6.X version. Let me try. Regards Sanjeev On Fri, Mar 2, 2012 at 11:42 PM, Leandro Pereira lean...@profusion.mobiwrote: Sanjeev, On 03/01/2012 11:27 PM, Elevate Efl wrote: Object::HasOwnProperty() is not to be found in v8.h. I

Re: [E-devel] E SVN: acidx trunk/PROTO/elev8

2012-03-02 Thread Elevate Efl
Cool. On Sat, Mar 3, 2012 at 2:41 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Test for the existence of Object::HasOwnProperty() Author: acidx Date: 2012-03-02 09:41:22 -0800 (Fri, 02 Mar 2012) New Revision: 68631 Trac:

Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/http

2012-03-01 Thread Elevate Efl
One comment to this commit. On Fri, Mar 2, 2012 at 5:39 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Remove HTTP module compile-time warnings Author: acidx Date: 2012-03-01 12:39:19 -0800 (Thu, 01 Mar 2012) New Revision: 68596 Trac:

Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http

2012-03-01 Thread Elevate Efl
Dear Leandro, This is very nice commit for elev8 modularization. Thanks. I have some problems compiling in my machine. Object::HasOwnProperty() is not to be found in v8.h. I did an apt-get update/upgrade and I did not find this in v8.h (version - 3.1.8.22) . The reference API page does provide

Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http

2012-03-01 Thread Elevate Efl
I am using 11.10. I will add the ppa to the version you have specified. On Fri, Mar 2, 2012 at 1:06 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Mar 1, 2012 at 11:27 PM, Elevate Efl eflel...@gmail.com wrote: Dear Leandro, This is very nice commit for elev8

Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http

2012-03-01 Thread Elevate Efl
Do you think it is a good idea to add version check in configure.ac script? On Fri, Mar 2, 2012 at 1:13 PM, Elevate Efl eflel...@gmail.com wrote: I am using 11.10. I will add the ppa to the version you have specified. On Fri, Mar 2, 2012 at 1:06 PM, Lucas De Marchi lucas.demar

Re: [E-devel] Fwd: timeline is not in line

2012-02-29 Thread Elevate Efl
Awesome. On Mar 1, 2012 3:56 AM, Davide Andreoli d...@gurumeditation.it wrote: Il giorno 29 febbraio 2012 13:20, Bertrand Jacquin be...@meleeweb.net ha scritto: This is now up to date. Beber Super!! thnks ! D'ar Wednesday 29 a viz February 2012 e 11 eur 18, « Bertrand Jacquin

Re: [E-devel] [patch] elm_genlist - add item flip set/get

2012-02-29 Thread Elevate Efl
Const for param? On Feb 29, 2012 9:19 PM, Hyoyoung Chang hyoyo...@gmail.com wrote: Dear all. I made a patch to introduce new genlist item mode. Two public apis are added. +EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool flip); +EAPI Eina_Bool

[E-devel] Patch for deprecating enum.

2012-02-29 Thread Elevate Efl
Kindly suggest if there is a better way. Regards, Sanjeev From e416dc65d91ade776aa83bcb558faebf84045939 Mon Sep 17 00:00:00 2001 From: Sanjeev BA iamsanj...@gmail.com Date: Thu, 1 Mar 2012 11:22:55 +0900 Subject: [PATCH 3/3] Rename enum based on review comment. Signed-off-by: Sanjeev BA

Re: [E-devel] Patch for deprecating enum.

2012-02-29 Thread Elevate Efl
() and deleted with elm_calendar_mark_del(). */ Oops..unintended typo. Will fix that one. Thanks! Daniel Juyung Seo (SeoZ) On Thu, Mar 1, 2012 at 11:26 AM, Elevate Efl eflel...@gmail.com wrote: Kindly suggest if there is a better way. Regards, Sanjeev

Re: [E-devel] elm_panes.h

2012-02-28 Thread Elevate Efl
In svn. http://trac.enlightenment.org/e/changeset/68527 Thanks, Sanjeev On Wed, Feb 29, 2012 at 11:49 AM, Daniel Juyung Seo seojuyu...@gmail.comwrote: Hello, On Wed, Feb 29, 2012 at 1:09 AM, J??r??my Zurcher jer...@asynk.ch wrote: we have 2 body less functions in elm_panes -

Re: [E-devel] elev8: Function/parameter/class naming scheme

2012-02-27 Thread Elevate Efl
I believe this topic has received enough attention (more than what it deserves actually) Can we freeze on CamelCase please ? On Tue, Feb 28, 2012 at 9:07 AM, Carsten Haitzler ras...@rasterman.comwrote: On Mon, 27 Feb 2012 15:51:04 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said:

Re: [E-devel] [patch] elm_cnp - revise document

2012-02-27 Thread Elevate Efl
Agree. Hyoyoung already has the relevant links. He can provide them. Also, some typos can be fixed in this patch. It's not = It does not Format is used for specified its type = Format is used to specify its type Clear all informations = Clear all information Regards, Sanjeev On Tue, Feb 28,

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-24 Thread Elevate Efl
, think of the potential savings in application support time :) On Fri, Feb 24, 2012 at 11:30 PM, Daniel Juyung Seo seojuyu...@gmail.comwrote: On Fri, Feb 24, 2012 at 9:24 AM, Elevate Efl eflel...@gmail.com wrote: No. *_MAX really doesn't give the app. developer anything useful. Hello

Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8: data/javascript src/modules/elm

2012-02-24 Thread Elevate Efl
Works pretty neat. Good. Thanks, Sanjeev On Sat, Feb 25, 2012 at 5:13 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Implement naviframe object. Included naviframe.js is adapted from pager.js. Author: acidx Date: 2012-02-24 12:13:40 -0800 (Fri, 24

Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib

2012-02-23 Thread Elevate Efl
No. *_MAX really doesn't give the app. developer anything useful. It has been added for the convenience (bounds checking) of the widget implementation. If we expose _MAX we need to tell the app. developer what is the expected behaviour if he uses it, which is unnecessary. On Fri, Feb 24,

Re: [E-devel] E SVN: sanjeev IN trunk/elementary/src: bin lib

2012-02-23 Thread Elevate Efl
I agree it is helpful. Done. On Fri, Feb 24, 2012 at 1:21 AM, Daniel Juyung Seo seojuyu...@gmail.comwrote: I encourage you to add deprecated apis into elm_deprecated.h and edit ElementaryChanges wiki page. Without them, many people will waste their time on tracing down the changes.

Re: [E-devel] elev8: Function/parameter/class naming scheme

2012-02-23 Thread Elevate Efl
This complaint was raised already, thought about and rejected, because elev8 was in prototype phase and we wanted to follow EFL style to be consistent with the rest of the code base. For the advanced use cases, I do see your point. Users of elev8 'API' might end up having a mix of their style and

Re: [E-devel] E SVN: hermet trunk/elementary/src/lib

2012-02-23 Thread Elevate Efl
ah..missed that one. Thanks. On Fri, Feb 24, 2012 at 3:50 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elenmentary/route - --warning. Author: hermet Date: 2012-02-23 22:50:48 -0800 (Thu, 23 Feb 2012) New Revision: 68384 Trac:

Re: [E-devel] E SVN: sanjeev IN trunk/elementary/src: edje_externals lib

2012-02-21 Thread Elevate Efl
I am inclined to use a more generic name like source or uri. 'uri' would be consistent with ecore_con API, ecore_con_url_url_set (Ecore_Con_Url *url_con, const char *url) but it doesn't convey the meaning of 'local file'. 'source' would be more generic but not consistent with either evas or

Re: [E-devel] E SVN: sanjeev trunk/espionnage/src/bin

2012-02-20 Thread Elevate Efl
As per emotion_smart.c - emotion_object_last_position_load(), it should. On Tue, Feb 21, 2012 at 3:34 PM, Vincent Torri vincent.to...@gmail.comwrote: On Tue, Feb 21, 2012 at 6:53 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Fix elm_video_uri_set usage in esopinage.