Re: [E-devel] [Patch][elementary_test] test_hover
Looks good to me. Tested and in svn. Regards Sanjeev On Mon, Mar 5, 2012 at 4:07 PM, cnook kimci...@gmail.com wrote: Dear All, Hello. I have attached a patch for test_hover. Please review the patch and give any feedbacks. Thanks. Sincerely, Shinwoo kim. -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [Patch][elementary_test] test_gengrid
+ GRID_TOOLTIP_ETC, Does it mean etcetra? If yes, can we be more specific with enums. case GRID_ITEM_CLASS_SET: /* 8 */ No need to specify constants in comments. I see some formatting issues in the code (callback decalrations.) Kindly fix and resubmit. On Mon, Mar 5, 2012 at 4:04 PM, cnook kimci...@gmail.com wrote: Hey, please ignore previous path which used a deprecated API. :p I have newly attached a path for test_gengrid. Please review this and give any feedback. Thanks. 2012/3/5 cnook kimci...@gmail.com: Dear All, Hello. I have attached a patch for test_gengrid. Please review this and give any feedbacks Sincerely, Shinwoo Kim. -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Try before you buy = See our experts in action! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-dev2 ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
Ubuntu 11.10. I am upgrading to 12.04 beta and it has 3.6.X version. Let me try. Regards Sanjeev On Fri, Mar 2, 2012 at 11:42 PM, Leandro Pereira lean...@profusion.mobiwrote: Sanjeev, On 03/01/2012 11:27 PM, Elevate Efl wrote: Object::HasOwnProperty() is not to be found in v8.h. I did an apt-get update/upgrade and I did not find this in v8.h (version - 3.1.8.22) . The reference API page does provide this API though. Can you tell me which version of libv8 you have used? I'm using the V8 library that comes with Arch Linux (3.6.6.20), which was released September 2011 according to v8's SVN. HasOwnProperty() has a JavaScript counterpart (Object.hasOwnProperty()), so I thought it would be available in V8 since a long time ago. What distribution/version are you using? Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8
Cool. On Sat, Mar 3, 2012 at 2:41 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Test for the existence of Object::HasOwnProperty() Author: acidx Date: 2012-03-02 09:41:22 -0800 (Fri, 02 Mar 2012) New Revision: 68631 Trac: http://trac.enlightenment.org/e/changeset/68631 Modified: trunk/PROTO/elev8/configure.ac Modified: trunk/PROTO/elev8/configure.ac === --- trunk/PROTO/elev8/configure.ac 2012-03-02 17:41:20 UTC (rev 68630) +++ trunk/PROTO/elev8/configure.ac 2012-03-02 17:41:22 UTC (rev 68631) @@ -117,8 +117,10 @@ ]], [[ n = v8::Persistentv8::Number::New(v8::Number::New(0)); + v8::Handlev8::Object o = v8::Object::New(); + o-HasOwnProperty(v8::String::New(bazinga)); ]], -)],[V8_LIBS=-lv8], AC_MSG_ERROR([elev8 requires libv8])) +)],[V8_LIBS=-lv8], AC_MSG_ERROR([elev8 requires libv8 = 3.5.0])) LIBS=$saved_LIBS AC_MSG_RESULT([yes]) AC_LANG_POP -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx trunk/PROTO/elev8/src/modules/http
One comment to this commit. On Fri, Mar 2, 2012 at 5:39 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Remove HTTP module compile-time warnings Author: acidx Date: 2012-03-01 12:39:19 -0800 (Thu, 01 Mar 2012) New Revision: 68596 Trac: http://trac.enlightenment.org/e/changeset/68596 Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc Modified: trunk/PROTO/elev8/src/modules/http/elev8_http.cc === --- trunk/PROTO/elev8/src/modules/http/elev8_http.cc2012-03-01 20:28:22 UTC (rev 68595) +++ trunk/PROTO/elev8/src/modules/http/elev8_http.cc2012-03-01 20:39:19 UTC (rev 68596) @@ -8,7 +8,7 @@ int XMLHttpRequest::fd_counter = 0; HandleObjectTemplate xmlHttpReqObj; -Eina_Bool data_callback(void *data, int type, void *event) +Eina_Bool data_callback(void *data, int, void *event) Why not use __UNUSED__ like the rest of EFL. { Ecore_Con_Event_Url_Data *url_data = (Ecore_Con_Event_Url_Data *)event; void *ptr = ecore_con_url_data_get(url_data-url_con); @@ -29,7 +29,7 @@ return EINA_FALSE; } -Eina_Bool completion_callback(void *data, int type, void *event) +Eina_Bool completion_callback(void *data, int, void *event) { HandleScope handle_scope; Ecore_Con_Event_Url_Complete *url_complete = (Ecore_Con_Event_Url_Complete *)event; @@ -81,7 +81,7 @@ out.write((char *)eina_binbuf_string_get(reqObj-data), eina_binbuf_length_get(reqObj-data)); out.close(); - HTTP_INF( Size of response Data = %lu bytes, + HTTP_INF( Size of response Data = %d bytes, eina_binbuf_length_get(reqObj-data)); reqObj-responseText = static_castPersistentString (String::New(buf)); } @@ -126,8 +126,7 @@ } HandleValue -response_text_getter(LocalString property, -const AccessorInfo info) +response_text_getter(LocalString, const AccessorInfo info) { LocalObject self = info.Holder(); LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0)); @@ -138,8 +137,7 @@ } HandleValue -status_getter(LocalString property, -const AccessorInfo info) +status_getter(LocalString, const AccessorInfo info) { LocalObject self = info.Holder(); LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0)); @@ -149,8 +147,7 @@ } HandleValue -readystate_getter(LocalString property, -const AccessorInfo info) +readystate_getter(LocalString, const AccessorInfo info) { LocalObject self = info.Holder(); LocalExternal wrap = LocalExternal::Cast(self-GetInternalField(0)); @@ -310,7 +307,7 @@ return Undefined(); } -HandleValue createXMLHttpReqInstance(const Arguments args) +HandleValue createXMLHttpReqInstance(const Arguments) { HandleScope scope; -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
Dear Leandro, This is very nice commit for elev8 modularization. Thanks. I have some problems compiling in my machine. Object::HasOwnProperty() is not to be found in v8.h. I did an apt-get update/upgrade and I did not find this in v8.h (version - 3.1.8.22) . The reference API page does provide this API though. Can you tell me which version of libv8 you have used? I would prefer to use the API's provided as part of distro. Regards, Sanjeev On Fri, Mar 2, 2012 at 3:35 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Allow loading modules in runtime There are now two kinds of modules: native (.so) and JavaScript (.js). Both modules can be loaded using the same interface and is completely transparent to the application developer, by using the global require() function. For example, to load the elementary module: elm = require('elm'); This will try to open 'libelm.so' in the current directory, then 'libelm.so' in elev8's module directory. If that fails, it will try to open 'elm.js' in the current directory, then 'elm.js' in elev8's directory. Should any of these attempts work, it will save the module in an internal cache and return a reference to an object containing all exported symbols from that module. The module loading path can be changed by changing the MODPATH environment variable in the same way one would set the PATH environment variable. To create a native module, one should create a RegisterModule(HandleObjectTemplatetarget) function, and manually add exported symbols to the target object. Be sure to ``export C'' it or else dlsym() will fail. JavaScript modules works pretty much the same way: they're created and executed in a separate context so that they do not mess up with the rest of the application (for instance, it is very easy to forget a ``var'' keyword, making a variable global -- imagine the mess a for (i = 0; i 10; i++) derp() would make). A global (to the module's context) object called ``exports'' must be used to export functions and globals: exports.pi = 3.14159265; exports.calculate_the_answer = function() { return Math.ceil((1337 * exports.pi) / 100.0); } Elev8 does not load all modules automatically anymore -- this is now controlled by the init.js script, which is loaded and interpreted at startup. This can be used to load other modules, define useful constants, this sort of thing. Care should be taken when using this file, though, since it is compiled and evaluated in the global context. Also, support for Eina_Module has been temporarily removed; it will be back, don't worry about it. This means that module shutdown functions have been temporarily removed as well. There are more important cleanups to be made in Elev8, so this will be postponed until further notice. Author: acidx Date: 2012-03-01 10:35:09 -0800 (Thu, 01 Mar 2012) New Revision: 68583 Trac: http://trac.enlightenment.org/e/changeset/68583 Added: trunk/PROTO/elev8/src/bin/init.js trunk/PROTO/elev8/src/modules/elm/elev8_elm.cc Removed: trunk/PROTO/elev8/src/bin/module.cc trunk/PROTO/elev8/src/modules/elm/elev8_elm.cc Modified: trunk/PROTO/elev8/src/bin/Makefile.am trunk/PROTO/elev8/src/bin/main.cc trunk/PROTO/elev8/src/modules/dbus/Makefile.am trunk/PROTO/elev8/src/modules/dbus/elev8_dbus.cc trunk/PROTO/elev8/src/modules/elm/Makefile.am trunk/PROTO/elev8/src/modules/http/Makefile.am trunk/PROTO/elev8/src/modules/http/elev8_http.cc Modified: trunk/PROTO/elev8/src/bin/Makefile.am === --- trunk/PROTO/elev8/src/bin/Makefile.am 2012-03-01 17:25:54 UTC (rev 68582) +++ trunk/PROTO/elev8/src/bin/Makefile.am 2012-03-01 18:35:09 UTC (rev 68583) @@ -12,14 +12,15 @@ -DPACKAGE_TMP_DIR=\/tmp\ \ @ELEV8_CFLAGS@ - bin_PROGRAMS = elev8 +elev8libdir = $(libdir)/elev8 +elev8lib_SCRIPTS = init.js + elev8_SOURCES = \ main.cc \ elev8_utils.cc \ - downloader.cc \ - module.cc + downloader.cc elev8_LDADD = @ELEV8_LIBS@ @V8_LIBS@ Modified: trunk/PROTO/elev8/src/bin/main.cc === --- trunk/PROTO/elev8/src/bin/main.cc 2012-03-01 17:25:54 UTC (rev 68582) +++ trunk/PROTO/elev8/src/bin/main.cc 2012-03-01 18:35:09 UTC (rev 68583) @@ -5,7 +5,6 @@ * then exit */ - #include sys/mman.h #include fcntl.h #include downloader.h @@ -16,13 +15,25 @@ using namespace v8; int elev8_log_domain = -1; -/* FIXME */ -void elm_v8_setup(HandleObjectTemplate global); -int xmlhttp_v8_setup(HandleObjectTemplate global); -int dbus_v8_setup(HandleObjectTemplate global); +#define MODLOAD_ENV MODPATH +#define MODLOAD_ENV_DEFAULT_DIRS .: PACKAGE_LIB_DIR +static PersistentObject module_cache; + +static HandleValue require(const Arguments args); +static
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
I am using 11.10. I will add the ppa to the version you have specified. On Fri, Mar 2, 2012 at 1:06 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Mar 1, 2012 at 11:27 PM, Elevate Efl eflel...@gmail.com wrote: Dear Leandro, This is very nice commit for elev8 modularization. Thanks. I have some problems compiling in my machine. Object::HasOwnProperty() is not to be found in v8.h. I did an apt-get update/upgrade and I did not find this in v8.h (version - 3.1.8.22) . If you use a distro that doesn't update SW versions between releases, it will not help doing apt-get update/upgrade The reference API page does provide this API though. Can you tell me which version of libv8 you have used? It's there since version 3.5.0. Here I have version 3.6.6.20 in Archlinux. I think Leandro is using the same version since he uses Archlinux too. I would prefer to use the API's provided as part of distro. What distro? If you are referring to Ubuntu, version 12.04 (which is LTS) is almost there and will contain a version 3.5.0 of libv8. Or you can probably add a ppa with a more recent version of libv8. Regards, Lucas De Marchi -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8/src: bin modules/dbus modules/elm modules/http
Do you think it is a good idea to add version check in configure.ac script? On Fri, Mar 2, 2012 at 1:13 PM, Elevate Efl eflel...@gmail.com wrote: I am using 11.10. I will add the ppa to the version you have specified. On Fri, Mar 2, 2012 at 1:06 PM, Lucas De Marchi lucas.demar...@profusion.mobi wrote: On Thu, Mar 1, 2012 at 11:27 PM, Elevate Efl eflel...@gmail.com wrote: Dear Leandro, This is very nice commit for elev8 modularization. Thanks. I have some problems compiling in my machine. Object::HasOwnProperty() is not to be found in v8.h. I did an apt-get update/upgrade and I did not find this in v8.h (version - 3.1.8.22) . If you use a distro that doesn't update SW versions between releases, it will not help doing apt-get update/upgrade The reference API page does provide this API though. Can you tell me which version of libv8 you have used? It's there since version 3.5.0. Here I have version 3.6.6.20 in Archlinux. I think Leandro is using the same version since he uses Archlinux too. I would prefer to use the API's provided as part of distro. What distro? If you are referring to Ubuntu, version 12.04 (which is LTS) is almost there and will contain a version 3.5.0 of libv8. Or you can probably add a ppa with a more recent version of libv8. Regards, Lucas De Marchi -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] Fwd: timeline is not in line
Awesome. On Mar 1, 2012 3:56 AM, Davide Andreoli d...@gurumeditation.it wrote: Il giorno 29 febbraio 2012 13:20, Bertrand Jacquin be...@meleeweb.net ha scritto: This is now up to date. Beber Super!! thnks ! D'ar Wednesday 29 a viz February 2012 e 11 eur 18, « Bertrand Jacquin » he deus skrivet : I can see that kind of things in logs : Feb 29 02:01:16 enlightenment2 Trac[svn_fs] DEBUG: Subversion bindings imported Feb 29 02:01:16 enlightenment2 Trac[cache] INFO: repos rev [68544] != cached rev [68387] Feb 29 02:01:17 enlightenment2 Trac[api] INFO: Synchronized '' repository in 0.05 seconds This indicated that repository is not synced anymore. I did run the following on e2 to fix that : # trac-admin /srv/web/trac.enlightenment.org/e repository resync * It take a (long) time to complete and is asynchronous. There is only ~55000 commits to sync now. Beber D'ar Wednesday 29 a viz February 2012 e 10 eur 08, « Cedric BAIL » he deus skrivet : Houston, we have a problem ! Trac as commited succide and does'nt update anymore ! -- Forwarded message -- From: Daniel Juyung Seo seojuyu...@gmail.com Date: Wed, Feb 29, 2012 at 3:58 AM Subject: Re: [E-devel] timeline is not in line To: Enlightenment developer list enlightenment-devel@lists.sourceforge.net Cc: P Purkayastha ppu...@gmail.com Hello, On Tue, Feb 28, 2012 at 7:08 PM, Carsten Haitzler ras...@rasterman.comwrote: On Tue, 28 Feb 2012 14:56:13 +0800 P Purkayastha ppu...@gmail.com said: yeah - i know. sometimes it gets stuck. this time its just stopped. i dont know why - have work to do. svn keeps working - trac has just stopped updating. i have no intention of fixing this any time soon if ever as i generally despise dealing with trac. :( This is annoying and trac source browser is not working. http://trac.enlightenment.org/e/browser If you have any hint how to fix this, I'll try to handle this. Daniel Juyung Seo (SeoZ) Something seems to be the matter with timeline - http://trac.enlightenment.org/e/timeline It shows that there has been no commits for over 4 days. Surely, our e devs will have major withdrawal symptoms without their daily commit fix, let alone go without commits for 4 days. That leaves only timeline (or the server it monitors) as the likely culprit. (PS: had sent this several hours ago through google groups, but that mail seems to have been lost in the dungeons somewhere) -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Cedric BAIL -- Beber -- Beber -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud
Re: [E-devel] [patch] elm_genlist - add item flip set/get
Const for param? On Feb 29, 2012 9:19 PM, Hyoyoung Chang hyoyo...@gmail.com wrote: Dear all. I made a patch to introduce new genlist item mode. Two public apis are added. +EAPI void elm_genlist_item_flip_set(Elm_Object_Item *it, Eina_Bool flip); +EAPI Eina_Bool elm_genlist_item_flip_get(Elm_Object_Item *it); It provides on-the-flying item change. It works like that a new item added on existed item. In elementary test, you can test it. It's useful at adding widgets or show buttons in genlist item. Thanks. -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
[E-devel] Patch for deprecating enum.
Kindly suggest if there is a better way. Regards, Sanjeev From e416dc65d91ade776aa83bcb558faebf84045939 Mon Sep 17 00:00:00 2001 From: Sanjeev BA iamsanj...@gmail.com Date: Thu, 1 Mar 2012 11:22:55 +0900 Subject: [PATCH 3/3] Rename enum based on review comment. Signed-off-by: Sanjeev BA iamsanj...@gmail.com --- trunk/elementary/doc/examples.dox |2 +- trunk/elementary/src/lib/elm_calendar.c |6 ++-- trunk/elementary/src/lib/elm_calendar.h | 32 ++ 3 files changed, 23 insertions(+), 17 deletions(-) diff --git a/trunk/elementary/doc/examples.dox b/trunk/elementary/doc/examples.dox index 9b08137..8701e77 100644 --- a/trunk/elementary/doc/examples.dox +++ b/trunk/elementary/doc/examples.dox @@ -1325,7 +1325,7 @@ * Periodicity is how frequently the mark will be displayed over the * calendar. Can be a unique mark (that don't repeat), or it can repeat * daily, weekly, monthly or annually. It's enumerated by - * @c Elm_Calendar_Mark_Repeat. + * @c Elm_Calendar_Mark_Repeat_Type. * * So let's add some marks to our calendar. We will add christmas holiday, * set Sundays as holidays, and check current day and day after that. diff --git a/trunk/elementary/src/lib/elm_calendar.c b/trunk/elementary/src/lib/elm_calendar.c index 5f82b7c..e2ffb62 100644 --- a/trunk/elementary/src/lib/elm_calendar.c +++ b/trunk/elementary/src/lib/elm_calendar.c @@ -39,7 +39,7 @@ struct _Elm_Calendar_Mark Eina_List *node; struct tm mark_time; const char *mark_type; - Elm_Calendar_Mark_Repeat repeat; + Elm_Calendar_Mark_Repeat_Type repeat; }; static const char *widtype = NULL; @@ -69,7 +69,7 @@ static int _days_in_month[2][12] = }; static Elm_Calendar_Mark * -_mark_new(Evas_Object *obj, const char *mark_type, struct tm *mark_time, Elm_Calendar_Mark_Repeat repeat) +_mark_new(Evas_Object *obj, const char *mark_type, struct tm *mark_time, Elm_Calendar_Mark_Repeat_Type repeat) { Widget_Data *wd = elm_widget_data_get(obj); Elm_Calendar_Mark *mark; @@ -937,7 +937,7 @@ elm_calendar_format_function_set(Evas_Object *obj, char * (*format_function) (st } EAPI Elm_Calendar_Mark * -elm_calendar_mark_add(Evas_Object *obj, const char *mark_type, struct tm *mark_time, Elm_Calendar_Mark_Repeat repeat) +elm_calendar_mark_add(Evas_Object *obj, const char *mark_type, struct tm *mark_time, Elm_Calendar_Mark_Repeat_Type repeat) { ELM_CHECK_WIDTYPE(obj, widtype) NULL; Widget_Data *wd = elm_widget_data_get(obj); diff --git a/trunk/elementary/src/lib/elm_calendar.h b/trunk/elementary/src/lib/elm_calendar.h index 0d0d284..e119fe6 100644 --- a/trunk/elementary/src/lib/elm_calendar.h +++ b/trunk/elementary/src/lib/elm_calendar.h @@ -26,9 +26,18 @@ * @{ */ +typedef enum +{ + ELM_CALENDAR_UNIQUE, /** Default value. Marks will be displayed only on event day. */ + ELM_CALENDAR_DAILY, /** Marks will be displayed everyday after event day (inclusive). */ + ELM_CALENDAR_WEEKLY, /** Marks will be displayed every week after event day (inclusive) - i.e. each seven days. */ + ELM_CALENDAR_MONTHLY, /** Marks will be displayed every month day that coincides to event day. E.g.: if an event is set to 30th Jan, no marks will be displayed on Feb, but will be displayed on 30th Mar*/ + ELM_CALENDAR_ANNUALLY /** Marks will be displayed every year that coincides to event day (and month). E.g. an event added to 30th Jan 2012 will be repeated on 30th Jan 2013. */ +} _Elm_Calendar_Mark_Repeat_Type; + /** - * @enum _Elm_Calendar_Mark_Repeat - * @typedef Elm_Calendar_Mark_Repeat + * @enum _Elm_Calendar_Mark_Repeat_Type + * @typedef Elm_Calendar_Mark_Repeat_Type * * Event periodicity, used to define if a mark should be repeated * @b beyond event's day. It's set when a mark is added. @@ -43,17 +52,14 @@ * * @ingroup Calendar */ -typedef enum -{ - ELM_CALENDAR_UNIQUE, /** Default value. Marks will be displayed only on event day. */ - ELM_CALENDAR_DAILY, /** Marks will be displayed everyday after event day (inclusive). */ - ELM_CALENDAR_WEEKLY, /** Marks will be displayed every week after event day (inclusive) - i.e. each seven days. */ - ELM_CALENDAR_MONTHLY, /** Marks will be displayed every month day that coincides to event day. E.g.: if an event is set to 30th Jan, no marks will be displayed on Feb, but will be displayed on 30th Mar*/ - ELM_CALENDAR_ANNUALLY /** Marks will be displayed every year that coincides to event day (and month). E.g. an event added to 30th Jan 2012 will be repeated on 30th Jan 2013. */ -} Elm_Calendar_Mark_Repeat; -// XXX: Elm_Calendar_Mark_Repeat_Type +typedef _Elm_Calendar_Mark_Repeat_Type Elm_Calendar_Mark_Repeat_Type; + +/* + * @deprecated Use Elm_Calendar_Mark_Repeat_Type + */ +typedef _Elm_Calendar_Mark_Repeat_Type Elm_Calendar_Mark_Repeat EINA_DEPRECATED; -typedef struct _Elm_Calendar_Mark Elm_Calendar_Mark;/** Item handle for a calendar mark. Created with elm_calendar_mark_add() and deleted with
Re: [E-devel] Patch for deprecating enum.
On Thu, Mar 1, 2012 at 11:38 AM, Daniel Juyung Seo seojuyu...@gmail.comwrote: This looks good :) 1. I kindly recommend to add below line to elm_deprecated.h typedef _Elm_Calendar_Mark_Repeat_Type Elm_Calendar_Mark_Repeat EINA_DEPRECATED; Ok. 2. Why did you make this change? -typedef struct _Elm_Calendar_Mark Elm_Calendar_Mark;/** Item handle for a calendar mark. Created with elm_calendar_mark_add() and deleted with elm_calendar_mark_del(). */ +typedef struct _Elm_Calendar_Mark Elm_Calendar_Mark ;/** Item handle for a calendar mark. Created with elm_calendar_mark_add() and deleted with elm_calendar_mark_del(). */ Oops..unintended typo. Will fix that one. Thanks! Daniel Juyung Seo (SeoZ) On Thu, Mar 1, 2012 at 11:26 AM, Elevate Efl eflel...@gmail.com wrote: Kindly suggest if there is a better way. Regards, Sanjeev -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elm_panes.h
In svn. http://trac.enlightenment.org/e/changeset/68527 Thanks, Sanjeev On Wed, Feb 29, 2012 at 11:49 AM, Daniel Juyung Seo seojuyu...@gmail.comwrote: Hello, On Wed, Feb 29, 2012 at 1:09 AM, J??r??my Zurcher jer...@asynk.ch wrote: we have 2 body less functions in elm_panes - elm_panes_content_right_size_get - elm_panes_content_right_size_set as Michael didn't seem too kind to feed the body and fix the header with my first patch, I then sent the kill the head patch. Thank for the explanation. feed sounds good to me :) Daniel Juyung Seo (SeoZ) feed the body or kill the head, you choose. Jeremy On Tuesday 28 February 2012 23:27, Daniel Juyung Seo wrote : Same comment here. Why are you trying to remove them from h even you added them to c? Daniel Juyung Seo (SeoZ) On Tue, Feb 28, 2012 at 6:12 PM, Jeremy Zurcher jer...@asynk.ch wrote: if you prefer, get rid of elm_panes_content_right_size_* in header Jeremy -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] elev8: Function/parameter/class naming scheme
I believe this topic has received enough attention (more than what it deserves actually) Can we freeze on CamelCase please ? On Tue, Feb 28, 2012 at 9:07 AM, Carsten Haitzler ras...@rasterman.comwrote: On Mon, 27 Feb 2012 15:51:04 -0300 Gustavo Sverzut Barbieri barbi...@profusion.mobi said: On Monday, February 27, 2012, Iván Briano (Sachiel) wrote: 2012/2/27 Lucas De Marchi lucas.demar...@profusion.mobijavascript:;: On Mon, Feb 27, 2012 at 11:47 AM, Cedric BAIL cedric.b...@free.frjavascript:; wrote: On Mon, Feb 27, 2012 at 3:40 PM, Ulisses Furquim ulis...@profusion.mobi javascript:; wrote: On Sat, Feb 25, 2012 at 4:27 AM, Daniel Juyung Seo seojuyu...@gmail.com javascript:; wrote: Good topic. Agreed on my side :) elev8 is for JavaScript programmer and EFL background is not needed to use elev8. Here we go CamelCase! +1 for CamelCase My understanding of this thread is that no one is opposing the Camel ! So we can do the switch asap. Yeah, I know we have lost raster's mind with this thread, that's a poor side effect :-) Yeah... we will just get burned if we don't use the same coding style js developers are used to. I don't like CamelCase but I use it where and when it's appropriate. Let's go for it then. FUCK CAMELCASE. LET'S GO ALL CAPS. Thats COBOL :-) COBOL RULES. STOP RUN. -- - Codito, ergo sum - I code, therefore I am -- The Rasterman (Carsten Haitzler)ras...@rasterman.com -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] [patch] elm_cnp - revise document
Agree. Hyoyoung already has the relevant links. He can provide them. Also, some typos can be fixed in this patch. It's not = It does not Format is used for specified its type = Format is used to specify its type Clear all informations = Clear all information Regards, Sanjeev On Tue, Feb 28, 2012 at 2:00 PM, Michael Blumenkrantz michael.blumenkra...@gmail.com wrote: On Tue, 28 Feb 2012 13:55:59 +0900 Hyoyoung Chang hyoyo...@gmail.com wrote: Dear all. As i said earlier, elm_cnp's document is revised. I add information about x11 and make some comment clear. Thanks Hi, IMO a link to the page describing X cut buffers is sufficient here; 99% of readers will probably 1) already know this information; 2) not understand it; 3) not need it Thoughts? -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib
Applications depending on _MAX behaviour or its value, are already asking for trouble in multiple ways. I have seen plenty of example of _MAX abuse. For such apps., I would rather not have _MAX, than have it and fix their app. logic. Having MAX and adding new enums, changes the value of '_MAX' for apps that use and depend on it. Isn't that good enough a reason for not having _MAX? I don't want to consider other libraries in EFL for this specific case, since I find it inconsistent across libraries. (for ex., elementary has ~50 enums and only one in genlist uses _MAX). On the lighter side, think of the potential savings in application support time :) On Fri, Feb 24, 2012 at 11:30 PM, Daniel Juyung Seo seojuyu...@gmail.comwrote: On Fri, Feb 24, 2012 at 9:24 AM, Elevate Efl eflel...@gmail.com wrote: No. *_MAX really doesn't give the app. developer anything useful. Hello, It has been added for the convenience (bounds checking) of the widget implementation. Exactly, that's why they're needed. Without it, if the last member of the enum is changed, all application have to change their error check code. If we expose _MAX we need to tell the app. developer what is the expected behaviour if he uses it, which is unnecessary. This is common and other EFL libraries also use MAX value. Can you consider this again? Daniel Juyung Seo (SeoZ) On Fri, Feb 24, 2012 at 1:16 AM, Tom Hacohen tom.haco...@samsung.com wrote: REVERT! :) Really though, judging from Daniel's comment it sounds like someone should revert it. -- Tom. On 23/02/12 18:12, Daniel Juyung Seo wrote: Dear Sanjeev, On Thu, Feb 23, 2012 at 11:52 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Remove MAX, it is not useful for app. developers. This means new selection type will never be added? Daniel Juyung Seo (SeoZ) Signed-off-by: Sanjeev BAeflel...@gmail.com Author: sanjeev Date: 2012-02-22 18:52:07 -0800 (Wed, 22 Feb 2012) New Revision: 68291 Trac: http://trac.enlightenment.org/e/changeset/68291 Modified: trunk/elementary/src/lib/elm_cnp.c trunk/elementary/src/lib/elm_cnp.h Modified: trunk/elementary/src/lib/elm_cnp.c === --- trunk/elementary/src/lib/elm_cnp.c 2012-02-23 02:52:00 UTC (rev 68290) +++ trunk/elementary/src/lib/elm_cnp.c 2012-02-23 02:52:07 UTC (rev 68291) @@ -324,7 +324,7 @@ }, }; -static Cnp_Selection selections[ELM_SEL_TYPE_MAX] = { +static Cnp_Selection selections[ELM_SEL_TYPE_CLIPBOARD + 1] = { ARRAYINIT(ELM_SEL_TYPE_PRIMARY) { .debug = Primary, .ecore_sel = ECORE_X_SELECTION_PRIMARY, @@ -339,6 +339,11 @@ .clear = ecore_x_selection_secondary_clear, .request = ecore_x_selection_secondary_request, }, + ARRAYINIT(ELM_SEL_TYPE_XDND) { + .debug = XDnD, + .ecore_sel = ECORE_X_SELECTION_XDND, + .request = ecore_x_selection_xdnd_request, + }, ARRAYINIT(ELM_SEL_TYPE_CLIPBOARD) { .debug = Clipboard, .ecore_sel = ECORE_X_SELECTION_CLIPBOARD, @@ -346,11 +351,6 @@ .clear = ecore_x_selection_clipboard_clear, .request = ecore_x_selection_clipboard_request, }, - ARRAYINIT(ELM_SEL_TYPE_XDND) { - .debug = XDnD, - .ecore_sel = ECORE_X_SELECTION_XDND, - .request = ecore_x_selection_xdnd_request, - }, }; /* Data for DND in progress */ @@ -400,7 +400,7 @@ if (top) xwin = elm_win_xwindow_get(top); else xwin = elm_win_xwindow_get(obj); - if ((!xwin) || (selection= ELM_SEL_TYPE_MAX)) + if ((!xwin) || (selection ELM_SEL_TYPE_CLIPBOARD)) return EINA_FALSE; if (!_elm_cnp_init_count) _elm_cnp_init(); if ((!selbuf) (format != ELM_SEL_FORMAT_IMAGE)) @@ -438,7 +438,7 @@ #ifdef HAVE_ELEMENTARY_X Cnp_Selection *sel; - if ((unsigned int)selection= (unsigned int)ELM_SEL_TYPE_MAX) + if ((unsigned int)selection (unsigned int)ELM_SEL_TYPE_CLIPBOARD) return EINA_FALSE; if (!_elm_cnp_init_count) _elm_cnp_init(); @@ -470,7 +470,7 @@ Evas_Object *top; Cnp_Selection *sel; - if (selection= ELM_SEL_TYPE_MAX) + if (selection ELM_SEL_TYPE_CLIPBOARD) return EINA_FALSE; if (!_elm_cnp_init_count) _elm_cnp_init(); @@ -519,13 +519,13 @@ Cnp_Selection *sel; int i; - for (i = 0; i ELM_SEL_TYPE_MAX; i++) + for (i = 0; i= ELM_SEL_TYPE_CLIPBOARD; i++) { if (selections[i].ecore_sel == ev-selection) break; } cnp_debug(selection %d clear\n, i); /* Not me... Don't care */ - if (i == ELM_SEL_TYPE_MAX) return ECORE_CALLBACK_PASS_ON
Re: [E-devel] E SVN: acidx IN trunk/PROTO/elev8: data/javascript src/modules/elm
Works pretty neat. Good. Thanks, Sanjeev On Sat, Feb 25, 2012 at 5:13 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elev8: Implement naviframe object. Included naviframe.js is adapted from pager.js. Author: acidx Date: 2012-02-24 12:13:40 -0800 (Fri, 24 Feb 2012) New Revision: 68428 Trac: http://trac.enlightenment.org/e/changeset/68428 Added: trunk/PROTO/elev8/data/javascript/naviframe.js Modified: trunk/PROTO/elev8/src/modules/elm/elev8_elm.cc Modified: trunk/PROTO/elev8/src/modules/elm/elev8_elm.cc === --- trunk/PROTO/elev8/src/modules/elm/elev8_elm.cc 2012-02-24 17:58:50 UTC (rev 68427) +++ trunk/PROTO/elev8/src/modules/elm/elev8_elm.cc 2012-02-24 20:13:40 UTC (rev 68428) @@ -5858,6 +5858,90 @@ { NULL, NULL, NULL }, }; +class CElmNaviframe : public CEvasObject { +protected: + CPropHandlerCElmNaviframe prop_handler; + +public: + CElmNaviframe(CEvasObject *parent, LocalObject obj) : + CEvasObject(), + prop_handler(property_list_base) + { +eo = elm_naviframe_add(parent-top_widget_get()); +construct(eo, obj); +get_object()-Set(String::New(pop), FunctionTemplate::New(pop)-GetFunction()); +get_object()-Set(String::New(push), FunctionTemplate::New(push)-GetFunction()); + } + + static HandleValue pop(const Arguments args) + { +CEvasObject *self = eo_from_info(args.This()); +CElmNaviframe *naviFrame = static_castCElmNaviframe *(self); + +if (elm_naviframe_top_item_get(naviFrame-get())) + elm_naviframe_item_pop(naviFrame-get()); + +return Undefined(); + } + + static HandleValue push(const Arguments args) + { +CEvasObject *self = eo_from_info(args.This()); +CElmNaviframe *naviFrame = static_castCElmNaviframe *(self); +CEvasObject *prev_btn, *next_btn, *content; +bool has_prev_btn = false, has_next_btn = false; + +if (!args[0]-IsObject()) + return ThrowException(Exception::Error(String::New(Parameter 1 should be an object description))); + +if (!args[1]-IsString()) + return ThrowException(Exception::Error(String::New(Parameter 2 should be a string))); + +if (args.Length() = 3) { + if (!args[2]-IsObject()) + return ThrowException(Exception::Error(String::New(Parameter 3 should either be undefined or an object description))); + has_prev_btn = true; +} + +if (args.Length() = 4) { + if (!args[3]-IsObject()) + return ThrowException(Exception::Error(String::New(Parameter 4 should either be undefined or an object description))); + has_next_btn = true; +} + +content = realize_one(naviFrame, args[0]); +if (!content) + return ThrowException(Exception::Error(String::New(Could not create content from description))); + +if (has_prev_btn) + { + prev_btn = realize_one(naviFrame, args[2]-ToObject()); + if (!prev_btn) + return ThrowException(Exception::Error(String::New(Could not create back button from description))); + } +if (has_next_btn) + { + next_btn = realize_one(naviFrame, args[3]-ToObject()); + if (!next_btn) + return ThrowException(Exception::Error(String::New(Could not create next button from description))); + } + +String::Utf8Value titleParam(args[1]-ToString()); +elm_naviframe_item_push(naviFrame-get(), +*titleParam, +has_prev_btn ? prev_btn-get() : 0, +has_next_btn ? next_btn-get() : 0, +content-get(), +0); +return Undefined(); + } +}; + +template CEvasObject::CPropHandlerCElmNaviframe::property_list +CEvasObject::CPropHandlerCElmNaviframe::list[] = { + { NULL, NULL, NULL }, +}; + class CElmGrid : public CEvasObject { protected: CPropHandlerCElmGrid prop_handler; @@ -6241,6 +6325,8 @@ eo = new CElmNotify(parent,obj); else if (!strcmp(*str, pager)) eo = new CElmPager(parent,obj); + else if (!strcmp(*str, naviframe)) + eo = new CElmNaviframe(parent,obj); else if (!strcmp(*str, grid)) eo = new CElmGrid(parent,obj); -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-svn mailing list
Re: [E-devel] E SVN: sanjeev trunk/elementary/src/lib
No. *_MAX really doesn't give the app. developer anything useful. It has been added for the convenience (bounds checking) of the widget implementation. If we expose _MAX we need to tell the app. developer what is the expected behaviour if he uses it, which is unnecessary. On Fri, Feb 24, 2012 at 1:16 AM, Tom Hacohen tom.haco...@samsung.comwrote: REVERT! :) Really though, judging from Daniel's comment it sounds like someone should revert it. -- Tom. On 23/02/12 18:12, Daniel Juyung Seo wrote: Dear Sanjeev, On Thu, Feb 23, 2012 at 11:52 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Remove MAX, it is not useful for app. developers. This means new selection type will never be added? Daniel Juyung Seo (SeoZ) Signed-off-by: Sanjeev BAeflel...@gmail.com Author: sanjeev Date: 2012-02-22 18:52:07 -0800 (Wed, 22 Feb 2012) New Revision: 68291 Trac: http://trac.enlightenment.org/e/changeset/68291 Modified: trunk/elementary/src/lib/elm_cnp.c trunk/elementary/src/lib/elm_cnp.h Modified: trunk/elementary/src/lib/elm_cnp.c === --- trunk/elementary/src/lib/elm_cnp.c 2012-02-23 02:52:00 UTC (rev 68290) +++ trunk/elementary/src/lib/elm_cnp.c 2012-02-23 02:52:07 UTC (rev 68291) @@ -324,7 +324,7 @@ }, }; -static Cnp_Selection selections[ELM_SEL_TYPE_MAX] = { +static Cnp_Selection selections[ELM_SEL_TYPE_CLIPBOARD + 1] = { ARRAYINIT(ELM_SEL_TYPE_PRIMARY) { .debug = Primary, .ecore_sel = ECORE_X_SELECTION_PRIMARY, @@ -339,6 +339,11 @@ .clear = ecore_x_selection_secondary_clear, .request = ecore_x_selection_secondary_request, }, + ARRAYINIT(ELM_SEL_TYPE_XDND) { + .debug = XDnD, + .ecore_sel = ECORE_X_SELECTION_XDND, + .request = ecore_x_selection_xdnd_request, + }, ARRAYINIT(ELM_SEL_TYPE_CLIPBOARD) { .debug = Clipboard, .ecore_sel = ECORE_X_SELECTION_CLIPBOARD, @@ -346,11 +351,6 @@ .clear = ecore_x_selection_clipboard_clear, .request = ecore_x_selection_clipboard_request, }, - ARRAYINIT(ELM_SEL_TYPE_XDND) { - .debug = XDnD, - .ecore_sel = ECORE_X_SELECTION_XDND, - .request = ecore_x_selection_xdnd_request, - }, }; /* Data for DND in progress */ @@ -400,7 +400,7 @@ if (top) xwin = elm_win_xwindow_get(top); else xwin = elm_win_xwindow_get(obj); - if ((!xwin) || (selection= ELM_SEL_TYPE_MAX)) + if ((!xwin) || (selection ELM_SEL_TYPE_CLIPBOARD)) return EINA_FALSE; if (!_elm_cnp_init_count) _elm_cnp_init(); if ((!selbuf) (format != ELM_SEL_FORMAT_IMAGE)) @@ -438,7 +438,7 @@ #ifdef HAVE_ELEMENTARY_X Cnp_Selection *sel; - if ((unsigned int)selection= (unsigned int)ELM_SEL_TYPE_MAX) + if ((unsigned int)selection (unsigned int)ELM_SEL_TYPE_CLIPBOARD) return EINA_FALSE; if (!_elm_cnp_init_count) _elm_cnp_init(); @@ -470,7 +470,7 @@ Evas_Object *top; Cnp_Selection *sel; - if (selection= ELM_SEL_TYPE_MAX) + if (selection ELM_SEL_TYPE_CLIPBOARD) return EINA_FALSE; if (!_elm_cnp_init_count) _elm_cnp_init(); @@ -519,13 +519,13 @@ Cnp_Selection *sel; int i; - for (i = 0; i ELM_SEL_TYPE_MAX; i++) + for (i = 0; i= ELM_SEL_TYPE_CLIPBOARD; i++) { if (selections[i].ecore_sel == ev-selection) break; } cnp_debug(selection %d clear\n, i); /* Not me... Don't care */ - if (i == ELM_SEL_TYPE_MAX) return ECORE_CALLBACK_PASS_ON; + if (i ELM_SEL_TYPE_CLIPBOARD) return ECORE_CALLBACK_PASS_ON; sel = selections + i; sel-active = EINA_FALSE; @@ -556,9 +556,6 @@ cnp_debug(selection notify callback: %d\n,ev-selection); switch (ev-selection) { - case ECORE_X_SELECTION_CLIPBOARD: - sel = selections + ELM_SEL_TYPE_CLIPBOARD; - break; case ECORE_X_SELECTION_PRIMARY: sel = selections + ELM_SEL_TYPE_PRIMARY; break; @@ -568,6 +565,9 @@ case ECORE_X_SELECTION_XDND: sel = selections + ELM_SEL_TYPE_XDND; break; + case ECORE_X_SELECTION_CLIPBOARD: + sel = selections + ELM_SEL_TYPE_CLIPBOARD; + break; default: return ECORE_CALLBACK_PASS_ON; } @@ -600,7 +600,7 @@ Cnp_Selection *sel = selections + *((int *)data); if (sel-active (sel-format= ELM_SEL_FORMAT_TARGETS) -(sel-format ELM_SEL_FORMAT_MAX)) +(sel-format= ELM_SEL_FORMAT_HTML)) return sel-format; } return ELM_SEL_FORMAT_NONE; Modified: trunk/elementary/src/lib/elm_cnp.h
Re: [E-devel] E SVN: sanjeev IN trunk/elementary/src: bin lib
I agree it is helpful. Done. On Fri, Feb 24, 2012 at 1:21 AM, Daniel Juyung Seo seojuyu...@gmail.comwrote: I encourage you to add deprecated apis into elm_deprecated.h and edit ElementaryChanges wiki page. Without them, many people will waste their time on tracing down the changes. http://trac.enlightenment.org/e/wiki/ElementaryChanges We need to talk about that :) Daniel Juyung Seo (SeoZ) On Thu, Feb 23, 2012 at 11:52 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Fix a few more review comments for cnp. Signed-off-by: Sanjeev BA eflel...@gmail.com Author: sanjeev Date: 2012-02-22 18:52:11 -0800 (Wed, 22 Feb 2012) New Revision: 68292 Trac: http://trac.enlightenment.org/e/changeset/68292 Modified: trunk/elementary/src/bin/test_cnp.c trunk/elementary/src/lib/elm_cnp.c trunk/elementary/src/lib/elm_cnp.h trunk/elementary/src/lib/elm_entry.c Modified: trunk/elementary/src/bin/test_cnp.c === --- trunk/elementary/src/bin/test_cnp.c 2012-02-23 02:52:07 UTC (rev 68291) +++ trunk/elementary/src/bin/test_cnp.c 2012-02-23 02:52:11 UTC (rev 68292) @@ -32,7 +32,7 @@ Evas_Object *en = (Evas_Object*)(data); elm_object_text_set(glb, ); - elm_cnp_selection_clear(ELM_SEL_TYPE_CLIPBOARD, elm_object_parent_widget_get(en)); + elm_object_cnp_selection_clear(elm_object_parent_widget_get(en), ELM_SEL_TYPE_CLIPBOARD); } void Modified: trunk/elementary/src/lib/elm_cnp.c === --- trunk/elementary/src/lib/elm_cnp.c 2012-02-23 02:52:07 UTC (rev 68291) +++ trunk/elementary/src/lib/elm_cnp.c 2012-02-23 02:52:11 UTC (rev 68292) @@ -404,7 +404,7 @@ return EINA_FALSE; if (!_elm_cnp_init_count) _elm_cnp_init(); if ((!selbuf) (format != ELM_SEL_FORMAT_IMAGE)) - return elm_cnp_selection_clear(selection, obj); + return elm_object_cnp_selection_clear(obj, selection); sel = selections + selection; @@ -433,7 +433,7 @@ } EAPI Eina_Bool -elm_cnp_selection_clear(Elm_Sel_Type selection, Evas_Object *obj) +elm_object_cnp_selection_clear(Evas_Object *obj, Elm_Sel_Type selection) { #ifdef HAVE_ELEMENTARY_X Cnp_Selection *sel; Modified: trunk/elementary/src/lib/elm_cnp.h === --- trunk/elementary/src/lib/elm_cnp.h 2012-02-23 02:52:07 UTC (rev 68291) +++ trunk/elementary/src/lib/elm_cnp.h 2012-02-23 02:52:11 UTC (rev 68292) @@ -11,8 +11,6 @@ * * @{ */ -typedef struct _Elm_Selection_Data Elm_Selection_Data; -typedef Eina_Bool(*Elm_Drop_Cb)(void *d, Evas_Object *o, Elm_Selection_Data *data); /** * Defines the types of selection property names. @@ -21,12 +19,15 @@ */ typedef enum { - ELM_SEL_TYPE_PRIMARY, //primary text selection + ELM_SEL_TYPE_PRIMARY, // refers to primary text selection ELM_SEL_TYPE_SECONDARY, // used when primary selection is in use. - ELM_SEL_TYPE_XDND, //drag and drop - ELM_SEL_TYPE_CLIPBOARD, // highlighted text + ELM_SEL_TYPE_XDND, // drag and drop + ELM_SEL_TYPE_CLIPBOARD, // selected text } Elm_Sel_Type; +/** + * Defines the types of target. + */ typedef enum { /** Targets: for matching every atom requesting */ @@ -45,15 +46,29 @@ ELM_SEL_FORMAT_HTML = 0x10, } Elm_Sel_Format; +/** + * Structure holding the info about selected data. + */ struct _Elm_Selection_Data { - intx, y; + Evas_Coord x, y; Elm_Sel_Format format; void *data; size_t len; }; +typedef struct _Elm_Selection_Data Elm_Selection_Data; /** + * Callback invoked in when the selected data is 'dropped' at its destination. + * + * @param d Application specific data + * @param o The evas object where selected data is 'dropped'. + * @param data struct holding information about selected data + */ +typedef Eina_Bool (*Elm_Drop_Cb)(void *d, Evas_Object *o, Elm_Selection_Data *data); + + +/** * @brief Set copy and paste data to a widget. * * XXX: need to be rewritten. @@ -108,23 +123,19 @@ Elm_Drop_Cb datacb, void *udata); /** - * @brief Clear the copy and paste data in the widget. + * @brief Clear the selected/copied data in the widget. * - * Clear the data in the widget. Normally this function isn't need to call. - * * @see also elm_cnp_selection_set() * + * @param obj The source widget pointer * @param selection Selection type for copying and pasting - * @param obj The source widget pointer * @return If EINA_TRUE, clearing data is success. * * @ingroup CopyPaste * */ -// XXX: EAPI void elm_object_cnp_selection_clear(Evas_Object *obj, -//
Re: [E-devel] elev8: Function/parameter/class naming scheme
This complaint was raised already, thought about and rejected, because elev8 was in prototype phase and we wanted to follow EFL style to be consistent with the rest of the code base. For the advanced use cases, I do see your point. Users of elev8 'API' might end up having a mix of their style and EFL style in their code. But isn't that the case with using any third party library? (FYI : DART follows camel case as well, but with some variations) http://www.dartlang.org/articles/style-guide/#names But camel case, seems like an agreed upon style for C++ across many projects. Since elev8 is quite small in code size, now would be a good time to change the style. I can see prospective users complaining about readability of the code. On Fri, Feb 24, 2012 at 5:16 AM, Leandro Pereira lean...@profusion.mobiwrote: Hi. I'd like to propose we move the naming scheme of Elev8's API to CamelCase, so that it is more consistent with other things our target developers might be using. JavaScript itself, Node.js, jQuery, and even Tizen APIs (at least the ones I've looked into -- WebRuntime stuff to be more precise) uses this scheme. I'm proposing this because we're working on a JavaScript framework to develop applications in EFL using Elev8 as a base. And although the idea is to completely hide what's below (where naming wouldn't matter because it'd be inside a library the user would import), eventually for certain more advanced tasks, this might be possible and I'd like to maintain consistency and, most importantly, a sense of familiarity to the target developer base. Any point against this change in elev8? Are there any major changes waiting to be merged that I should worry about? Cheers, Leandro -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: hermet trunk/elementary/src/lib
ah..missed that one. Thanks. On Fri, Feb 24, 2012 at 3:50 PM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: elenmentary/route - --warning. Author: hermet Date: 2012-02-23 22:50:48 -0800 (Thu, 23 Feb 2012) New Revision: 68384 Trac: http://trac.enlightenment.org/e/changeset/68384 Modified: trunk/elementary/src/lib/elm_route.c Modified: trunk/elementary/src/lib/elm_route.c === --- trunk/elementary/src/lib/elm_route.c2012-02-24 06:28:40 UTC (rev 68383) +++ trunk/elementary/src/lib/elm_route.c2012-02-24 06:50:48 UTC (rev 68384) @@ -300,7 +300,7 @@ EAPI void elm_route_longitude_min_max_get(const Evas_Object *obj, double *min, double *max) { - ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE; + ELM_CHECK_WIDTYPE(obj, widtype); Widget_Data *wd = elm_widget_data_get(obj); if (!wd) return; if (min) *min = wd-lon_min; @@ -310,7 +310,7 @@ EAPI void elm_route_latitude_min_max_get(const Evas_Object *obj, double *min, double *max) { - ELM_CHECK_WIDTYPE(obj, widtype) EINA_FALSE; + ELM_CHECK_WIDTYPE(obj, widtype); Widget_Data *wd = elm_widget_data_get(obj); if (!wd) return; if (min) *min = wd-lat_min; -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Virtualization Cloud Management Using Capacity Planning Cloud computing makes use of virtualization - but cloud computing also focuses on allowing computing to be delivered as a service. http://www.accelacomm.com/jaw/sfnl/114/51521223/ ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: sanjeev IN trunk/elementary/src: edje_externals lib
I am inclined to use a more generic name like source or uri. 'uri' would be consistent with ecore_con API, ecore_con_url_url_set (Ecore_Con_Url *url_con, const char *url) but it doesn't convey the meaning of 'local file'. 'source' would be more generic but not consistent with either evas or ecore_con API. Android uses the term DataSource - setDataSource (FileDescriptor fd) I am inclined towards 'source_set'. On Wed, Feb 22, 2012 at 8:30 AM, Daniel Juyung Seo seojuyu...@gmail.comwrote: I also prefer uri stuff. It's universal it includes file stuff :) Daniel Juyung Seo (SeoZ) On Tue, Feb 21, 2012 at 9:46 PM, Vincent Torri vincent.to...@gmail.com wrote: On Tue, Feb 21, 2012 at 12:53 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi wrote: On Tuesday, February 21, 2012, Cedric BAIL wrote: On Tue, Feb 21, 2012 at 12:26 PM, Gustavo Sverzut Barbieri barbi...@profusion.mobi javascript:; wrote: It makes no sense to keep _file_set() and abuse file parameter as uri to give remote pointers... Why raster requested it ? For coherency, because we do image_file_set, edje_object_file_set and other. But this call can only handle file, not uri at all. Why not keep only uri_set? I completly agree with you, it make no sense. I already opposed that change on irc this morning and I continue to think it's a bad idea. Better fix emotion to use uri_set than to force elm_video to have file_set. Full ack, also webkit uses uri set... In my opinion users will get confused okay, this opens a FILE, how do I open an HTTP? google... ah, they abused it in an unexpected way As Cedric put quite well, the consistency do not hold as the Evas or Edje can't load remote resources. Remote media is actually more common than local :-) I would also prefer to have _uri. Media are specific stuff Vincent -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
Re: [E-devel] E SVN: sanjeev trunk/espionnage/src/bin
As per emotion_smart.c - emotion_object_last_position_load(), it should. On Tue, Feb 21, 2012 at 3:34 PM, Vincent Torri vincent.to...@gmail.comwrote: On Tue, Feb 21, 2012 at 6:53 AM, Enlightenment SVN no-re...@enlightenment.org wrote: Log: Fix elm_video_uri_set usage in esopinage. Signed-off-by: Sanjeev BA eflel...@gmail.com Author: sanjeev Date: 2012-02-20 21:53:08 -0800 (Mon, 20 Feb 2012) New Revision: 68201 Trac: http://trac.enlightenment.org/e/changeset/68201 Modified: trunk/espionnage/src/bin/espionnage_main.c Modified: trunk/espionnage/src/bin/espionnage_main.c === --- trunk/espionnage/src/bin/espionnage_main.c 2012-02-21 05:52:55 UTC (rev 68200) +++ trunk/espionnage/src/bin/espionnage_main.c 2012-02-21 05:53:08 UTC (rev 68201) @@ -59,7 +59,7 @@ break ; } - elm_video_uri_set(video, data); + elm_video_file_set(video, data); why ? doen't file://my_file work at all ? Vincent elm_video_play(video); } @@ -404,7 +404,7 @@ if (webcam) { elm_object_text_set(hoversel, emotion_webcam_name_get(webcam)); -elm_video_uri_set(video, emotion_webcam_device_get(webcam)); +elm_video_file_set(video, emotion_webcam_device_get(webcam)); elm_video_play(video); } else -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-svn mailing list enlightenment-...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-svn -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel -- Keep Your Developer Skills Current with LearnDevNow! The most comprehensive online learning library for Microsoft developers is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, Metro Style Apps, more. Free future releases when you subscribe now! http://p.sf.net/sfu/learndevnow-d2d ___ enlightenment-devel mailing list enlightenment-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/enlightenment-devel